Make script better. "Just Joined"

xOscar · **Author**

Hey, I wonder how to make this script even better!
When a player joins, it should print to server console.

PHP Code:


			
#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init() {
    register_plugin(PLUGIN, VERSION, "Blend");
}

public client_putinserver(id) {
    new szSteamID[32];
    new szName[32];
    new szStatus[32];
    
    if (is_user_admin(id))
        status = "[ADMIN]";
    else
        status = "[USER]";
    
    get_user_authid(id, szSteamID, charsmax(szSteamID));
    get_user_name(id,szName,31);
    server_print("---^n--- Name: %s - SteamID: %s, just joined %s^n---", szName, szSteamID, szStatus);
}

Updated Code (Compiling without errors)

PHP Code:


			
#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init()
    register_plugin(PLUGIN, VERSION, "Blend");

public client_putinserver(id){
    new szName[32];
    new szStatus[8];
    new szSteamID[22];
    new szIp[16];

    get_user_authid(id, szSteamID, charsmax(szSteamID));
    get_user_name(id, szName, charsmax(szName));
    get_user_ip(id, szIp, charsmax(szIp), 1);
    formatex(szStatus, charsmax(szStatus), "%s", is_user_admin(id) ? "ADMIN" : "USER");
    server_print("] Name: %s [%s]^n] SteamID: %s^n] IP: %s", szName, szStatus, szSteamID, szIp);
}

Description: Printing out Player Name, SteamID & IP to the servers console when a player is put in to server.
Also the Access-Status.. ADMIN / USER

EDUTz

Maybe like this ?

Code:

#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init() {
    register_plugin(PLUGIN, VERSION, "Blend");
}

public client_putinserver(id) {
    if (is_user_admin(id))
            server_print("---^n--- Name: %s - SteamID: %s, just joined [ADMIN]^n---", get_user_name(id), get_user_authid(id));
    else
            server_print("---^n--- Name: %s - SteamID: %s, just joined [USER]^n---", get_user_name(id), get_user_authid(id));

}

pokemonmaster

Quote:

Originally Posted by EDUTz

Maybe like this ?

Code:

#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init() {
    register_plugin(PLUGIN, VERSION, "Blend");
}

public client_putinserver(id) {
    if (is_user_admin(id))
            server_print("---^n--- Name: %s - SteamID: %s, just joined [ADMIN]^n---", get_user_name(id), get_user_authid(id));
    else
            server_print("---^n--- Name: %s - SteamID: %s, just joined [USER]^n---", get_user_name(id), get_user_authid(id));

}

Totally wrong.
The first one was the best

jimaway · *Last edited by jimaway; 11-23-2012 at 05:06.*

Code:

new szStatus[32];
    
    if (is_user_admin(id))
        status = "[ADMIN]";
    else
        status = "[USER]";

->

Code:

new szStatus[8]; //no point in making this array bigger than you will ever use
formatex(szStatus, charsmax(szStatus), "%s", is_user_admin(id) ? "[ADMIN]" : "[USER]");

xOscar

Thanks for help, I would appreciate more help!

PHP Code:


			
#include < amxmodx >
#include < amxmisc >

#define PLUGIN "justJoined"
#define VERSION "0.1"

public plugin_init() {
    register_plugin(PLUGIN, VERSION, "Blend");
}

public client_putinserver(id) {
    new szSteamID[32];
    new szName[32];
    new szStatus[8];
    new szIp[32];

    get_user_authid(id, szSteamID, charsmax(szSteamID));
    get_user_name(id,szName,31);
    get_user_ip(id, szIp, 31, 1);
    formatex(szStatus, charsmax(szStatus), "%s", is_user_admin(id) ? "[ADMIN]" : "[USER]");
    server_print("[] Name: %s - SteamID: %s - IP: %s ^n[] %s", szName, szSteamID, szIp, szStatus);
}