[Black Rose]

Originally Posted by OciXCrom Why not?

That is still determined when compiled using the includes and might not be the same version as the server running the plugin.
Everything compiled on this site using "Get Plugin" will be treated as 1.8.2 when compiled.

On topic:
Also, if this is changed (which I missed previously) the plugin can be compiled online.

#include <cl_buy> 

->

forward client_buy(id, item);

[OciXCrom]

That's exactly what I'm talking about. The compiler will determine if the function exists while compiling and will choose which code to execute. Here's a simple code that proves my point:

#include <cstrike>

#if defined CS_OnBuy
    #error test1
#else
    #error test2
#endif 

The code will output "test1" when compiled under a 1.8.3 compiler that has the CS_OnBuy function.
The code will output "test2" when compiled under a 1.8.2 compiler that doesn't have the CS_OnBuy function.

With that being said, he can simply do this:

#if defined CS_OnBuy
public CS_OnBuy(id, iItem)
#else
public client_buy(id, iItem)
#endif
{
    // Code...
}

[Black Rose]

I understand your point and you are right in theory if the compiler version and the AMXX version was exactly the same. However there's nothing guaranteeing that.

I have two servers, one with 1.8.2 and one with the latest dev version of 1.8.3. I don't have two sets of includes and compilers set up. I compile everything with 1.8.2 and make adjustments necessary if 1.8.3 functions are used. Why do I do this? Because this site has the exact same layout. I want everything I make being easily downloaded from this site, running without any issues and completely eliminated of all possible reasons for bugs.

If you compile this plugin using this website it will not have CS_OnBuy defined meaning it doesn't matter if you run 1.8.3 on your server. It's already gone as soon as you downloaded it and you are therefor required to use client_buy().

Don't get me wrong. There are things that should be checked while compiling but only to avoid compilation issues. You don't want to redefine or redeclare natives, constants or whatever. But it should never be used to determine variables in the runtime environment, the compiler doesn't have that information.

I'm doing a whole thread about this since I see this a lot. I'm just gathering information for it.

[sekac]

I still haven't been able to get the ace message... There are 5 enemies and I kill all of them and instead of the ace message I get you killed x enemies.

[EFFx]

It's normal, it happens sometimes on CSGO too.

[sekac]

No it doesn't happen in csgo. Also, I tried it like 20 times it still showed the same message.

[EFFx]

It does, I've watched all CSGO's events and that happened, don't know if they changed it.

[sekac]

20 tries later still no ace message

[EFFx]

Updated the plugin:

- Changed the whole way to get an event from the round.
- Fixed some messages and checks inside the plugin.
- Removed the chance format, it's totally random (but rare events will be the first thing that the code will search for, otherwise, it chooses a random one).

A new log with all events that happened with the new format:

L 09/04/2019 - 20:27:43: Lean received 2 different attacks before dying.
L 09/04/2019 - 20:28:48: Ygor's accuracy was 100% while his team was 66%
L 09/04/2019 - 20:31:24: Lean given damage to 3 different enemies before dying.
L 09/04/2019 - 20:33:02: Enz0_M brought a knife to a gunfight.
L 09/04/2019 - 20:34:15: Enz0_M survived the most time: 69 seconds.
L 09/04/2019 - 20:35:10: The Counter-Terrorists eliminated the Terrorists in 50 seconds.
L 09/04/2019 - 20:36:53: Counter-Terrorists had the best accuracy with 43%
L 09/04/2019 - 20:38:07: 113 shots were fired that round.
L 09/04/2019 - 20:40:51: Lean killed an enemy with his last bullet.
L 09/04/2019 - 20:41:57: Ygor survived attacks from 3 different enemies.
L 09/04/2019 - 20:43:32: Marc0la killed 3 enemies with under 25 health.
L 09/04/2019 - 20:44:36: Ster brought a knife to a gunfight.
L 09/04/2019 - 20:46:39: Igorzao given damage to 5 different enemies before dying.
L 09/04/2019 - 20:48:39: 116 shots were fired that round.
L 09/04/2019 - 20:50:14: Lean caused the first death after 18 seconds of round starts.
L 09/04/2019 - 20:51:50: As the last member alive, Ygor killed 2 enemies and won.
L 09/04/2019 - 20:54:21: Ster killed 2 opponents.
L 09/04/2019 - 20:55:32: Fer caused the first death after 17 seconds of round starts.
L 09/04/2019 - 20:58:54: Lean jumped 12 times during the round.
L 09/04/2019 - 21:00:26: Fer lasted 2 consecutive rounds without dying.
L 09/04/2019 - 21:01:19: Dan survived the most time: 48 seconds.
L 09/04/2019 - 21:03:22: Terrorists had the best accuracy with 57%
L 09/04/2019 - 21:04:31: Marc0la caused the first death after 17 seconds of round starts.
L 09/04/2019 - 21:06:13: 101 shots were fired that round.
L 09/04/2019 - 21:07:58: Ster survived attacks from 2 different enemies.
L 09/04/2019 - 21:08:42: Marcola received 2 different attacks before dying.
L 09/04/2019 - 21:09:29: Ygor killed an enemy with knife.
L 09/04/2019 - 21:10:56: Ster survived the most time: 82 seconds.

As you guys can see, there are 8 repeats from 3 types of events only, which means 29% of the whole list (71% accurate).

Another LOG list:

L 09/04/2019 - 23:58:22: Nando lasted 2 consecutive rounds without dying.
L 09/05/2019 - 00:00:21: PROTOTYPE survived the most time: 114 seconds.
L 09/05/2019 - 00:02:47: Fer finished off 3 woundest enemies.
L 09/05/2019 - 00:04:19: Gostoso given damage to 2 different enemies before dying.
L 09/05/2019 - 00:06:34: Dan killed an enemy with knife.
L 09/05/2019 - 00:08:10: Nando caused the first death after 17 seconds of round starts.
L 09/05/2019 - 00:09:16: Fer received 2 different attacks before dying.
L 09/05/2019 - 00:11:43: aLAN jumped 10 times during the round.
L 09/05/2019 - 00:13:19: Counter-Terrorists had the best accuracy with 37%
L 09/05/2019 - 00:16:04: Nando killed 2 enemies with under 25 health.
L 09/05/2019 - 00:17:42: PROTOTYPE killed 2 enemies with headshots that round.
L 09/05/2019 - 00:19:06: NoNickName_WILL killed an enemy in the air.
L 09/05/2019 - 00:19:53: The Counter-Terrorists eliminated the Terrorists in 42 seconds.
L 09/05/2019 - 00:22:51: Nando killed 2 enemies with headshots that round.
L 09/05/2019 - 00:24:39: Marcola's accuracy was 75% while his team was 33%
L 09/05/2019 - 00:26:18: Marcola killed 2 opponents.
L 09/05/2019 - 00:27:12: Fer received 2 different attacks before dying.
L 09/05/2019 - 00:28:34: aLAN survived attacks from 3 different enemies.
L 09/05/2019 - 00:32:09: Dan jumped 10 times during the round.
L 09/05/2019 - 00:34:38: Ace! Nando killed the entire enemy team.

A total of 20 events, only 2 repeated types of events repeated ONCE, which means 10% of the total value of events (90% better).

[sanimare]

What about adding languages? Would be useful!