[GlobalPlague]

Hello. I opened the main code of ZPA, and i added the following code at the bottom of the main ZPA code:

PHP Code:

AddCommas( iNum , szOutput[] , iLen )
{
    new szTmp[ 15 ] , iOutputPos , iNumPos , iNumLen;
    
    if ( iNum < 0 )
    {
        szOutput[ iOutputPos++ ] = '-';
        iNum = abs( iNum );
    }
    
    iNumLen = num_to_str( iNum , szTmp , charsmax( szTmp ) );

    if ( iNumLen <= 3 )
    {
        iOutputPos += copy( szOutput[ iOutputPos ] , iLen , szTmp );
    }
    else
    {
        while ( ( iNumPos < iNumLen ) && ( iOutputPos < iLen ) ) 
        {
            szOutput[ iOutputPos++ ] = szTmp[ iNumPos++ ];
        
            if( ( iNumLen - iNumPos ) && !( ( iNumLen - iNumPos ) % 3 ) ) 
                szOutput[ iOutputPos++ ] = ',';
        }
        
        szOutput[ iOutputPos ] = EOS;
    }
    
    return iOutputPos;
} 


Then i added "AddCommas" in the following code:

	// Spectating someone else?
	if (id != ID_SHOWHUD)
	{
		// Show name, health, class, and ammo packs and armor
		set_dhudmessage(0, 0, 138, HUD_SPECT_X, HUD_SPECT_Y, 1, 6.0, 1.1, 0.0, 0.0)
		show_dhudmessage(ID_SHOWHUD, "%L %s^nHP: %d - %L %s - %L %d - %L %d", ID_SHOWHUD, "SPECTATING", g_playername[id],
		pev(id, pev_health), ID_SHOWHUD, "CLASS_CLASS", class, ID_SHOWHUD, "AMMO_PACKS1", g_ammopacks[id], ID_SHOWHUD, "ARMOR", pev(id, pev_armorvalue))
	}
	else
	{
		// Show health, class and ammo packs and armor
		set_dhudmessage(red, green, blue, HUD_STATS_X, HUD_STATS_Y, 0, 6.0, 1.1, 0.0, 0.0)
		show_dhudmessage(ID_SHOWHUD, "%L: %d - %L %s - %L %d - %L %d^nXP: %d/%d | Level: %d/%d: %s", id, "ZOMBIE_ATTRIB1", pev(ID_SHOWHUD, pev_health), ID_SHOWHUD, "CLASS_CLASS",
		class, ID_SHOWHUD, "AMMO_PACKS1", g_ammopacks[ID_SHOWHUD], ID_SHOWHUD, "ARMOR", pev(ID_SHOWHUD, pev_armorvalue), mysystem_get_user_xp(id), mysystem_get_user_next_xp(id), mysystem_get_user_level(id), mysystem_get_max_levels(), rankname, AddCommas(g_ammopacks[id]))
	}
}

The "AddCommas" is marked in red, so it can be easier for you to see it. Just use the scroll-bar, and move it to the right side of your screen, so you can see where the "AddCommas" is added.

When i tried to compile the .sma file, i got the following message:

"zombie_plague_advance_v1-6-1.sma(11136 -- 11137) : error 088: number of arguments does not match definition"

This is the code from line 11136 to 11137:

PHP Code:

        show_dhudmessage(ID_SHOWHUD, "%L: %d - %L %s - %L %d - %L %d^nXP: %d/%d | Level: %d/%d: %s", id, "ZOMBIE_ATTRIB1", pev(ID_SHOWHUD, pev_health), ID_SHOWHUD, "CLASS_CLASS",
        class, ID_SHOWHUD, "AMMO_PACKS1", g_ammopacks[ID_SHOWHUD], ID_SHOWHUD, "ARMOR", pev(ID_SHOWHUD, pev_armorvalue), mysystem_get_user_xp(id), mysystem_get_user_next_xp(id), mysystem_get_user_level(id), mysystem_get_max_levels(), rankname, AddCommas(g_ammopacks[id])) 


So, can someone explain to me how to fix this error?

Thanks.

[Supremache]

We told you how to use it in the old topic!!

AddCommas( iNum ( The number that you want to be with commas, szOutput[] Buffer to store the nummber with commas. , Maximum buffer length. )

PHP Code:

new szOutput[ 16 ];
AddCommas( iNum, szOutput , charsmax( szOutput ) )
log_amx( "Number with commas: %s", szOutput ) 


[OciXCrom]

As you can see from the function's body:

AddCommas( iNum , szOutput[] , iLen )

it has 3 required arguments. You used only the first one - iNum, hence why it says "number of arguments does not match definition".

Since the function formats a string (not a number because numbers cannot contain commas), you need to store the string in a variable (because returning strings directly is not good practice).

new szNumberWithCommas[10] // 10 would be the maximum length of the string (each number and comma is a separate character - feel free to increase the number if you need more space)
AddCommas(g_ammopacks[id], szNumberWithCommas, charsmax(szNumberWithCommas))

Then you would use szNumberWithCommas in your message instead of AddCommas(g_ammopacks[id]).

Also, since you're now working with a string, you must change the %d in the message associated with this argument to %s.

%d is used for numbers (same as %i)
%s is used for strings

[Natsheh]

Originally Posted by OciXCrom As you can see from the function's body: AddCommas( iNum , szOutput[] , iLen )

Its the function parameters.

The function body which what lies between { the curly brackets }

Originally Posted by OciXCrom (not a number because numbers cannot contain commas), you need to store the string in a variable (because returning strings directly is not good practice).

A number can be equal to a comma depending on its definition in ASCII characters order.

Returning a string by value is not recommended because it takes more time until the function stops executing, you can read more about returning strings or arrays by value in the c++ documentation.

[fysiks]

Originally Posted by Natsheh A number can be equal to a comma depending on its definition in ASCII characters order.

That doesn't make any sense.

[HamletEagle]

Originally Posted by fysiks That doesn't make any sense.

He didn't phrase that very well, but what he meant is that characters are internally represented by their ASCII value so a comma is actually a number. ',' = 44

No idea why this was relevant to the topic, you will have to ask Natsheh.