[Eriurias]

Authors: Eriurias & PRoSToTeM@
Version: 2.0

Description: The plugin allows you to drop grenades, like other weapons.

Advantage: The plugin does not create any objects. Everything happens through the original function of GameDLL. The plugin only allows you to drop grenades + corrects drop flashbang grenades.

Used modules:
Fun
Cstrike
Fakemeta
Hamsandwich

My GitHub Repository.

[DeathOrAlive]

Nice job! Can be very useful for some servers!

[Eriurias]

Originally Posted by DeathOrAlive Nice job! Can be very useful for some servers!

Thank you. : )

[HamletEagle]

Some fast thoughts:
1.Use real offset names, for readability. Instead OFFSET_ACTIVE_ITEM it should be m_pActiveItem.
2.Don't use fakemeta_util. This library is nice for learning but it's horrible slower comparing with fun/cstrike/fakemeta/engine. You should not use it in plugins. For example, instead of fm_give_item use give_item from fun.
3.In ClCmdDrop static is not needed, use new.
4.

PHP Code:

  if (cs_get_user_bpammo(nClientIndex, CSW_FLASHBANG) == -1)
            cs_set_user_bpammo(nClientIndex, CSW_FLASHBANG, 1);
        else if (cs_get_user_bpammo(nClientIndex, CSW_FLASHBANG) == -2)
            cs_set_user_bpammo(nClientIndex, CSW_FLASHBANG, 2); 


You can do it like that: cs_set_user_bpammo(nClientIndex, CSW_FLASHBANG, abs(cs_get_user_bpammo(nClientIndex, CSW_FLASHBANG)))
That way you will have also a better compatibility with other plugins that allow you to buy more grenades or even give them to players(and this is a common scenario).
5.In fwHamItemCanDrop_Pre make sure the entity is valid.
6.In FM_ClientCommand g_fIsFlashbangActive = false; should be inside the if check. Also the hook should be registered in drop command and unregistered right after it's succesfully executed.

Another thing is that you consider max grenades as being 1/1/2, which can be broken very easy, you should assume that max grenades ammount is unknown and make code a bit more dynamic. Probably not hard, just a matter of changing checks like == 2 to >= 2.
That's at a quick glance, later I will check more.

[Arkshine]

6. No, sizeof is an operator which generates size at compile time.

[Eriurias]

Originally Posted by HamletEagle Some fast thoughts: 1.Use real offset names, for readability. Instead OFFSET_ACTIVE_ITEM it should be m_pActiveItem. 2.Don't use fakemeta_util. This library is nice for learning but it's horrible slower comparing with fun/cstrike/fakemeta/engine. You should not use it in plugins. For example, instead of fm_give_item use give_item from fun. 3.In ClCmdDrop static is not needed, use new. 4. PHP Code:   if (cs_get_user_bpammo(nClientIndex, CSW_FLASHBANG) == -1)             cs_set_user_bpammo(nClientIndex, CSW_FLASHBANG, 1);         else if (cs_get_user_bpammo(nClientIndex, CSW_FLASHBANG) == -2)             cs_set_user_bpammo(nClientIndex, CSW_FLASHBANG, 2);  You can do it like that: cs_set_user_bpammo(nClientIndex, CSW_FLASHBANG, abs(cs_get_user_bpammo(nClientIndex, CSW_FLASHBANG))) That way you will have also a better compatibility with other plugins that allow you to buy more grenades or even give them to players(and this is a common scenario). 5.In fwHamItemCanDrop_Pre make sure the entity is valid. 6.sizeof(szItemList) should be cached before loop. Trivial, but let's keep good practices. 7.In FM_ClientCommand g_fIsFlashbangActive = false; should be inside the if check. Also the hook should be registered in drop command and unregistered right after it's succesfully executed. Another thing is that you consider max grenades as being 1/1/2, which can be broken very easy, you should assume that max grenades ammount is unknown and make code a bit more dynamic. Probably not hard, just a matter of changing checks like == 2 to >= 2. That's at a quick glance, later I will check more.

1. was laziness remember names. However, what a difference.
2. Thanks for the advice. The next time I will consider.
3. Static is faster in Pawn. Examine the AMX Mod X Source code if you do not believe.
4. Thank you for your good advice. =)
5. It is always valid. It same hamsandwich. Or I'm wrong?

7. Yes, you're right, it should be within the conditions. This inattention, sorry.

[HamletEagle]

1.I told you, it's about readability. Think that you don't know what this offset does. A way to find out is to search in the sdk(HLSDK/CSSDK if cs related) and to see where it's used. But, I won't find anything with OFFSET_ACTIVE_ITEM, in game it's named m_pActiveItem. For readability and for consistency you should name them correctly(as in game). It helps the others that look into your code.
3.static means that the variable will be initialized only one time, this is usefull in per frame forwards(like AddToFullPack/PreThink etc) or on big arrays when you need to allocate memory only one time, to do not go over stack size. In a case of a command like "drop" that is called only few times per round static is misused. What you gain by using static likely doesn't matter. Don't try to micro-optimize.
5.You can't know what happens with this entity, it's good practice to put proper checks. "It same hamsandwich" not sure to get what you mean, ham only hook and call game virtual functions.

A plugin should work as intended, to be user friendly, to be originall and to have a sane code.

Moreover:
You likely don't need to register the "drop" cmd, just do what you do in ClCmdDrop into fwHamItemCanDrop_Pre. When someone send drop game calls CBasePlayer:: DropPlayerItem, which calls CanDrop() in order to know if it's a dropable item and your fwHamItemCanDrop_Pre hook gets triggered. So CanDrop is fired right after "drop" command. To get the player index use pev_owner.

[Eriurias]

UPDATE version 2.0 - Cosmetic changes; - Small optimization.

Thank to user HamletEagle.

[HamletEagle]

I have more suggestions

1.As I said, static is misused in fwHamItemCanDrop_Pre.
2.Name your vars correctly. g_fIsFlashbangActive f stands from float, but the var is a bool, so it should be b.
3.Do you think you can add support for all nades ? Just change g_nRestoreFlashbangCount and g_fIsFlashbangActive into array like g_nRestoreNadeCount[3], g_fIsNadeActive[3], then you can index by the enum you already created. Check entity CSW_* index and decide if you index by HEGRENADE/FLASHBANG/SMOKEGRENADE. That way your code will be more dynamic. If you are not sure how to design this tell me.
4.FM_ClientCommand is called for other commands than "drop". Register it in fwHamItemCanDrop_Pre(instead of init) and unregister the hook right after you do your checks and set bpammo. You could also make sure it's called for drop command(read_argv(0, cmd, charsmax(cmd)) and see if it's "drop").

If you don't understand something ask, don't forget that everything I said can be discussed.

[Eriurias]

Originally Posted by HamletEagle I have more suggestions 1.As I said, static is misused in fwHamItemCanDrop_Pre. 2.Name your vars correctly. g_fIsFlashbangActive f stands from float, but the var is a bool, so it should be b. 3.Do you think you can add support for all nades ? Just change g_nRestoreFlashbangCount and g_fIsFlashbangActive into array like g_nRestoreNadeCount[3], g_fIsNadeActive[3], then you can index by the enum you already created. Check entity CSW_* index and decide if you index by HEGRENADE/FLASHBANG/SMOKEGRENADE. That way your code will be more dynamic. If you are not sure how to design this tell me. 4.FM_ClientCommand is called for other commands than "drop". Register it in fwHamItemCanDrop_Pre(instead of init) and unregister the hook right after you do your checks and set bpammo. You could also make sure it's called for drop command(read_argv(0, cmd, charsmax(cmd)) and see if it's "drop"). If you don't understand something ask, don't forget that everything I said can be discussed.

1. I forgot about it.
2. This is similar to the carping !
3. Because of my poor understanding of English, do not understand you..
4. It is easier to register Post event CanDrop. Again, because of the language barrier, I do not quite understand you..