[Catalinn]

i am getting this error continuously and my eyes do not see the error, could you guide me a bit? thank you

PHP Code:

L 08/11/2023 - 20:11:21: Start of error session.
L 08/11/2023 - 20:11:21: Info (map "zm_vendetta") (file "addons/amxmodx/logs/error_20230811.log")
L 08/11/2023 - 20:11:21: [nVault] Invalid vault id: 0

L 08/11/2023 - 20:11:21: [AMXX] Displaying debug trace (plugin "zombie_xp.amxx")
L 08/11/2023 - 20:11:21: [AMXX] Run time error 10: native error (native "nvault_set")
L 08/11/2023 - 20:11:21: [AMXX]    [0] zombie_xp.sma::save_data (line 740)
L 08/11/2023 - 20:11:21: [AMXX]    [1] zombie_xp.sma::fw_svshutdown (line 843) 


PHP Code:

public save_data(id)
{
        new vaultkey[40],vaultData[256];
               
        new g_selected_zclass[sizeof g_zclass_load[]] , g_selected_hclass[sizeof g_hclass_load[]] //bug fix for not showing menu if the user hasnt picked a zombie
        if( g_hclass_showmenu[id] == true) { g_selected_hclass = "-1"; } else { formatex(g_selected_hclass, sizeof g_selected_hclass - 1, g_hclass_load[g_humanclassnext[id]]); }
        if( g_zclass_showmenu[id] == true) { g_selected_zclass = "-1"; } else { formatex(g_selected_zclass, sizeof g_selected_zclass -1, g_zclass_load[g_zombieclassnext[id]]); }
       
        formatex( vaultkey, sizeof vaultkey - 1, "%s_stats", userNameID[id]);
        formatex( vaultData, sizeof vaultData - 1, "0=%i;1=%s;2=%s;", userLevel[id], g_selected_hclass, g_selected_zclass);
       
        nvault_set(gvault, vaultkey, vaultData); // <--- line 740 error
    log_to_file("NIVELES.txt", "El jugador %s tiene nivel %i", userNameID[id], userLevel[id]);
} 


PHP Code:

public fw_svshutdown(id)
{
    // Save the data
        save_data(id); // <---- line 843 next error
} 


nvault was opened in plugin_init()

PHP Code:

gvault = nvault_open(PLUGIN_NAME); 


[Bugsy]

Are you closing it somewhere in code? Are you ensuring it opens with a valid handle?

[Catalinn]

Originally Posted by Bugsy Are you closing it somewhere in code? Are you ensuring it opens with a valid handle?

I have the only closure here, what else would I need ??

PHP Code:

public plugin_end()
{
        if( get_pcvar_num(cvar_removexp) == 0)
        {
                // Save everyone's data first
                server_print("%s Saving your clients XP.", textHeader);
       
                for( new o = 1; o < 33; o++)
                {
                        //if ( !is_user_connected(o) || is_user_bot(o) ) continue;
                        if ( !is_user_connected(o) ) continue;
                        if ( is_user_bot(o) ) continue;
                       
                        save_data(o);
                }
        }
 
        nvault_close(gvault)
       
        //Bugfix:
        if( (loadedZombies == false) && ( get_pcvar_num(cvar_removezombie) == 0 ))
        {
                set_pcvar_num(cvar_removezombie, 0);
                set_cvar_num("zp_zombie_classes", 0)   
        }
} 


I've tried this way and I didn't get the error again, i'm not sure if it would be valid..


from this

PHP Code:

public fw_svshutdown(id)
{
    // Save the data
        save_data(id);
} 


a

PHP Code:

public fw_svshutdown(id)
{
        for (new id = 1; id <= g_maxplayers; id++) 
        if (is_user_connected(id)) 
        save_data(id)
} 


[Bugsy]

Just call save_data() at client_disconnect, this will handle all scenarios (disconnect, server shutdown, map change, etc). It's likely that plugin_end() is called before fw_svshutdown and is resulting in your error, plus svshutdown is likely not tied to a player as it's a server event, so passing an id parameter is doing nothing.

[Catalinn]

Originally Posted by Bugsy Just call save_data() at client_disconnect, this will handle all scenarios (disconnect, server shutdown, map change, etc). It's likely that plugin_end() is called before fw_svshutdown and is resulting in your error, plus svshutdown is likely not tied to a player as it's a server event, so passing an id parameter is doing nothing.

And if the server goes down due to an error or attack, would it work?

[Bugsy]

Originally Posted by Catalinn And if the server goes down due to an error or attack, would it work?

If the server goes down via crash then all bets are off as no plug-ins can handle that, aside from saving data at an interval. If it shuts down gracefully, you are good using client_disconnect().

[Catalinn]

Originally Posted by Bugsy If the server goes down via crash then all bets are off as no plug-ins can handle that, aside from saving data at an interval. If it shuts down gracefully, you are good using client_disconnect().

I figured it, solved then, thank you very much!