[~Ice*shOt]

For example I have this function

PHP Code:

public Ham_Spawn_Post( id )
{
    if( !is_user_alive( id ) )
        return HAM_IGNORED;

    g_bAlive[ id ] = true;
} 


Should I always check, is it false before setting it true?

PHP Code:

public Ham_Spawn_Post( id )
{
    if( !is_user_alive( id ) )
        return HAM_IGNORED;

    if( !g_bAlive[ id ] )
        g_bAlive[ id ] = true;
} 


Or this make no sense?

[HamletEagle]

The check is useless in this context.

[~Ice*shOt]

Can you give an example where it could be useful?

[wickedd]

You should, but it isn't necessary.

Originally Posted by ~Ice*shOt Can you give an example where it could be useful?

PHP Code:

#include <amxmodx>

new bool:your_bool[ 33 ]

public plugin_init( )
{
    register_clcmd( "say /test","try_this")
}

public client_connect( id )
{
    your_bool[ id ] = false
}

public try_this( id )
{
    if( !your_bool[ id ] )
    {
        client_print( id, print_chat, "It works" )
        your_bool[ id ] = true;
    }
    else
    {
        client_print( id, print_chat, "You tried it already" )
    }
} 


Lets say you want a player to able to use a cmd only once, you can do something like this.

[~Ice*shOt]

OK, but checking in my example is necessary, let's say there are 1 terrorist and 2 cts (g_bAlive[ id ] = true), that one terrorist kill 2 cts (g_bAlive[ id ] = false). On spawn it is setting again g_bAlive[ id ] = true for both team players, but terrorist already have this bool true (because he didn't died in previous round) so it would be pointless to set it twice. My question is there's difference if I set it true twice, or better check and don't set if it is already true?

[wickedd]

Yes it would be pointless, but it wont affect anything by setting it true again is my point.

[HamletEagle]

IIRC when you set a value to a var it doesn't use any memory, it use memory only when it is created, so setting again is not a problem.

[klippy]

Just setting it should be faster then checking if it was already set beforehand, although it's just trivial difference. Anyway, there's no need to check for variable's value first.