[One]

PHP Code:

public Cmd_Say(id)
{
    static say_args[64]
    read_args(say_args, charsmax(say_args))
    remove_quotes(say_args)

    if(say_args[0] != '/')
    {
        return PLUGIN_CONTINUE
    }
    if(equali(say_args, "/stop") || equali(say_args, "/reset") )
    {
        if(task_exists(id))
        {
            remove_task(id)
        }
        users_time[id] = 0.0
        user_is_in_time[id] = 0
        users_fail[id] = 0
        ColorChat(id,NORMAL,"^04%s ^01: You stopped successfully your Timer!",tag)
        
        new ent = -1
        while((ent = find_ent_by_class(ent,"trigger_teleport")))
        {
            new target[32]
            pev( ent, pev_target, target, 31)

            if(equal(target,"start_point"))
            {
                new Float:vTele[3]                
                get_brush_entity_origin(ent, vTele)
                client_print(0,print_chat,"Entity : %f - %f - %f",vTele[0],vTele[1],vTele[2])
                if(is_user_alive(id))
                {
                    set_pev(id,pev_origin,vTele)
                    strip_user_weapons(id)
                    give_item(id,"weapon_knife")
                }
            }
        }
    }
    return PLUGIN_CONTINUE
} 


or is there a better way to do it?

[xPaw]

- You don't need to check task_exists.
- You don't need to search for entities if player is not alive (right?)
- You can just make players touch the teleport instead of setting their origin (fake_touch)
- You can just register commands isntead of manually checking in "say" hook

[One]

Originally Posted by xPaw - You don't need to check task_exists. - You don't need to search for entities if player is not alive (right?) - You can just make players touch the teleport instead of setting their origin (fake_touch) - You can just register commands isntead of manually checking in "say" hook

thanks.
i will do it with fake touch and remove the if.
and yop your right. i have to check if my user is alive. my bad.

i have to add more commands. thats why i hook the say cmd.
there willbe more say cmds.

thanks again.

[ConnorMcLeod]

Originally Posted by One i have to add more commands. thats why i hook the say cmd. there willbe more say cmds.

Amount of commands is not a good reason, if you don't need something dynamic, use register_clcmd.

By dynamic i mean /stop + args.
And if you need it, it's still better to let other cmds with register_clcmd, let all checks be made by amxx is more efficient.

[One]

oki :-D
i just tought its better to spamm the code with many register_clcmds.
thanks connor.