Raised This Month: $535 Target: $400
 133% 

SourceMod 1.7 released!


Post New Thread Closed Thread   
 
Thread Tools Display Modes
4bdul
AlliedModders Donor
Join Date: Dec 2011
Location: United Kingdom
Old 03-12-2015 , 08:06   Re: SourceMod 1.7 released!
#91

Quote:
Originally Posted by 4bdul View Post
I'm having trouble with mysql admin groups access, I opened a bug here but I'm not even sure if it's a sourcemod bug.

Edit: Just to clarify, this was working fine in 1.6 - stopped the moment I updated.

Can anyone confirm if they have the same problem or not?
I did a little more digging and here are my findings...

If I use the latest 1.7.1-git5163 (fresh install), it still does not work.

But if I take only the admin-sql-threaded.sp from "1.7.0-git5087" and compile it using the latest version (1.7.1-git5163) or even without compiling it with the latest, it works fine as intended.

I assume whatever changes made to the .sp file is the cause.

All the versions after 1.7.0.git5087 of that single .sp file do not work (AFAIK).

Note: All of this was done under Linux only.
__________________
4bdul is offline
TnTSCS
AlliedModders Donor
Join Date: Oct 2010
Location: Undisclosed...
Old 03-12-2015 , 09:39   Re: SourceMod 1.7 released!
#92

Looks like there was a change in the admin-sql-threaded.sp from 1.7.0-git5087 to 1.7.1-git5163.

There were some SM 1.7 syntax added as replacements for the legacy SM <= 1.6.

If you want to see exactly what was changed, you could use QuickDiff which will highlight the changes for you. Or you could see the differences here, which will be available for 1 month from this post's date

For now, use the SMX from the one that's working until someone has a chance to look at the version from the latest snapshot.

...:: TnT Edit ::...
Note, I have not tested either.
__________________
View my Plugins | Donate

Last edited by TnTSCS; 03-12-2015 at 09:47.
TnTSCS is offline
asherkin
SourceMod Developer
Join Date: Aug 2009
Location: OnGameFrame()
Old 03-12-2015 , 11:25   Re: SourceMod 1.7 released!
#93

Quote:
Originally Posted by 4bdul View Post
All the versions after 1.7.0.git5087 of that single .sp file do not work (AFAIK).
I'm not sure if you picked a build at random (and was very lucky) or bisected, so just to verify (if the former), could you try out 1.7.0-git5090 (or confirm that you already have and it was broken)?
__________________
asherkin is offline
4bdul
AlliedModders Donor
Join Date: Dec 2011
Location: United Kingdom
Old 03-12-2015 , 12:04   Re: SourceMod 1.7 released!
#94

Quote:
Originally Posted by asherkin View Post
I'm not sure if you picked a build at random (and was very lucky) or bisected, so just to verify (if the former), could you try out 1.7.0-git5090 (or confirm that you already have and it was broken)?
I tested 1.7.0-git5090/5094/5099/5103/5150, 1.7.1-git5155/5163 - they all had the same bug - until I reached 1.7.0-git5087.

Edit: Once I had a working version, I then tested only the admin-sql-threaded.smx with the latest build to make sure if it's just that plugin or something else in the build(s) - since it worked, and also worked compiling with the latest build, I then compared the .sp files to notice changes were made - so I assume something with those changes caused the bug.
__________________

Last edited by 4bdul; 03-12-2015 at 12:14.
4bdul is offline
R1KO
Member
Join Date: Sep 2013
Old 03-24-2015 , 07:24   Re: SourceMod 1.7 released!
#95

PHP Code:
StringMap        g_Info[MAXPLAYERS+1] = {null, ...};

g_Info[iClient] = new StringMap();


// 1
// ...

char sTime[64];
hMenu.GetItem(ItemsTimesizeof(sTime));
g_Info[iClient].SetValue("Time"StringToInt(sTime));

// [SM] Native "StringMap.SetValue" reported: Invalid Handle 2e372e31 (error 4) 
// or [SM] Native "StringMap.SetValue" reported: Invalid Handle 85 (error 7)

// ...

char sTime[64];
hMenu.GetItem(ItemsTimesizeof(sTime));
int iTime StringToInt(sTime);
g_Info[iClient].SetValue("Time"iTime);

// So all is well

// 2
char sInfo[128];
hMenu.GetItem(ItemsInfosizeof(sInfo));
LogMessage("1: iClient: %i, Size: %i, %x"iClientg_Info[iClient].Sizeg_Info[iClient]);
// 1: iClient: 5, Size: 6, 20b0060
g_TargetInfo[iClient].SetString("Reason"sInfo);
LogMessage("2: iClient: %i, Size: %i,  %x"iClientg_Info[iClient].Sizeg_Info[iClient]);
// 2: iClient: 5, Size: 7,  20b0060

SendConfirmMenu(iClient);

// ...

SendConfirmMenu(int iClient)
{
    
char sName[MAX_NAME_LENGTH], sReason[128], sTime[128];
    
LogMessage("SendConfirmMenu: iClient: %i, Size: %i, %x"iClientg_Info[iClient].Sizeg_Info[iClient]);
    
// SendConfirmMenu: iClient: 5, Size: 7, 20b0060
    
g_Info[iClient].GetString("Reason"sReasonsizeof(sReason));
    
// [SM] Native "StringMap.GetString" reported: Invalid Handle 2e372e31 (error 4)
    
g_Info[iClient].GetString("TimeInfo"sTimesizeof(sTime));
    
g_Info[iClient].GetString("Name"sNamesizeof(sName));
    
    
// ...

R1KO is offline
Send a message via Skype™ to R1KO
maningrey
Member
Join Date: Sep 2014
Location: Farswitch Newton 1
Old 03-25-2015 , 20:57   Re: SourceMod 1.7 released!
#96

So what if CSGO gets updated to Source 2? Whats the plan there
maningrey is offline
psychonic

BAFFLED
Join Date: May 2008
Old 03-25-2015 , 21:09   Re: SourceMod 1.7 released!
#97

Quote:
Originally Posted by maningrey View Post
So what if CSGO gets updated to Source 2? Whats the plan there
What if dinosaurs come back to take over the world tomorrow?
psychonic is offline
KyleS
SourceMod Plugin Approver
Join Date: Jul 2009
Location: Segmentation Fault.
Old 03-25-2015 , 22:43   Re: SourceMod 1.7 released!
#98

Quote:
Originally Posted by psychonic View Post
What if dinosaurs come back to take over the world tomorrow?
Protobufistmas eve.
KyleS is offline
maningrey
Member
Join Date: Sep 2014
Location: Farswitch Newton 1
Old 03-26-2015 , 13:08   Re: SourceMod 1.7 released!
#99

Quote:
Originally Posted by psychonic View Post
What if dinosaurs come back to take over the world tomorrow?
But in all seriousness, this is more likely to happen ;)
maningrey is offline
psychonic

BAFFLED
Join Date: May 2008
Old 03-26-2015 , 14:23   Re: SourceMod 1.7 released!
#100

Quote:
Originally Posted by maningrey View Post
But in all seriousness, this is more likely to happen ;)
There is no evidence of either happening at all.
psychonic is offline
Closed Thread


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 18:22.


Powered by vBulletin®
Copyright ©2000 - 2023, vBulletin Solutions, Inc.
Theme made by Freecode