[Neeeeeeeeeel.-]

Originally Posted by YamiKaitou I wouldn't suggest looking at the ZP code for anybody, it is a nightmare to figure out.

[fysiks]

Originally Posted by Neeeeeeeeeel.- Join Date: Feb 2009

Join date means nothing. It's just a number.

[hornet]

Emp, if I may make a suggestion, I think it would be a good idea to explain the true purpose of the 3rd parameter in menu_additem(), and then in turn the purpose of menu_item_getinfo(). There's been many posts recently concerning menus where the user has sent the 3rd parameter with just an integer ( in string format ), and seemingly using it as though it's going to be the option number displayed. They then create some arrays and use menu_item_getinfo() in order to retrieve what they don't realise to be, a useless integer, and then start their button check at 1 when it could be started at 0.

[ConnorMcLeod]

It's just a little problem but yes, should be done.
Problem is that many plugins / menus tuts are based on this tutorial, so even if it is changed there, yo gonna keep seeing that usage during a long time.

[Emp`]

Old Quote from 05-22-09

Originally Posted by Emp` Originally Posted by Drak The Item Param seems to send off "0-MAX_ITEMS". Why do we do "menu_additem(Menu,"Text","1");"? This simply works: new Menu = menu_create("Hello World","_MyMenu"); menu_addtext(Menu,"Test"); public _MyMenu(id,Menu,Item) {     switch(Item)     {         case 0: client_print(id,print_chat,"Test Selected.");     } } While that works, the other method gives people a better understanding of the menus for different things. Also, if you want to reorganize a menu, you can just change where it is added, with this method you would need to change where it is added and the code in the handler function.

Yes I have known about it for a while (see quote from almost 4 years ago haha). I will change the snippets around a bit when I have some time. I have been meaning to add in some more complex examples that use the data field besides the MultiHandler example.

Also, the Player examples need to be changed to use userid's instead of just the client index.

Another thing I should note (which I see a lot in the Scripting Help section) is that MEXIT_ALL is the default behavior for MPROP_EXIT and is unneeded most of the time.

Lastly, what ConnorMcLeod pointed out, the Callback example should return ITEM_IGNORE because ITEM_ENABLED will override the admin flag in menu_additem.

Does anyone else have any other changes or comments they would like to see?

[ConnorMcLeod]

About key as string info, it is a good point for menu edition, but i don't think it's a big deal to change cases in switch statement, only problem is when you forgot to change it

Have made changes to player menu if it can saves you some time, and also have a little more complete player menu snippet.

added flag "a" to get_players and renamed access variable into _access since access in now a amxmisc stock.

Spoiler

PHP Code:

#include <amxmodx>
#include <fun>

public plugin_init()
{
    //Register a way to get to your menu...
    register_clcmd( "my_player_menu","AwesomeMenu");
}

public AwesomeMenu(id)
{
    //Create a variable to hold the menu
    new menu = menu_create("\rLook at this Player Menu!:", "menu_handler");

    //We will need to create some variables so we can loop through all the players
    new players[32], pnum, tempid;

    //Some variables to hold information about the players
    new szName[32], szUserId[32];

    //Fill players with available players
    get_players(players, pnum, "a"); // flag "a" because we gonna add health to players, but this is just for this specific case

    //Start looping through all players
    for( new i; i<pnum; i++ )
    {
        //Save a tempid so we do not re-index
        tempid = players[i];

        //Get the players name and userid as strings
        get_user_name(tempid, szName, charsmax(szName));
        formatex(szUserId, charsmax(szUserId), "%d", get_user_userid(tempid));
        menu_additem(menu, szName, szUserId, 0);

        //Add the item for this player
        menu_additem(menu, szName, szUserId, 0);
    }

    //We now have all players in the menu, lets display the menu
    menu_display(id, menu, 0);
}

public menu_handler(id, menu, item)
{
    if( item == MENU_EXIT )
    {
        menu_destroy(menu);
        return PLUGIN_HANDLED;
    }

    new data[6], szName[64];
    new _access, callback;
    menu_item_getinfo(menu, item, _access, data,charsmax(data), szName,charsmax(szName), callback);

    //Get the userid of the player that was selected
    new userid = str_to_num(data);

    //Try to retrieve player index from its userid
    new player = find_player("k", userid); // flag "k" : find player from userid

    //If player == 0, means that players has disconnected
    //If the player is still alive (we had retrieve alive players when formating the menu but some players can have died before id select an item)
    if( player && is_user_alive(player) )
    {
        //Set their health to 100
        set_user_health(player, 100);
    }

    menu_destroy(menu);
    return PLUGIN_HANDLED;
} 


Spoiler

PHP Code:

#include <amxmodx>
#include <amxmisc>

#define VERSION "0.0.1"
#define PLUGIN "Players Menu Generic"

public plugin_init()
{
    register_plugin(PLUGIN, VERSION, "ConnorMcLeod")
    register_clcmd("say /players", "ClCmd_Menu", ADMIN_RCON)
}

public ClCmd_Menu(id, lvl, cid)
{
    if( cmd_access(id, lvl, cid, 0) )
    {
        new iMenu = MakePlayerMenu(id, "Players Menu Misc", "PlayersMenuHandler")
        menu_setprop(iMenu, MPROP_NUMBER_COLOR, "\y")
        menu_display(id, iMenu)
    }
    return PLUGIN_HANDLED
}

enum ( <<= 1 )
{
    PLMENU_OBEY_IMMUNITY = 1,
    PLMENU_ALLOW_SELF,
    PLMENU_ONLY_ALIVE,
    PLMENU_NO_BOTS
}

MakePlayerMenu(id, const szMenuTitle[], const szMenuHandler[], iFlags = PLMENU_OBEY_IMMUNITY)
{
    new iMenu = menu_create(szMenuTitle, szMenuHandler)
    new bool:bIsSuperAdmin
    if( iFlags & PLMENU_OBEY_IMMUNITY )
    {
        bIsSuperAdmin = !!(get_user_flags(id) & ADMIN_RCON)
    }

    new iPlayers[32], iNum, iPlayer, szPlayerName[32], szUserId[32]
    new szFlags[4] = "h"
    if( iFlags & PLMENU_ONLY_ALIVE )
    {
        szFlags[++iNum] = 'a'
    }
    if( flags & PLMENU_NO_BOTS )
    {
        szFlags[++iNum] = 'c'
    }

    get_players(iPlayers, iNum, szFlags)

    for(--iNum; iNum>=0; iNum--)
    {
        iPlayer = iPlayers[iNum]
        get_user_name(iPlayer, szPlayerName, charsmax(szPlayerName))

        if(    iFlags & PLMENU_OBEY_IMMUNITY && !bIsSuperAdmin
        &&    ( (get_user_flags(iPlayer) & ADMIN_IMMUNITY) && 
            ((iFlags & PLMENU_ALLOW_SELF) ? (id != iPlayer) : true) )    )
        {
            menu_addtext(iMenu, szPlayerName)
        }
        else
        {
            formatex(szUserId, charsmax(szUserId), "%d", get_user_userid(iPlayer))
            menu_additem(iMenu, szPlayerName, szUserId, 0)
        }
    }

    return iMenu
}

public PlayersMenuHandler_Sample(id, iMenu, iItem)
{
    if( iItem == MENU_EXIT )
    {
        menu_destroy(iMenu)
        return PLUGIN_HANDLED
    }

    new szUserId[32], szPlayerName[32], iPlayer, iAccess, iCallback
    menu_item_getinfo(iMenu, iItem, iCallback, szUserId, charsmax(szUserId), szPlayerName, charsmax(szPlayerName), iCallback)

    if( (iPlayer = find_player("k", str_to_num(szUserId)))  )
    {
        new szName[32]
        get_user_name(iPlayer, szName, charsmax(szName))
        client_print(id, print_chat, "You have chosen #%s %s %s", szUserId, szPlayerName, szName)
    }
    else
    {
        client_print(id, print_chat, "Player %s<%s> seems to be disconnected", szPlayerName, szAuthid)
    }
    menu_destroy(iMenu)
    return PLUGIN_HANDLED
} 


[hornet]

Nice work guys, good idea stickying the thread too. However IMO Emp I think the first example ( Basic Menu ) could still do without menu_item_getinfo().

for(--iNum; iNum>=0; iNum--)

Connor I think your preferred reverse cycle loop would have confused the average user had it been used in the first post ;)

[Emp`]

Thanks for pointing that out hornet. I revised the examples that don't need menu_item_getinfo.

[ConnorMcLeod]

May be you could put a second exemple with the same basic menu in a static version where you don't have to destroy the menu.

[Mrki_Drakula]

Your Advanced Vote Menu never gives ends and never gives a player 255 health. I can't find the error. Could somebody look for it?