[berni]

Works great now.
Could you also add a function for reading a config array into an adt array ?
Not important tho, can write that function myself

Yah ! no more stupid keyvalue files

Thanks, greetings ~Berni

[sfPlayer]

I don't think that's worth it since you already have random access using ConfigLookup* without too much overhead, at least if it's not in OnGameFrame.

An ADT_Array can cover only simple 1-dimensional config files so it's up to you to build one if you need it.

[Thraka]

0_0

This extension is awesome!

[Chanz]

Very nice extension. :-)

But I found a small issue:
In my config file I wrote:

PHP Code:

cvar_enable = 1; 


Then I try:

PHP Code:

ConfigLookupBool(config, "cvar_enable") 


It returns 0 instead of 1.

But when I write:

PHP Code:

cvar_enable = true; 


it works.

[sfPlayer]

It'll always return 0 if the type is wrong (1 is no bool).

[Chanz]

Oh ok means clean coding huh?
Unfortunately the 0815 server admin doesn't know about booleans and variable types. I see many post coming up with the question why my plugin does not work and the only problem is that those server admins can't enter true and false instead of 0 and 1.

btw: It's already hard enough for them to find the config file. ;)

I'm not asking to change that behavior, since there are other possibilities to ask the SA (or the client) for the desired configuration. But this takes again some lines of codes and weakens the the improvement of your extension in making the plugin code shorter and more powerful.
Or you need a more time intensive explanation how the new config file works.

Don't get me wrong its just a small issue that itches me, I think your ext is great and should be implemented in SM, since I really hate the kv config file system.

[sfPlayer]

you can easily allow multiple types:

new value = ConfigLookupBool(config, "cvar_enable");
if (value == 0) value = ConfigLookupInt(config, "cvar_enable");

true: value = 1, if doesn't trigger
false: value = 0, if triggers and ConfigLookupInt returns 0 (no int) -> value = 0
1: value = 0 (no bool), if triggers and ConfigLookupInt returns 1 -> value = 1
0: value = 0 (no bool), if triggers and ConfigLookupInt returns 0 -> value = 0

[Chanz]

Oh lol yeah thats easy I just kept my head in the config file instead within the code.
<- through-face-palm

[Thraka]

Shouldn't you be using
new bool:cvar_enable = ConfigLookupBool(config, "cvar_enable")

[Chanz]

yeah you are right but then you need to typecast later when using:

PHP Code:

  if (value == false) value = bool:ConfigLookupInt(config,  "cvar_enable"); 


I would use the first one since I can then check the cvar with

PHP Code:

 if (value > 0) { SetConVarBool(...); } else { SetConVarBool(...); }