[CrazY.]

Hello, what's wrong with this macro?

#define CHECK_ISPLAYER(%1)  if (!(1 <= %1 <= get_maxplayers())) { log_error(AMX_ERR_NATIVE, "[ZP] Invalid player index %d", %1); return 0; } 

[DjSoftero]

what exactly isn`t working? I think you have to add "(" before if statement and at the end of the line. But I could be wrong, because I don`t use macros at all.

PHP Code:

#define CHECK_ISPLAYER(%1)  ( if (!(1 <= %1 <= get_maxplayers())) { log_error(AMX_ERR_NATIVE, "[ZP] Invalid player index %d", %1); return 0; } ) 


or perhaps you can`t use an if statement...

PHP Code:

#define CHECK_ISPLAYER(%1)  ( (!(1 <= %1 <= get_maxplayers())) ? (log_error(AMX_ERR_NATIVE, "[ZP] Invalid player index %d", %1); return 0; ) : (return 1;) ) 


[HamletEagle]

PHP Code:

#define CHECK_ISPLAYER(%1)  \
{ \
    if(!(1 <= %1 <= get_maxplayers())) \
    { \
        log_error(AMX_ERR_NATIVE, "[ZP] Invalid player index %d", %1); \
        return 0; \
    } \
} 


[CrazY.]

Originally Posted by DjSoftero what exactly isn`t working?

Warning 217.

Originally Posted by HamletEagle PHP Code: #define CHECK_ISPLAYER(%1)  \ { \     if(!(1 <= %1 <= get_maxplayers())) \     { \         log_error(AMX_ERR_NATIVE, "[ZP] Invalid player index %d", %1); \         return 0; \     } \ }

Thanks.

[DjSoftero]

i didnt get any warning using this version of compiler: AMX Mod X Compiler 1.8.3-dev+5143

[CrazY.]

Really? Hmm, that's weird, because I'm using the same version...

[CrazY.]

I reopened the thread because I am still getting warning 217 and error 036.

[klippy]

Originally Posted by CrazY. I reopened the thread because I am still getting warning 217 and error 036.

Error code doesn't help much. Better just post compiler output.

[CrazY.]

I have already encountered the problem, it is probably a compiler bug. I can't add the semicolon at the end of the macro, otherwise I get the warning/error I quoted above.

EDIT: In fact, it was my own error, since it is not allowed to add semicolons at the end of a function, just after the bracket.

[PRoSToTeM@]

Originally Posted by HamletEagle PHP Code: #define CHECK_ISPLAYER(%1)  \ { \     if(!(1 <= %1 <= get_maxplayers())) \     { \         log_error(AMX_ERR_NATIVE, "[ZP] Invalid player index %d", %1); \         return 0; \     } \ }

#define CHECK_ISPLAYER(%1)  \
do { \
    if (!(1 <= %1 <= get_maxplayers())) \
    { \
        log_error(AMX_ERR_NATIVE, "[ZP] Invalid player index %d", %1); \
        return 0; \
    } else { \
        break; \
    } \
} while (register_plugin("", "", ""))

Now semicolon can be used.