Raised This Month: $51 Target: $400
 12% 

[TF2] BROFIST (1.2.1, June 20 2014)


Post New Thread Reply   
 
Thread Tools Display Modes
Newbie1992
Senior Member
Join Date: Jan 2013
Location: Germany
Old 07-22-2013 , 03:04   Re: [TF2] BROFIST (1.1, Jun 6 2013)
Reply With Quote #21

Hi,

I have this error in my sm error logs!

Quote:
L 07/21/2013 - 15:27:58: [SM] Displaying call stack trace for plugin "brofist.smx":
L 07/21/2013 - 15:27:58: [SM] [0] Line 137, brofist.sp::IsClientCloseEnoughToBROFIST()
L 07/21/2013 - 15:27:58: [SM] [1] Line 121, brofist.sp::Timer_ShakeScreen()
L 07/21/2013 - 15:27:59: [SM] Native "GetClientEyePosition" reported: Invalid client index -1

L 07/21/2013 - 15:27:59: [SM] Displaying call stack trace for plugin "brofist.smx":
L 07/21/2013 - 15:27:59: [SM] [0] Line 137, brofist.sp::IsClientCloseEnoughToBROFIST()
L 07/21/2013 - 15:27:59: [SM] [1] Line 121, brofist.sp::Timer_ShakeScreen()
L 07/21/2013 - 15:27:59: [SM] Native "GetClientEyePosition" reported: Invalid client index -1

L 07/21/2013 - 15:27:59: [SM] Displaying call stack trace for plugin "brofist.smx":
L 07/21/2013 - 15:27:59: [SM] [0] Line 137, brofist.sp::IsClientCloseEnoughToBROFIST()
L 07/21/2013 - 15:27:59: [SM] [1] Line 92, brofist.sp::Timer_ShowOverlay()
L 07/21/2013 - 15:27:59: [SM] Native "GetClientEyePosition" reported: Invalid client index -1
How i can fix this?

Thanks!
__________________
Newbie1992 is offline
MasterOfTheXP
Veteran Member
Join Date: Aug 2011
Location: Cloudbank
Old 07-22-2013 , 03:25   Re: [TF2] BROFIST (1.1, Jun 6 2013)
Reply With Quote #22

Looks like it's trying to get the eye position of a client who most likely disconnected during a brofist. Shouldn't happen very often I'll fix it in the next version, though. Thanks.
__________________
Plugins / My Steam / TF2 Sandbox (plugin beta testing!)
MasterOfTheXP is offline
Newbie1992
Senior Member
Join Date: Jan 2013
Location: Germany
Old 07-22-2013 , 03:50   Re: [TF2] BROFIST (1.1, Jun 6 2013)
Reply With Quote #23

Hi,

Thanks sir, hope this will go fast. Your plugin spam a lot in my logs :>

Newbie1992
__________________
Newbie1992 is offline
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 10-13-2013 , 17:23   Re: [TF2] BROFIST (1.1, Jun 6 2013)
Reply With Quote #24

Quote:
Originally Posted by MasterOfTheXP View Post
Looks like it's trying to get the eye position of a client who most likely disconnected during a brofist. Shouldn't happen very often I'll fix it in the next version, though. Thanks.
Change line L114 from
Code:
if (!partner) return;
to
Code:
if (partner <= 0) return;
. I'm rather sure the problem originate from the engine using "-1" as values for some EntProp IIRC.

Change the above and I'll approve.

On a side note, nice use of UserId with timers.

And when comparing vectors distance (GetVectorDistance), you should compare to the squared distance (square both side; note that 3rd argument of GetVectorDistance) rather than the distance itself (which requires a square root; which is an expensive function, done for every clients... ).

And using FCVAR_REPLICATED can produces errors in the client console AFAIK.

Red
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work
RedSword is offline
Avaray
Member
Join Date: Dec 2011
Location: Germany
Old 01-17-2014 , 08:57   Re: [TF2] BROFIST (1.1, Jun 6 2013)
Reply With Quote #25

I want to change this plugin to be available only for admins.
Where should I put this?
Code:
if(GetAdminFlag(GetUserAdmin(client), Admin_Reservation))
__________________
Avaray is offline
dunman888
Member
Join Date: Aug 2013
Location: Kentucky-USA
Old 03-30-2014 , 19:37   Re: [TF2] BROFIST (1.1, Jun 6 2013)
Reply With Quote #26

everything else works except the sound
Plse help
dunman888 is offline
Send a message via Skype™ to dunman888
MasterOfTheXP
Veteran Member
Join Date: Aug 2011
Location: Cloudbank
Old 06-14-2014 , 14:17   Re: [TF2] BROFIST (1.2, June 14 2014)
Reply With Quote #27

Ohnose, TF2 update, removed high five events, looks like this is the end of brofist you guys--oh wait, OnConditionAdded/Removed can easily be used in place of those events. And so...

1.2
  • Updated the plugin to work for the June 11 2014 TF2 update
  • A little code re-organization. Sort of.
  • Replaced enabled cvar and a few others with sm_brofist, a bitwise selection of effects. See the plugin OP.
Attached Files
File Type: sp Get Plugin or Get Source (brofist.sp - 277 views - 11.2 KB)
__________________
Plugins / My Steam / TF2 Sandbox (plugin beta testing!)

Last edited by MasterOfTheXP; 06-14-2014 at 15:07.
MasterOfTheXP is offline
MasterOfTheXP
Veteran Member
Join Date: Aug 2011
Location: Cloudbank
Old 06-20-2014 , 17:34   Re: [TF2] BROFIST (1.2.1, June 20 2014)
Reply With Quote #28

Oh, whoops, updated the plugin OP, but forgot to post.

1.2.1, fixes every partner taunt now being a BROFIST. Oops.
Attached Files
File Type: sp Get Plugin or Get Source (brofist.sp - 246 views - 12.0 KB)
__________________
Plugins / My Steam / TF2 Sandbox (plugin beta testing!)

Last edited by MasterOfTheXP; 06-20-2014 at 17:35.
MasterOfTheXP is offline
YoNer
Member
Join Date: Jul 2014
Old 10-16-2014 , 02:40   Re: [TF2] BROFIST (1.2.1, June 20 2014)
Reply With Quote #29

Crashing clients close to the brofist after today's update. I also noticed that plugins involving sound playback stopped playing sounds (trainrain, quake sounds, dispenser music, etc)
YoNer is offline
MasterOfTheXP
Veteran Member
Join Date: Aug 2011
Location: Cloudbank
Old 10-16-2014 , 02:53   Re: [TF2] BROFIST (1.2.1, June 20 2014)
Reply With Quote #30

Quote:
Originally Posted by YoNer View Post
Crashing clients close to the brofist after today's update. I also noticed that plugins involving sound playback stopped playing sounds (trainrain, quake sounds, dispenser music, etc)
Sounds like sv_pure...I've been hearing about a lot of weird things happening with it today.

I don't know any more than that, sorry. My server seems to be unaffected.

Wait...have you got the "particle" (read: sprite) enabled, or no? 16 added into the value of cvar "sm_brofist"?
...I enabled it by default even knowing about potential crashes. gg.
__________________
Plugins / My Steam / TF2 Sandbox (plugin beta testing!)

Last edited by MasterOfTheXP; 10-16-2014 at 02:56.
MasterOfTheXP is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 07:53.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode