[GordonFreeman (RU)]

Thanks. Compiling module from source solved this problem.

[souvikdas95]

@everyone - I really apologise for depreciated release of the module v 1.4.1 . Please consider using v1.2 or original CSX module ( incl in amxmodx package ) for now. In 2-3 hours, I will be done testing the fixed module update for this.
Thank you

[9iky6]

Can upload files 1 archive?

[souvikdas95]

New Update :

1.5 :

• Improved: Accuracy for Score Detection. (Major Update)
• Fixed: Previous Release
• Added: Support for Windows XP

[Shooting King]

Originally Posted by souvikdas95 Improved: Accuracy for Score Detection. (Major Update)

Details ??

Originally Posted by souvikdas95 Added: Support for Windows XP

O.O

[souvikdas95]

The last kill before round end will be counted, suicide detection improved, put clearstats in Round_Start... execute uniform rank update on Round_End... Removed ResetHUD...

Earliar did not include _xp in dll compilation...

[Shooting King]

1. You dont need to create a new object here. (was fixed in v1.2)

Spoiler

PHP Code:

static cell AMX_NATIVE_CALL get_user_rank(AMX *amx, cell *params) /* 1 param */
{
    int index = params[1];
    CHECK_PLAYER(index);
    CPlayer* pPlayer = GET_PLAYER_POINTER_I(index);
    if ( pPlayer->rank )
        return pPlayer->rank->getPosition();
    return 0;
} 


to

Spoiler

PHP Code:

static cell AMX_NATIVE_CALL get_user_rank(AMX *amx, cell *params) /* 1 param */
{
    int index = params[1];
    CHECK_PLAYER(index);
    if ( GET_PLAYER_POINTER_I(index)->rank ) 
                 return GET_PLAYER_POINTER_I(index)->rank->getPosition();
    return 0;
} 


also in set_user_score()

Spoiler

PHP Code:

static cell AMX_NATIVE_CALL set_user_score(AMX *amx, cell *params)  /*3 param */
{
    int index = params[1];
    CHECK_PLAYER(index);
    GET_PLAYER_POINTER_I(index)->setScore(params[2],params[3]);
    GET_PLAYER_POINTER_I(index)->restartStats();
    return 1;
} 


2. In push_stats(), you are creating a new memory, so you have to set all the stats.

Spoiler

PHP Code:

static cell AMX_NATIVE_CALL push_stats(AMX *amx, cell *params) /* 5 param */
{
    int iLen;
    char* Unique = MF_GetAmxString(amx, params[1], 0, &iLen);
    char* Name = MF_GetAmxString(amx, params[2], 0, &iLen);
    RankSystem::RankStats* temp = g_rank.findEntryInRank( Unique, Name, (params[5]>0)?true:false );
    if ( temp )
    {
        MF_LogError(amx, AMX_ERR_NATIVE, "Stats already exists");
        return 0;
    }
    temp = g_rank.newEntryInRank( Unique, Name );
    if ( !temp )
        return 0;
    cell* cpStats = MF_GetAmxAddr(amx,params[3]);
    cell* cpBodyHits = MF_GetAmxAddr(amx,params[4]);
    temp->kills = cpStats[0];
    temp->deaths = cpStats[1];
    temp->hs = cpStats[2];
    temp->tks = cpStats[3];
    temp->shots = cpStats[4];
    temp->hits = cpStats[5];
    temp->damage = cpStats[6];
    for(int i = 1; i < 8; ++i)    
                temp->bodyHits[i] = cpBodyHits[i];
    temp->updatePosition(&null);
    return temp->getPosition();
} 


3. You are missing the player with '32' Index. Lines 627 and 642. ( was fixed in v1.2 )

PHP Code:

for (int i=1;i<=gpGlobals->maxClients;i++)
{
       //....
} 


4. You can merge csstats.inc and csstats_ext.inc for better organization.
5. No backward compatibility here. You have to keep it get_stats_size() only

PHP Code:

stock xmod_get_stats_size()
{
    return 8;
} 


6. force_save_stats() (in v1.2) offers more functionality by saving the csstats.dat file with a new name and in any other directory. It seems you have not included it.

PHP Code:

/* 
*  Saves all the stats till previous round in the file 
*  Returns 1 
* 
*  default stats file path : amxmodx/data/csstats.dat 
*  v1.2 - Now can Save the Stats file in any directory under cstrike.  
*/ 
native force_save_stats( const path[]="" ); 


[souvikdas95]

1. I will still not support force_save_Stats for files other than csstats. This is not a hub. One can create various plugins. Module is meant for a specific purpose only. Open configs/core.ini and edit oneself the name of file. Or Windows have such great features like [CTRL + C] and [CTRL + V] or Linux with "cp". One can become the god in file management in any OS. Why port such ability to gaming module for any reason indeed? The only purpose for it is to save stats before map restart inside the file.

2. As for get_stats_size, check again. it's xmod_get_stats_size. You must look at the way it's registered in AMX_NATIVE info. The function name is different from it's native name

3. The code maybe a little simple but I am more concerned at maintaining a uniformity in the program. In any case, creating a new object is not causing any harm.

Rather read this :

https://wiki.alliedmods.net/Optimizi...d_X_Scripting)

Section : Don't Re-index Arrays

Although it's for plugin coding, the logic still remains the same

ReCheck the definition of GET_PLAYER_POINTER_I

4. True about maxclients thing. It's now corrected. Thanks for the info.

5. For the setting up of stats in push_stats(), you actually don't need to set all stats. I don't know what exactly you were referring to but the following may find your perusal.

• stats2 is not included. It can be achieved using set_user_stats2 or set_stats2. However, if more people think it should be included in it, then we would add it. Need more reviews on that.
• I hope you don't mean why not all stats are defined inside push_stats(), just because we're creating a new entry? It's been like that since always and Creating a new Entry automatically clears the stats to 0. The constructor to Stats::Stats() does it. See CPlayer::PutinServer() from old revisions of CSX.

6. Regarding merging, does it matter now? It's always better to keep one's revisions aside unless officially released.

[Shooting King]

Originally Posted by souvikdas95 1. I will still not support force_save_Stats for files other than csstats. This is not a hub. One can create various plugins. Module is meant for a specific purpose only. Open configs/core.ini and edit oneself the name of file. Or Windows have such great features like [CTRL + C] and [CTRL + V] or Linux with "cp". One can become the god in file management in any OS. Why port such ability to gaming module for any reason indeed? The only purpose for it is to save stats before map restart inside the file.

Taking backup of things doesn't do any bad. With that function one can easily backup the Whole stats before reset(or when one needs to save stats). You want people to Copy-Paste things whenever they need to save all the stats ? And one more thing, this is not *your* module. We all are contributing to AmxModx to make it better. You don't need to support this.

Originally Posted by souvikdas95 2. As for get_stats_size, check again. it's xmod_get_stats_size. You must look at the way it's registered in AMX_NATIVE info. The function name is different from it's native name

Originally Posted by souvikdas95 3. The code maybe a little simple but I am more concerned at maintaining a uniformity in the program. In any case, creating a new object is not causing any harm. https://wiki.alliedmods.net/Optimizi...d_X_Scripting)

You must read it again. Don't re-index array's too many times. That doesn't mean that you can declare a temp variable which is being used just once or twice.

This is Gud

PHP Code:

CPlayer* pPlayer = GET_PLAYER_POINTER_I(index);
if (pPlayer->rank)
{
    cell *cpStats = MF_GetAmxAddr(amx,params[2]);
    cell *cpBodyHits = MF_GetAmxAddr(amx,params[3]);
    cpStats[0] = pPlayer->life.kills;
    cpStats[1] = pPlayer->life.deaths;
    cpStats[2] = pPlayer->life.hs;
    cpStats[3] = pPlayer->life.tks;
    cpStats[4] = pPlayer->life.shots;
    cpStats[5] = pPlayer->life.hits;
    cpStats[6] = pPlayer->life.damage;
    for(int i = 1; i < 8; ++i)
        cpBodyHits[i] = pPlayer->life.bodyHits[i];
    return 1;
} 


But This isn't

PHP Code:

CPlayer* pPlayer = GET_PLAYER_POINTER_I(index);
if (pPlayer->rank)
{
    return pPlayer->rank->getPosition();
} 


6. Regarding merging, does it matter now?

[souvikdas95]

yes make it better... not a hub -_-
As long as purpose is served, one should be happy. Plus don't you think, the entire concept of using csstats.dat becomes pointless with that silly additive. The sanity of the module is disturbed because of such lame additives.

You better look at your knowledge before pointing at me. check once again. xmod_get_stats_size is correct. The other one is invalid. I already told you why. You just keep ignoring me -_- Sigh!

AMX_NATIVE_INFO stats_Natives[] = {
:
	{ "xmod_get_stats_size", get_stats_size },
:
}

You must read it again. Don't re-index array's too many times. That doesn't mean that you can declare a temp variable which is being used just once or twice.

That's your assumption that it's used once or twice. AmxModX doesn't run on probablities. Exploit is a fashion nowadays. Almost anybody can make plugins these days. One can call any native as many times as one requires ( even unintentionally )