[Lycode]

Originally Posted by guipatinador Normally the order is, client_connect -> client_authorized -> client_putinserver But in some (rare) situations client_authorized is called after, client_connect -> client_putinserver -> client_authorized Note that there is no default order and client_connect is always the first. ============ Keep in mind that client_authorized sometimes is called to fast, right after plugin_init. This could be dangerous if you create the global mysql handle in plugin_init or plugin_cfg. PHP Code: g_SqlTuple = SQL_MakeDbTuple( szHost, szUser, szPass, szDB )  Thats why some coders use client_putinserver.

1- Does this mean if we use client_putinserver it wouldn't be necessary to use a task after client authorized like you do?

2- Where else can we create the global handle that would remove the risk of client_authorized being called too fast causing problems?

3- Is a task of 4.0 seconds in client_authorized really needed? or would something like 0.1 work just as good?

[guipatinador]

Originally Posted by Lycode 1- Does this mean if we use client_putinserver it wouldn't be necessary to use a task after client authorized like you do?

client_putinserver is always a risk to get the player authid. Use client_authorized for safety.

2- Where else can we create the global handle that would remove the risk of client_authorized being called too fast causing problems?

You can't. Use plugin_init or plugin_cfg.

3- Is a task of 4.0 seconds in client_authorized really needed? or would something like 0.1 work just as good?

It is required. I'm not sure the ammount of time. For example amxbans uses 2 seconds,

PHP Code:

public client_authorized(id) {
    //fix for the invalid tuple error at mapchange, only a fast fix now
    if(g_SqlX==Empty_Handle) {
        set_task(2.0,"client_authorized",id)
        return PLUGIN_HANDLED
    }
    // code...
} 


[Jhob94]

Originally Posted by guipatinador PHP Code: public client_authorized(id) {     //fix for the invalid tuple error at mapchange, only a fast fix now     if(g_SqlX==Empty_Handle) {         set_task(2.0,"client_authorized",id)         return PLUGIN_HANDLED     }     // code... }

Checking the empty handle is definitly better than create unnecessary tasks. Now the server is happy and the data will be secure

[guipatinador]

Its not "definitly better".

If the plugin cannot connect to database (example: database offline, wrong password, etc), client_authorized is called each 2 seconds because g_SqlX will be always Empty_Handle.

[Jhob94]

Originally Posted by guipatinador Its not "definitly better". If the plugin cannot connect to database (example: database offline, wrong password, etc), client_authorized is called each 2 seconds because g_SqlX will be always Empty_Handle.

That's because you are noob
Set task time for 5.0 to another function that isn't client_authorized. Didn't even noticed you looped the client authorized lol, thats so wrong

[guipatinador]

Originally Posted by Jhob94 Didn't even noticed you looped the client authorized lol, thats so wrong

Thats an example of amx bans, https://code.google.com/p/plukom-amx...spec=svn17#239

Obviously looping client_authorized isn't a good idea.

[Jhob94]

This should be ok:

PHP Code:

#define TASK_SQL 432531
#define MAX_PLAYERS 32

new g_Steam[MAX_PLAYERS + 1][35]

public client_authorized(Id)
{
    get_user_authid(Id, g_Steam[Id], charsmax(g_Steam)) // Lets get SteamID just once. Safe for client_disconnect saving
    
    if(g_SqlX == Empty_Handle)
        set_task(5.0,"LoadShit",Id + TASK_SQL)
    
    else
        LoadShit(Id + TASK_SQL)
}

public LoadShit(Id)
{
    Id-= TASK_SQL
    
    // Code
} 


[guipatinador]

Its okay.

But I would do the following only to prevent offline databases,

Spoiler

PHP Code:

public LoadShit(Id)
{
    if(g_SqlX == Empty_Handle)
    {
        // something is wrong with the connection (maybe offline / wrong ip / user / password)
        return
    }

    Id-= TASK_SQL
    
    // Code
} 


=========================

PHP Code:

charsmax(g_Steam)) 


If g_Steam it's a bidimensional array it shoud be,

PHP Code:

charsmax(g_Steam[])) 


[Jhob94]

Originally Posted by guipatinador Its okay. But I would do the following only to prevent offline databases, Spoiler PHP Code: public LoadShit(Id) {     if(g_SqlX == Empty_Handle)     {         // something is wrong with the connection (maybe offline / wrong ip / user / password)         return     }     Id-= TASK_SQL          // Code }

Or just using a variable and put it positive in plugin_init after know if we got an Empty_Handle and work with the variable. Anyway, that's something i don't need right now. I am very new into sql so i have some doubts.

Should i regist like this:
SQL_ThreadQuery(g_Ranking, "EmptyFunction", "CREATE TABLE IF NOT EXISTS Rankings (Steam TEXT, Level NUMERIC, Kills NUMERIC, Deaths NUMERIC);")

Or should i create one table for each thing?

The reason why i am asking this is because i am currently using this to get data:

PHP Code:

formatex(Query, charsmax(Query), "SELECT Kills FROM Rankings WHERE Steam = '%s';", g_Steam[Id])
SQL_ThreadQuery(g_Ranking, "Query_Handler", Query, Data, charsmax(Data))


And in Query_Handler: SQL_ReadResult(pQuery, 0) 


With this could i get all the data and parse it or something? Or will i have to do 3 queries?

And last question. Should i update things everytime the values change or loop a task to save it from x in x time?

[guipatinador]

Originally Posted by Jhob94 Should i regist like this: SQL_ThreadQuery(g_Ranking, "EmptyFunction", "CREATE TABLE IF NOT EXISTS Rankings (Steam TEXT, Level NUMERIC, Kills NUMERIC, Deaths NUMERIC);") Or should i create one table for each thing?

Your "CREATE TABLE..." query is ok but personally I would change two things.

1 - Replace TEXT by VARCHAR.
"CREATE TABLE IF NOT EXISTS Rankings (Steam VARCHAR(35), Level INT, Kills INT, Deaths INT)"

2 - Use a non-threaded query for "CREATE TABLE...", since its called in plugin_init / plugin_cfg once and will not affect the gameplay (for the rest, use always threaded querys).

PHP Code:

new Handle:Queries = SQL_PrepareQuery(g_Ranking, "CREATE TABLE IF NOT EXISTS Rankings (Steam VARCHAR(35), Level INT, Kills INT, Deaths INT)")

if(!SQL_Execute( Queries ))
{
    // optionally you can turn off the plugin
    SQL_QueryError(Queries, g_Error, charsmax(g_Error))
    set_fail_state(g_Error)
}

SQL_FreeHandle(Queries) 


The reason why i am asking this is because i am currently using this to get data: PHP Code: formatex(Query, charsmax(Query), "SELECT Kills FROM Rankings WHERE Steam = '%s';", g_Steam[Id]) SQL_ThreadQuery(g_Ranking, "Query_Handler", Query, Data, charsmax(Data)) And in Query_Handler: SQL_ReadResult(pQuery, 0)  With this could i get all the data and parse it or something? Or will i have to do 3 queries?

Its simple with a single query. Just change "SELECT Kills" to "SELECT *" to select all the fields.
Optionally you can select the fields you want,

PHP Code:

formatex(Query, charsmax(Query), "SELECT Level, Kills Deaths FROM Rankings WHERE Steam = '%s';", g_Steam[Id])
SQL_ThreadQuery(g_Ranking, "Query_Handler", Query, Data, charsmax(Data)) 


And then in Query_Handler,

PHP Code:

iLevel = SQL_ReadResult(pQuery, 0) // first field
iKills = SQL_ReadResult(pQuery, 1) // second field
iDeaths = SQL_ReadResult(pQuery, 2) // third field 


And last question. Should i update things everytime the values change or loop a task to save it from x in x time?

Updating values every time they change may generate a lot of traffic between the server and the database. In most situations the most recommendable is saving at client_disconnect.

Unfortunately when the map change client_disconnect is called for everyone so it may cause a lot of traffic too.