[extream87]

Sometimes this plugin fails.
Example: The best player only kill 10 players and the colorchat says killed 11 or 12.

What is wrong? (The server have 32 slots)

#include <amxmodx>  
#include <amxmisc>  
#include <hamsandwich>  
#include <cstrike>
#include <colorchat>  
  
#define PLUGIN    "Best Player Round"  
#define AUTHOR    "extream87"  
#define VERSION   "1.0"  
  
new g_iKills[32], g_iDmg[32], zTAG
  
public plugin_init()
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    RegisterHam(Ham_TakeDamage, "player", "hamTakeDamage")
    register_event("DeathMsg", "EventDeathMsg", "a")  
    register_logevent("RoundEnd", 2, "1=Round_End")
    zTAG = register_cvar("bp_prefix", "Prefix*")
}  
  
public client_disconnect(id)  
{  
    g_iDmg[id] = 0;  
    g_iKills[id] = 0;  
} 
public hamTakeDamage(victim, inflictor, attacker, Float:damage, DamageBits)  
{  
    if( 1 <= attacker <= 32)  
    {  
        if(cs_get_user_team(victim) != cs_get_user_team(attacker))  
            g_iDmg[attacker] += floatround(damage)  
        else  
            g_iDmg[attacker] -= floatround(damage)  
    }  
}  
  
public EventDeathMsg()  
{  
    new killer = read_data(1)  
    new victim = read_data(2)  
  
    if(killer != victim && killer && cs_get_user_team(killer) != cs_get_user_team(victim))  
    {  
        g_iKills[killer]++;  
    }  
    else  
        g_iKills[killer]--;  
}  
  
public RoundEnd()  
{  
    new iBestPlayer = get_best_player()  
    new szName[32]  
    get_user_name(iBestPlayer, szName, charsmax(szName))  
    
    new szTAG[25];
    get_pcvar_string(zTAG, szTAG, charsmax(szTAG));
    
    if (g_iKills[iBestPlayer] <1 ){
    ColorChat(0, GREEN, "[%s] ^x01Esta ronda nao contou.", szTAG);
    }
    
    else if (g_iKills[iBestPlayer] ==1 ){
    ColorChat(0, GREEN, "[%s] ^x01Melhor jogador da ronda: ^x04%s ^x01matou ^x04%i ^x01jogador.", szTAG, szName, g_iKills[iBestPlayer]);
    }
    
    else if (g_iKills[iBestPlayer] >1 ){
    ColorChat(0, GREEN, "[%s] ^x01Melhor jogador da ronda: ^x04%s ^x01matou ^x04%i ^x01jogadores.", szTAG, szName, g_iKills[iBestPlayer]);
    }
    
  
    for(new i; i < 31; i++)  
    {  
        g_iDmg[i] = 0;  
        g_iKills[i] = 0;  
    }  
}  
  
get_best_player()  
{  
    new players[32], num;  
    get_players(players, num);  
    SortCustom1D(players, num, "sort_bestplayer")  
    return players[0]  
}  
  
public sort_bestplayer(id1, id2)  
{  
    if(g_iKills[id1] > g_iKills[id2])  
        return -1;  
    else if(g_iKills[id1] < g_iKills[id2])  
        return 1;  
    else  
    {  
        if(g_iDmg[id1] > g_iDmg[id2])  
            return -1;  
        else if(g_iDmg[id1] < g_iDmg[id2])  
            return 1;  
        else  
            return 0;  
    }  
    return 0;  
}

[Kia]

Change from [32] to [33].

[extream87]

That?

new g_iKills[33], g_iDmg[33]


if( 1 <= attacker <= 33)

[Neeeeeeeeeel.-]

Originally Posted by extream87 That? Code: new g_iKills[33], g_iDmg[33] if( 1 <= attacker <= 33)

This should stay as it was.

PHP Code:

if( 1 <= attacker <= 32) 


[ddhoward]

Remember that when declaring an array, you specify how many "slots" it has. When referencing these slots later, the first slot is '0'. Second one is '1'. Etc.

So when declaring a new array of size 33, the first position in the array is 1-1 (0), and the last is 33-1 (32).

[extream87]

So that is good?

#include <amxmodx>  
#include <amxmisc>  
#include <hamsandwich>  
#include <cstrike>
#include <colorchat>  
  
#define PLUGIN    "Best Player Round"  
#define AUTHOR    "extream87"  
#define VERSION   "1.1"  
  
new g_iKills[33], g_iDmg[33], zTAG
  
public plugin_init()
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    RegisterHam(Ham_TakeDamage, "player", "hamTakeDamage")
    register_event("DeathMsg", "EventDeathMsg", "a")  
    register_logevent("RoundEnd", 2, "1=Round_End")
    zTAG = register_cvar("bp_prefix", "Prefix*")
}  
  
public client_disconnect(id)  
{  
    g_iDmg[id] = 0;  
    g_iKills[id] = 0;  
} 
public hamTakeDamage(victim, inflictor, attacker, Float:damage, DamageBits)  
{  
    if( 1 <= attacker <= 32)  
    {  
        if(cs_get_user_team(victim) != cs_get_user_team(attacker))  
            g_iDmg[attacker] += floatround(damage)  
        else  
            g_iDmg[attacker] -= floatround(damage)  
    }  
}  
  
public EventDeathMsg()  
{  
    new killer = read_data(1)  
    new victim = read_data(2)  
  
    if(killer != victim && killer && cs_get_user_team(killer) != cs_get_user_team(victim))  
    {  
        g_iKills[killer]++;  
    }  
    else  
        g_iKills[killer]--;  
}  
  
public RoundEnd()  
{  
    new iBestPlayer = get_best_player()  
    new szName[33]  
    get_user_name(iBestPlayer, szName, charsmax(szName))  
    
    new szTAG[25];
    get_pcvar_string(zTAG, szTAG, charsmax(szTAG));
    
    if (g_iKills[iBestPlayer] <1 ){
    ColorChat(0, GREEN, "[%s] ^x01Esta ronda nao foi jogada.", szTAG);
    }
    
    else if (g_iKills[iBestPlayer] ==1 ){
    ColorChat(0, GREEN, "[%s] ^x01Melhor jogador da ronda: ^x04%s ^x01matou ^x04%i ^x01jogador.", szTAG, szName, g_iKills[iBestPlayer]);
    }
    
    else if (g_iKills[iBestPlayer] >1 ){
    ColorChat(0, GREEN, "[%s] ^x01Melhor jogador da ronda: ^x04%s ^x01matou ^x04%i ^x01jogadores.", szTAG, szName, g_iKills[iBestPlayer]);
    }
    
  
    for(new i; i < 31; i++)  
    {  
        g_iDmg[i] = 0;  
        g_iKills[i] = 0;  
    }  
}  
  
get_best_player()  
{  
    new players[32], num;
    get_players(players, num);
    SortCustom1D(players, num, "sort_bestplayer")
    return players[0]
}  
  
public sort_bestplayer(id1, id2)  
{  
    if(g_iKills[id1] > g_iKills[id2])  
        return -1;  
    else if(g_iKills[id1] < g_iKills[id2])  
        return 1;  
    else  
    {  
        if(g_iDmg[id1] > g_iDmg[id2])  
            return -1;  
        else if(g_iDmg[id1] < g_iDmg[id2])  
            return 1;  
        else  
            return 0;  
    }  
    return 0;  
}

[ConnorMcLeod]

Threads titles muts be descriptive.

Please read rules : https://forums.alliedmods.net/misc.php?do=showrules

Closed.