[psychonic]

Originally Posted by altex Very strange problem on both 1.3 and 2.0 SDKHooks versions. PHP Code: #pragma semicolon 1 #include <sourcemod> #include <sdktools> #undef AUTOLOAD_EXTENSIONS #undef REQUIRE_EXTENSIONS #include <sdkhooks> public Plugin:myinfo = {     name = "Test name",     author = "Test author",     description = "Test descr",     version = "Test version",     url = "Test url" }; new bool:g_SdkHooksEnabled = false; public APLRes:AskPluginLoad2(Handle:myself, bool:late, String:error[], err_max) {     MarkNativeAsOptional("SDKHook");     MarkNativeAsOptional("SDKUnhook");     return APLRes_Success; } public Action:Timer_CheckSdkHooks(Handle:timer) {     g_SdkHooksEnabled = GetExtensionFileStatus("sdkhooks.ext") == 1; } public OnPluginStart() {     g_SdkHooksEnabled = GetExtensionFileStatus("sdkhooks.ext") == 1;     if ( !g_SdkHooksEnabled ) {         InsertServerCommand("sm exts load sdkhooks");         CreateTimer(0.1, Timer_CheckSdkHooks);     } } public OnClientPutInServer(client) {     if ( g_SdkHooksEnabled ) {         SDKHook(client, SDKHook_WeaponSwitch, OnWeaponSwitch);     } } public OnClientDisconnect(client) {     if ( g_SdkHooksEnabled ) {         SDKUnhook(client, SDKHook_WeaponSwitch, OnWeaponSwitch);     } } public Action:OnWeaponSwitch(client, weapon) {     return Plugin_Continue; }

Ignoring the other things bad in this, you're missing parentheses in your check. = is taking precedence over ==.

[altex]

Originally Posted by psychonic Ignoring the other things bad in this, you're missing parentheses in your check. = is taking precedence over ==.

Assuming i have the following fixed chunk of code, what next should i do to make it work?

PHP Code:

#pragma semicolon 1

#include <sourcemod>
#include <sdktools>

#undef AUTOLOAD_EXTENSIONS
#undef REQUIRE_EXTENSIONS
#include <sdkhooks>

public Plugin:myinfo =
{
    name = "Test name",
    author = "Test author",
    description = "Test descr",
    version = "Test version",
    url = "Test url"
};

new bool:g_SdkHooksEnabled = false;

public APLRes:AskPluginLoad2(Handle:myself, bool:late, String:error[], err_max)
{
    LogMessage("AskPluginLoad2");
    MarkNativeAsOptional("SDKHook");
    MarkNativeAsOptional("SDKUnhook");
    return APLRes_Success;
}

public Action:Timer_CheckSdkHooks(Handle:timer) {
    LogMessage("Timer_CheckSdkHooks");
    g_SdkHooksEnabled = (GetFeatureStatus(FeatureType_Native, "SDKHookEx") == FeatureStatus_Available);
    LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled);
}

public OnPluginStart()
{
    LogMessage("OnPluginStart");
    g_SdkHooksEnabled = (GetFeatureStatus(FeatureType_Native, "SDKHookEx") == FeatureStatus_Available);
    LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled);
    if ( !g_SdkHooksEnabled ) {
        InsertServerCommand("sm exts load sdkhooks");
        CreateTimer(0.1, Timer_CheckSdkHooks);
    }
}

public OnClientPutInServer(client) {
    LogMessage("OnClientPutInServer");
    LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled);
    if ( g_SdkHooksEnabled ) {
        SDKHook(client, SDKHook_WeaponSwitch, OnWeaponSwitch);
    }
}

public OnClientDisconnect(client)
{
    LogMessage("OnClientDisconnect");
    LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled);
    if ( g_SdkHooksEnabled ) {
        SDKUnhook(client, SDKHook_WeaponSwitch, OnWeaponSwitch);
    }
}

public Action:OnWeaponSwitch(client, weapon) {
    return Plugin_Continue;
} 


L 04/13/2011 - 03:06:43: [test.smx] AskPluginLoad2 L 04/13/2011 - 03:06:43: [test.smx] OnPluginStart L 04/13/2011 - 03:06:43: [test.smx] ... g_SdkHooksEnabled is 0 L 04/13/2011 - 03:06:43: [test.smx] Timer_CheckSdkHooks L 04/13/2011 - 03:06:43: [test.smx] ... g_SdkHooksEnabled is 1 L 04/13/2011 - 03:06:49: [test.smx] OnClientPutInServer L 04/13/2011 - 03:06:49: [test.smx] ... g_SdkHooksEnabled is 1 L 04/13/2011 - 03:06:49: [SM] Plugin encountered error 21: Native is not bound L 04/13/2011 - 03:06:49: [SM] Native "SDKHook" reported: L 04/13/2011 - 03:06:49: [SM] Displaying call stack trace for plugin "test.smx": L 04/13/2011 - 03:06:49: [SM] [0] Line 50, test.sp::OnClientPutInServer()

[rhelgeby]

Is it possible to run multiple instances of SDK Hooks (like multiple versions of the same library in linux)? Or - is 2.0 backwards compatible?

When 2.0 is released, there will be a mix of plugins who use 1.3 and 2.0. I'd like to have a plugin work with both versions and only use the new features if they are available.

A possible solution might be to include the major version number in the library name, so we could do this in the plugin:

PHP Code:

if (LibraryExists("sdkhooks-2"))
{
    // Use new features
}
else if (LibraryExists("sdkhooks"))
{
    // Only use old features
} 


Then it will use the newest extension available. And if SDK Hooks 2.0 is installed it won't break older plugins because of the version number in the name.

Either way, if it's backwards compatible that's just great. Otherwise it could just be renamed to "sdkhooks-2" or something indicating it's the 2.0 branch. Though, I'm not sure how multiple versions affect the server's stability.

[DJ Tsunami]

I believe it was mentioned that you don't even have to recompile old plugins if you're not using any of the new functionality, so it's probably backwards compatible.

[psychonic]

Originally Posted by rhelgeby Is it possible to run multiple instances of SDK Hooks (like multiple versions of the same library in linux)? Or - is 2.0 backwards compatible? When 2.0 is released, there will be a mix of plugins who use 1.3 and 2.0. I'd like to have a plugin work with both versions and only use the new features if they are available. A possible solution might be to include the major version number in the library name, so we could do this in the plugin: PHP Code: if (LibraryExists("sdkhooks-2")) {     // Use new features } else if (LibraryExists("sdkhooks")) {     // Only use old features }  Then it will use the newest extension available. And if SDK Hooks 2.0 is installed it won't break older plugins because of the version number in the name. Either way, if it's backwards compatible that's just great. Otherwise it could just be renamed to "sdkhooks-2" or something indicating it's the 2.0 branch. Though, I'm not sure how multiple versions affect the server's stability.

The library "sdkhooks" is only registered on version 2 and later. Version 1.x doesn't have it.

[altex]

Originally Posted by altex Assuming i have the following fixed chunk of code, what next should i do to make it work? PHP Code: #pragma semicolon 1 #include <sourcemod> #include <sdktools> #undef AUTOLOAD_EXTENSIONS #undef REQUIRE_EXTENSIONS #include <sdkhooks> public Plugin:myinfo = {     name = "Test name",     author = "Test author",     description = "Test descr",     version = "Test version",     url = "Test url" }; new bool:g_SdkHooksEnabled = false; public APLRes:AskPluginLoad2(Handle:myself, bool:late, String:error[], err_max) {     LogMessage("AskPluginLoad2");     MarkNativeAsOptional("SDKHook");     MarkNativeAsOptional("SDKUnhook");     return APLRes_Success; } public Action:Timer_CheckSdkHooks(Handle:timer) {     LogMessage("Timer_CheckSdkHooks");     g_SdkHooksEnabled = (GetFeatureStatus(FeatureType_Native, "SDKHookEx") == FeatureStatus_Available);     LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled); } public OnPluginStart() {     LogMessage("OnPluginStart");     g_SdkHooksEnabled = (GetFeatureStatus(FeatureType_Native, "SDKHookEx") == FeatureStatus_Available);     LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled);     if ( !g_SdkHooksEnabled ) {         InsertServerCommand("sm exts load sdkhooks");         CreateTimer(0.1, Timer_CheckSdkHooks);     } } public OnClientPutInServer(client) {     LogMessage("OnClientPutInServer");     LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled);     if ( g_SdkHooksEnabled ) {         SDKHook(client, SDKHook_WeaponSwitch, OnWeaponSwitch);     } } public OnClientDisconnect(client) {     LogMessage("OnClientDisconnect");     LogMessage("... g_SdkHooksEnabled is %i", g_SdkHooksEnabled);     if ( g_SdkHooksEnabled ) {         SDKUnhook(client, SDKHook_WeaponSwitch, OnWeaponSwitch);     } } public Action:OnWeaponSwitch(client, weapon) {     return Plugin_Continue; }

I'm sorry, just tell me if somebody interested or not in resolving this issue.
The best answer will be example of using sdkhooks as optional plugin.
This is my third post about the same issue and i still don't understand if it will be resolved or not.

[psychonic]

Originally Posted by altex I'm sorry, just tell me if somebody interested or not in resolving this issue. The best answer will be example of using sdkhooks as optional plugin. This is my third post about the same issue and i still don't understand if it will be resolved or not.

Soon 2.0 will be released, and the only supported check will be against the library, which will work fine with OnLibraryAdded/OnLibraryRemoved/LibraryExists. Version 1.3 will be considered no longer officially supported so I would just encourage people to upgrade. I will try to post the last beta today. It fixes some inconsistencies that have exists with 1.3 in the ShouldCollide hook and add a blockable hook on Use.

There has been no bugs reported since the last beta so either no one cares to try it or it works greats. Either way, a release is imminent.

[Thrawn2]

Originally Posted by psychonic or it works greats

at least for me and my use cases.
thx!

[altex]

Originally Posted by psychonic Soon 2.0 will be released, and the only supported check will be against the library, which will work fine with OnLibraryAdded/OnLibraryRemoved/LibraryExists. Version 1.3 will be considered no longer officially supported so I would just encourage people to upgrade. I will try to post the last beta today. It fixes some inconsistencies that have exists with 1.3 in the ShouldCollide hook and add a blockable hook on Use. There has been no bugs reported since the last beta so either no one cares to try it or it works greats. Either way, a release is imminent.

omg

I use SdkHooks 2.0.

The issue is not in detecting library (OnLibraryAdded/OnLibraryRemoved/LibraryExists).

After library is loaded with "sm exts load" it does not work.

So there is no way to use sdkhooks as optional.
So defines AUTOLOAD_EXTENSION and REQUIRE_EXTENSION actualy dont needed if library can not be used as optional.

Trying to use sdkhooks as optional library leads to the following error

L 04/13/2011 - 03:06:49: [SM] Plugin encountered error 21: Native is not bound L 04/13/2011 - 03:06:49: [SM] Native "SDKHook" reported: L 04/13/2011 - 03:06:49: [SM] Displaying call stack trace for plugin "test.smx": L 04/13/2011 - 03:06:49: [SM] [0] Line 50, test.sp::OnClientPutInServer()

[psychonic]

Originally Posted by altex After library is loaded with "sm exts load" it does not work.

If the library callbacks or native are not working properly, please file a bug with a short test case attached so that it can be looked into further.