[QOOOOOOOOQ]

Alright thanks, will try it soon.

[xf117]

Originally Posted by Impact123 The prototype he has is perfectly fine, see here.

Ha, i never looked at that
Interesting.

[Marcus_Brown001]

Originally Posted by GsiX if he miss the curly bracket, the compiler give wrong error line.

I understand that. He said the file is large, and unless the timer function is the very last thing in the file, other things would more than likely come up as undefined if he missed a closing bracket somewhere. Or at least when I miss one I get more than one function being seen as undefined.

[V1SoR]

Are you actually creating the timer outside of any function? Technically it may be nothing bad for SourcePawn, but it's against all SM standards and conventions. Also, I have no clue when would the entirety of that code be executed. Couple it with the TIMER_DATA_HNDL_CLOSE flag(which you most likely don't need) and you might get an idea of what you're doing wrong.

[Visual77]

hChooseTeamMenuTimer = CreateTimer(0.5, Timer_ChooseTeamMenu);

public Action:Timer_ChooseTeamMenu(Handle:hTimer)
{
    hChooseTeamMenuTimer = INVALID_HANDLE;

    for (new vWho = 1; vWho <= MaxClients; vWho++)
    {
        if(IsClientInGame(vWho) && GetClientTeam(vWho) == TEAM_SPECTATORS)
        {
            bTempBlockTeams[vWho] = false;
            FakeClientCommand(vWho, "chooseteam");
        }
    }
}

[GsiX]

Originally Posted by Marcus_Brown001 I understand that. He said the file is large, and unless the timer function is the very last thing in the file, other things would more than likely come up as undefined if he missed a closing bracket somewhere. Or at least when I miss one I get more than one function being seen as undefined.

Originally Posted by QOOOOOOOOQ I see, I'll just fix other errors

[QOOOOOOOOQ]

Originally Posted by V1SoR Are you actually creating the timer outside of any function? Technically it may be nothing bad for SourcePawn, but it's against all SM standards and conventions. Also, I have no clue when would the entirety of that code be executed. Couple it with the TIMER_DATA_HNDL_CLOSE flag(which you most likely don't need) and you might get an idea of what you're doing wrong.

No. It's inside OnClientDisconnect, of which all the other appropriate lines in the function have correct syntax afaik, no errors and looks alright. PS: Brackets and parenthesis in the method are all seemingly correct too, in case you were wondering.

Originally Posted by Visual77 hChooseTeamMenuTimer = CreateTimer(0.5, Timer_ChooseTeamMenu); public Action:Timer_ChooseTeamMenu(Handle:hTimer) { hChooseTeamMenuTimer = INVALID_HANDLE; for (new vWho = 1; vWho <= MaxClients; vWho++) { if(IsClientInGame(vWho) && GetClientTeam(vWho) == TEAM_SPECTATORS) { bTempBlockTeams[vWho] = false; FakeClientCommand(vWho, "chooseteam"); } } }

Why not just use TIMER_DATA_HNDL_CLOSE instead of that way? Seems like it's more reasonable to use the other way, as it's designed it specifically for that reason, no? Also I've always wondered why add an extra check for IsClientInGame if them being a valid client on the server is already true? Also... what's the point of MaxClients instead of MAXPLAYERS... they'd both end up with the same end-result no?

[Marcus_Brown001]

It is common practice to verify that the client is in-game inside of a timer for the fact that from the time you start the timer to the time that the timer function is called, there is the potential for the client to leave the server. If you then try to do actions on the client that has left the server, you will more than likely get errors with invalid client index. Even if the timer is for a very small time interval, you should always check if the client is in-game first.

[Visual77]

Originally Posted by QOOOOOOOOQ Why not just use TIMER_DATA_HNDL_CLOSE instead of that way? Seems like it's more reasonable to use the other way, as it's designed it specifically for that reason, no? Also I've always wondered why add an extra check for IsClientInGame if them being a valid client on the server is already true? Also... what's the point of MaxClients instead of MAXPLAYERS... they'd both end up with the same end-result no?

Shouldn't TIMER_DATA_HNDL_CLOSE only be used when a datapack is passed to the timer and CreateDataTimer isn't being used? It's to avoid adding CloseHandle to the datapack timer function from my understanding.
MAXPLAYERS is bad form for loops, it's a fixed value of 64 or 65. MaxClients is all the players on the server - could be 8 players if your server has 8 players.

You need IsClientInGame because native GetClientTeam(client) can error out if the client is not in game? What Marcus_Brown001 said btw too. If you wouldn't have GetClientTeam in your loop, you most likely wouldn't need
IsClientInGame. For example, just resetting a boolean on all clients back to false wouldn't be needing IsClientInGame.

http://docs.sourcemod.net/api/index....d=show&id=411&

[friagram]

Createdatatimer automatically closes the handle when it expires, the flag is not necessary for datatimers.
You only need to close it if you manually create a data pack and pass that, be it a timer, or anywhere.