timer question

Totenfluch · **Author**

Hey guys,

I've got a Problem,

on player spawn I got this code

g_ticker[client] = CreateTimer(20.0, ticker, client);

then

public Action:ticker(Handle:timer, any:client)
{
// do smth
}

how can I kill this timer on round end ?
cause if the round ends before the 20s expire my whole plugin messes up.
any help ?

Allready tried this on roundend:

for (new i = 1; i <= GetMaxClients(); i++){
CloseHandle(g_ticker[i]);
}

does not work

Eden.Campo · 07-29-2013 , 15:12 Re: timer question

Code:

for ( new i = 1; i <= MaxClients; i++ )
{
       if(!IsClientConnected(i) || IsFakeClient(i) || !IsClientInGame(i))
       continue;

      KillTimer(g_ticker[i]);
}

Totenfluch · 07-29-2013 , 15:27 Re: timer question

thanks !

one question: Does the round_end event fire if you use "mp_restartgame 1" ?

Eden.Campo · 07-30-2013 , 02:13 Re: timer question

Quote:

Originally Posted by Totenfluch

thanks !

one question: Does the round_end event fire if you use "mp_restartgame 1" ?

I ain't sure.
Anyways, if it doesn't, use AddCommandListener(callback, "mp_restartgame").

ddhoward · 07-31-2013 , 01:58 Re: timer question

Code:

if(!IsClientConnected(i) || IsFakeClient(i) || !IsClientInGame(i))

Checking IsClientConnected is not necessary, as IsClientInGame already does that check.

Might want to do this instead:

Code:

if(IsFakeClient(i) || !IsClientInGame(i))

11530 · 07-31-2013 , 06:20 Re: timer question

Quote:

Originally Posted by ddhoward

Code:

if(!IsClientConnected(i) || IsFakeClient(i) || !IsClientInGame(i))

Checking IsClientConnected is not necessary, as IsClientInGame already does that check.

Might want to do this instead:

Code:

if(IsFakeClient(i) || !IsClientInGame(i))

Other way around. Do the in-game check first.

ddhoward · 07-31-2013 , 12:15 Re: timer question

DURRRRR thanks lol

Now that I think about it, would it matter that they are both on the same line?

For example,

Code:

if (!IsClientInGame(i) || IsFakeClient(i)) {

Let's say that 'i' is well over "MaxClients." Would running this check cause IsFakeClient to throw an error? I would think to separate them like this:

Code:

if (!IsClientInGame(i)) {
	return;
}
if (IsFakeClient(i)) {
	return;
}

thetwistedpanda · 07-31-2013 , 12:24 Re: timer question

There shouldn't really be a case where i is > MaxClients, you're supposed to account for that. And you don't have to have the calls on the same line, as it'll still be processed in its defined order.

ddhoward · 07-31-2013 , 12:39 Re: timer question

I don't know why I indicated that i > MaxClients... Long night lol.

In any case, I wasn't sure if SM would stop running parts of the conditional if it was already guaranteed to be true. Tested it out myself, and I know know that it somehow does stop?

Code:

public OnPluginStart() {
	for (new i = 1; i <= MaxClients; i++)
		if (IsFakeClient(i))
			PrintToChatAll("test %i", i)
}

In this example, IsFakeClient is run on even non-connected players, and throws an error.

Code:

public OnPluginStart() {
	for (new i = 1; i <= MaxClients; i++)
		if (!IsClientInGame(i) || IsFakeClient(i))
			PrintToChatAll("test %i", i)
}

Here, however, if IsClientInGame returns false (making that half of the conditional = true), then IsFakeClient isn't even touched. Fascinating.

Powerlord · 07-31-2013 , 12:45 Re: timer question

Quote:

Originally Posted by ddhoward

Code:

public OnPluginStart() {
    for (new i = 1; i <= MaxClients; i++)
        if (!IsClientInGame(i) || IsFakeClient(i))
            PrintToChatAll("test %i", i)
}

Here, however, if IsClientInGame returns false (making that half of the conditional = true), then IsFakeClient isn't even touched. Fascinating.

|| and && use Short-circuit Evaluation. Basically, that means if the part before || is true, or the part before && is false, the other side won't be evaluated at all.