[made.tn]

PHP Code:

#include <amxmodx> 
#include <fun> 

public plugin_init() 
{ 
    register_concmd("hp_menu", "menu") 
} 

public menu(id) 
{ 
    new menu = menu_create("Menu Name", "menu_handler") 
     
    menu_additem(menu, "Give 100 hp ", "1") 
    menu_additem(menu, "Give 500 hp ", "2") 
    menu_additem(menu, "Give 1000 hp ", "3") 
     
    menu_display(id, menu, 0) 
} 

public menu_handler(id, menu, item) 
{ 
    new maxdata[64], maxnames[64], access, callback 
     
    menu_item_getinfo(menu, item, access, maxdata, sizeof maxdata - 1, maxnames, sizeof maxnames - 1, callback) 
     
    new key = str_to_num(maxdata) 
    new health = get_user_health(id) 
     
    switch (key) 
    { 
        case 1: 
        { 
            set_user_health(id, health + 100) 
        }case 2: 
        { 
            set_user_health(id, health + 500) 
        }case 3: 
        { 
            set_user_health(id, health + 1000) 
        } 
    } 
    menu_destroy(menu) 
    return PLUGIN_HANDLED 
} 


[ConnorMcLeod]

Redundant, limited (self health), useless, no description : Unapproved.

I think it's your first plugin, usually coders don't release their 1st plugin, they keep become better untill they make an original plugin and then they release it ;)

About the code, you could use item directly in the switch, from 0 to 2 instead of key from 1 to 3, then you wouldn't need to add extra info in menu_additem, and you wouldn't need to retrieve item info in the handler.

Also, the menu is not dynamic, so you could build it in plugin_init and then open the same one instead of create it each time and destroy it each time.