[pcmaster]

Hello,

I am currently trying to detour CLog:rint to hide some messages (namely player joined/disconnected).
It is part of my Admin Stealth plugin and is used to hide joining players from gameme (so the message won't be printed out).

For this, I have detoured CLog:rint(char const*) like this:

PHP Code:


DETOUR_DECL_STATIC1(CLog_Print, void, const char *, message)
{
    g_pSM->LogMessage(myself, "CLog::Print called: %s", message);
    DETOUR_STATIC_CALL(CLog_Print)(message);
    return;
}

bool LH::SDK_OnLoad(char *error, size_t maxlength, bool late)
{
    char conf_error[255] = "";

    if (!gameconfs->LoadGameConfigFile("lh.games", &g_pGameConf, conf_error, sizeof(conf_error)))
    {
        if (conf_error[0])
        {
                snprintf(error, maxlength, "Could not read lh.games.txt: %s", conf_error);
        }
        return false;
    }

    // Prepare and setup detour
    CDetourManager::Init(g_pSM->GetScriptingEngine(), g_pGameConf);

    g_pPrintDetour = DETOUR_CREATE_STATIC(CLog_Print, "CLog::Print");

    if(g_pPrintDetour != NULL)
    {
        // Now that the detour is working, enable the Forward too
        g_pPrintDetour->EnableDetour();
        return true;
    }

    snprintf(error, maxlength, "CLog::Print detour failed.");
    return false;
} 


(forward stuff omitted).

Gamedata:

PHP Code:

"Games"
{
        "tf"
        {
                "Signatures"
                {
                        "CLog::Print"
                        {
                                "library"       "engine"
                                "windows"       ""
                                "linux"         "@_ZN4CLog5PrintEPKc"
                                "mac"           "@_ZN4CLog5PrintEPKc"
                        }
                }
        }
} 


The compilation works and the extension just runs fine, but the supplied message (which should be a const char*) is just plain gibberish:

L 07/08/2015 - 20:094: [LH] CLog:rint called: Ё#********* L 07/08/2015 - 20:094: [LH] CLog:rint called: Ё#********* L 07/08/2015 - 20:094: [LH] CLog:rint called: Ё#********* L 07/08/2015 - 20:094: [LH] CLog:rint called: Ё#********* L 07/08/2015 - 20:094: [LH] CLog:rint called: Ё#********* L 07/08/2015 - 20:09:52: [LH] CLog:rint called: Ё#*********

Anyone knows what I am doing wrong?
Help would be appreciated!

[asherkin]

Or, for a much easier time, block the player_connect and player_disconnect events.

[pcmaster]

Originally Posted by asherkin Or, for a much easier time, block the player_connect and player_disconnect events.

I am already doing this, but somehow, it's still being logged (and sent to gameMe's servers).

[asherkin]

Originally Posted by pcmaster I am already doing this, but somehow, it's still being logged (and sent to gameMe's servers).

You need to actually block it, not just disable broadcast.

[pcmaster]

Originally Posted by asherkin You need to actually block it, not just disable broadcast.

Won't that interfere with other plugins and/or actual game functions?

[psychonic]

Originally Posted by pcmaster Won't that interfere with other plugins and/or actual game functions?

I believe that the only serverside game functions that use those are for logging. Returning Plugin_Handled will block from the game and still allow plugins to get it. Plugin_Stop would block from all.

[pcmaster]

Well, blocking the event entirely with Plugin_Handled/Plugin_Stop didn't change anything, gameMe is still seeing the connect..

[Powerlord]

I was under the impression that certain games use a new connect event, player_connect_client.

CS:GO and TF2 specifically.

[psychonic]

Originally Posted by Powerlord I was under the impression that certain games use a new connect event, player_connect_client. CS:GO and TF2 specifically.

CS:GO only has player_connect and no longer sets the IP address in it. TF2 added a second event, player_connect_client that does not have the IP address set and gets broadcast to clients. TF2 still has player_connect, and it still triggers the serverside logging.

A better approach for both of them would have just been to mark the IP field as type "local", so that the event would stay as-is, with the exception of that field not being broadcasted with it to clients.

[pcmaster]

I am currently hooking player_connect_client, so is player_connect doing the logging?