[Luke Penny]

I'm doing a lot of convar changes frequently - wondering what would be the most efficient way to do this. Over the course of months I've used three different methods but I'm not sure which would be best. I'm changing some 200 cvars around every 5-15 minutes.

PHP Code:

new Handle:cvar;
cvar = FindConVar("variable1");
SetConVarInt(cvar, 1);
cvar = FindConVar("variable2");
SetConVarInt(cvar, 2);

new Handle:var1;
new Handle:var2;
var1 = FindConVar("variable1")
SetConVarInt(var1, 1);
var2 = FindConVar("variable2")
SetConVarInt(var2, 2);

//or simply...

SetConVarInt(FindConVar("variable"), 1);
SetConVarInt(FindConVar("variable2"), 2); 


I'm pretty sure the first one is a stupid way to go about it. However comparing the last two, considering that I'm changing them frequently I think I could avoid finding the handle again if each one had it's own handle?

Any suggestions as to which is the most efficient?

[Silvers]

I read somewhere that you should put FindConVar in OnPluginStart() as it's a resourceful function and bad to call over and over for the same thing. Store the returned handles as global handle variables and set your convars using those.

[berni]

That's correct, FindConVar is very expensive and should therefore be called only once (OnPluginStart). The GetConVar* Functions are cheap and can be used just like that.

[Bacardi]

Ok, I'm also interested about this topic.
I have start made this way when check server cvars and when it change.

PHP Code:

new Handle:mp_startmoney = INVALID_HANDLE;
new startmoney;

public OnPluginStart()
{
    mp_startmoney = FindConVar("mp_startmoney");
    startmoney = GetConVarInt(mp_startmoney);
    HookConVarChange(mp_startmoney, ConVarChanged);
}

public ConVarChanged(Handle:convar, const String:oldValue[], const String:newValue[])
{
    startmoney = GetConVarInt(mp_startmoney);
} 


Is it good way built this way ?

[Silvers]

Yeah that looks fine Bacardi.

[Bacardi]

But wait a minute, why I didn't though this earlier.
There can compare handles ??

PHP Code:

new Handle:mp_startmoney = INVALID_HANDLE;
new startmoney;

public OnPluginStart()
{
    mp_startmoney = FindConVar("mp_startmoney");
    startmoney = GetConVarInt(mp_startmoney);
    HookConVarChange(mp_startmoney, ConVarChanged);
}

public ConVarChanged(Handle:convar, const String:oldValue[], const String:newValue[])
{
    if(convar == mp_startmoney)    // This better ?
    {
        startmoney = StringToInt(newValue);
    }
} 


- And one less GetConvar function on use

[Silvers]

What would the point of that be? Optimization?

Originally Posted by berni The GetConVar* Functions are cheap and can be used just like that.

You may want to check in OnPluginStart that your handles are not INVALID_HANDLE but even then its highly unlikely to fail unless you don't supply the correct convar name.