[Kowalsky]

how can I optimize the code?

if( a > 90 )
...
else if( a<=90 && a>80 )
...
else if( a<=80 && a > 70 )

etc..

How can I convert it to switch?

[indraraj striker]

PHP Code:


switch (a)
{
    case 0 .. 30:
    {
       //This code will run if 0 <= a <= 30
    }
 
    case 31 .. 60:
    {
       //This code will run if 31 <= a <= 60
    }
 
    case 80 .. 90:
    {
       //This code will run if 80 <= a <= 90
    }
 
    default: 
    {
       //This code will run if all other cases fail 
       //when a > 90
    }
} 


[PartialCloning]

Better to keep it as an if/else statement than using ranges.

[Bugsy]

Originally Posted by PartialCloning Better to keep it as an if/else statement than using ranges.

Can you explain why you think this? Just curious

[PartialCloning]

I read ranges were removed from sourcemod in switch statements because "0 .. 30" would be turned into "if(a == 0 || a == 1 || a == 2 || ... a == 30)" by the compiler, rather than "if(0 <= a <= 30)".

Maybe only the sourcemod compiler does that, I'm not 100% sure.

Edit:

Originally Posted by BAILOPAN Don't use ranges. They were a bad/buggy feature in the AMX Mod X version so we removed them.

Originally Posted by BAILOPAN rhelgeby: We removed it because the implementation is extremely bad. It essentially expands it to a series of "if" statements, and this can mislead people into doing something like "0..100" whereas this would be much better: if (value >= 0 && value <= 100) Since the ".." syntax would result in: if (value == 0 || value == 1 || value == 2 || value == 3 || value == 4 || value == 5) ... (We could re-optimize this at run-time, but it seems like the right idea is to use if statements anyway.)

[siriusmd99]

Yeah, i heard this information too.
An advanced member said in one post that when you do case x:y it makes entries from x to y like if x == 1 or x == 2 and so to x = y.

So basically if you do case 1:100 it makes 100 checks .

I don't know if it's true but i read this once in a post.

[Bugsy]

Ok that makes sense then. It's a shame it works like that though.

@Kowalsky, you can handle ranges like this which looks cleaner, IMO.

PHP Code:

if( a > 90 )
...
else if ( 80 < a <= 90 )
...
else if ( 70 < a <= 80 )
...