[jakesmokie]

I don't know why, but my server crashes 1-3 times at day. Can this code produce some memory leaks?
And which handles do i need to delete too?
My typical menu:

PHP Code:

public void CallSomeMenu(int iClient)
{
    Menu m = CreateMenu(MenuHandler);
    
    // Some stuff right here...
    
    m.Display(iClient, 999);
}

public int CallSomeMenu(Menu m, MenuAction mAction, int iClient, int iPos)
{
    if (mAction == MenuAction_End)
        delete m;
        
    if (mAction != MenuAction_Select)
        return 0;
        
    // Another stuff..
        
    return 0;
} 


Query:

PHP Code:

public void OnClientPutInServer(int iClient)
{
    char sSteam[32];
    GetClientAuthId(iClient, AuthId_Steam2, sSteam, 31);
    
    char sQuery[256];
    FormatEx(sQuery, 255, "SELECT `data` FROM `table` WHERE `steam` = '%s' LIMIT 1;", sSteam);
    
    DB.Query(OnQueryDone, sQuery, iClient, DBPrio_High);
}

public void OnQueryDone(Database hDatabase, DBResultSet hResult, const char[] sError, int iClient)
{
    if (hResult == null)
    {
        LogError("Query error: %s", sError);
        return;
    }
    
    // Do some stuff..
    
    delete hResult;
} 


[Kailo]

Use sm_dump_handles command for finding leaks.

[Impact123]

The code can be enhanced, but i don't see any error.

A few suggestions

• Don't make your CallSomeMenu function public unless you need to
• Use sizeof(sSteam) and sizeof(sQuery) instead of 31 and 255
• Don't use DBPrio_* unless you know what it does and you need it
• Don't try to delete the hResult variable, see here for more information

[jakesmokie]

Thaks a lot, mates. If i use SQL_Query do i need to delete handle i guess?

[jakesmokie]

Originally Posted by kailo use sm_dump_handles command for finding leaks.

Спасибо за ответ

[Kailo]

Originally Posted by jakesmokie Спасибо за ответ

oh, also when i got memory leak crash, SourceMod has done log in csgo/sourcemod_fatal.log

P.S. From rules:

This is an English forum (other than a few specific, labeled subforums). If you're going to post in another language, also add the text in English, even if from online translator.

[jakesmokie]

Originally Posted by Kailo oh, also when i got memory leak crash, SourceMod has done log in csgo/sourcemod_fatal.log P.S. From rules:

Okay