[psychonic]

Originally Posted by Reg1oxeN sm plugin version

That will generate extra player_connect events, but should be fine other than that. (player_connect only happens at time of first connect, whereas OnClientConnected happens at connect and at map change. Additionally, the address field in the player_connect event normally also contains client port, and does with this thread's extension, but does not with your plugin).

[Reg1oxeN]

Originally Posted by psychonic That will generate extra player_connect events, but should be fine other than that. (player_connect only happens at time of first connect, whereas OnClientConnected happens at connect and at map change. Additionally, the address field in the player_connect event normally also contains client port, and does with this thread's extension, but does not with your plugin).

Expanding from time to time need to be recompiled, in contrast to the plugin. About OnClientConnected at map change i forgot. Not all that bad, as an alternative approach.

[ahmaden]

tested it , server crash , but when i disable cannounce.smx plugin , everything appears to be fine
how to solve it ,cant disable cannounce.smx because i need it too !

[psychonic]

Originally Posted by ahmaden tested it , server crash , but when i disable cannounce.smx plugin , everything appears to be fine how to solve it ,cant disable cannounce.smx because i need it too !

Originally Posted by psychonic The exact cause isn't readily apparent from just looking at the code. (I'd have to debug it.) But, it certainly seems relevant to Connect Announce blocking or resending the the player_connect event. The preferred alternative to this would be to use SetEventBroadcast (available since around SM 1.4) rather than rewriting the event from scratch to send without broadcasting to clients.

Originally Posted by psychonic Followup, it's actually due to this issue, https://bugs.alliedmods.net/show_bug.cgi?id=5097 If an extension (or MM:S plugin, and anything outside of SM really) has a pre-hook on an event, and an SM plugins pre-hooks the same event, and the plugin's hook happens to trigger first, and the plugin blocks the event, a crash will occur. The best workaround in this case is as mentioned in the previous post, changing Connect Announce to just use SetEventBroadcast instead of dropping and recreating the event.

[ahmaden]

The best workaround in this case is as mentioned in the previous post, changing Connect Announce to just use SetEventBroadcast instead of dropping and recreating the event.

how to do that ?

[FallenNT]

Originally Posted by nelioneil Could someone please upload a compiled working Windows version please

Compatible version for 1.7.3-git5233 + 1.10.6-git940
please

[claudiuhks]

Originally Posted by FallenNT Compatible version for 1.7.3-git5233 + 1.10.6-git940 please

Yes, please.

[Nolongerinthegame]

Originally Posted by Reg1oxeN sm plugin version

Originally Posted by psychonic That will generate extra player_connect events, but should be fine other than that. (player_connect only happens at time of first connect, whereas OnClientConnected happens at connect and at map change. Additionally, the address field in the player_connect event normally also contains client port, and does with this thread's extension, but does not with your plugin).

This works perfect for Windows at capturing the IP address. Apart from one thing....

In the first player_connect event, it actually uses someone elses steamid on the server, and then the ip address, the second event uses the correct steamID.


It should be like this:

player <STEAMIDCORRECT><>" connected, address "IP ADDRESS HERE"
player <STEAMIDCORRECT><> " STEAM USERID validated

But for some reason it appears like this:

player <STEAMIDOFSOMEONEELSEONSERVER><>" connected, address "IP ADDRESS HERE"
player <STEAMIDCORRECT><> " STEAM USERID validated

For some reason its taken someone elses steamid, and this is causing problems on my stats program, because it looks like someone is stealing names on the server.

Not using the mod, the connect events are:

player <STEAMIDCORRECT><>" connected, address ""
player <STEAMIDCORRECT><> " STEAM USERID validated

So something in your code is causing the incorrect steamid to be logged, because there is no steamid change when the mod is not used.

[asherkin]

Originally Posted by nelioneil But for some reason it appears like this: player <STEAMIDOFSOMEONEELSEONSERVER><>" connected, address "IP ADDRESS HERE" player <STEAMIDCORRECT><> " STEAM USERID validated

Steam IDs are not available before that "STEAM USERID validated" log message is printing, so because the plugin is use decl for the buffer and not checking the return value of GetClientAuthString, it is getting whatever was in there last - in this case the steamid of the last client on the last map change.

[Nolongerinthegame]

Originally Posted by asherkin Steam IDs are not available before that "STEAM USERID validated" log message is printing, so because the plugin is use decl for the buffer and not checking the return value of GetClientAuthString, it is getting whatever was in there last - in this case the steamid of the last client on the last map change.

So how should this get fixed then?