[finishlast]

Everytime I try to play with timers, I encounter various errors in the error logs.

Like this one:

L 12/30/2021 - 19:168: [SM] Exception reported: Invalid timer handle 65740965 (error 1)
L 12/30/2021 - 19:168: [SM] Blaming: l4d_death_toll_tunnel_block.smx
L 12/30/2021 - 19:168: [SM] Call stack trace:
L 12/30/2021 - 19:168: [SM] [0] KillTimer
L 12/30/2021 - 19:168: [SM] [1] Line 89, l4d_death_toll_tunnel_block.sp::OnMapEnd


I read various posts about cleaning up timers etc. and I found some code here and there but I am still unsure how to stop running timers, when the round ends etc.

Is there a master plan of stopping timers somewhere?

[Silvers]

https://forums.alliedmods.net/showpo...3&postcount=32

When the timer ends set "g_timer = null" in the callback. That's the issue.

Also you can just do "delete g_timer" instead of:

PHP Code:

    if (g_timer != INVALID_HANDLE) {
        KillTimer(g_timer);
        g_timer = INVALID_HANDLE;
    } 


delete does this same thing.

[finishlast]

Oh, that's very helpful, Silvers, thank you for that link!

Going to change and test that!

***

But I am still lost.

See this example 1st level sacrafice, when I press the button at the crane it will lift the container, when I !cm to load the map again, it will still lift the container.

So the timer is still active, it don't get stopped in this case. I tried to delete it on round freeze end just in case but still nothing.
It just keeps working.

[Earendil]

If you want to delete timers when map ends, use TIMER_FLAG_NO_MAPCHANGE in timer flags.

There is no point of trying to create a timer with an interval of 0.01s:

The smallest possible interval is 0.1 seconds. Timers have high precision (floating point) but low accuracy, as the current time is based on the in-game tick count, not the system clock.

[finishlast]

Oh, I see, thank you. I always thought the cleaning up timers would accomplish that.

With TIMER_FLAG_NO_MAPCHANGE it is working now, thanks a lot!

Good to know about the 0.1 min too.

***
Just an aditional question, it is not timer related but another problem I have in this plugin.

I try to check if a bot touches an entity (the container) and then set a cvar.

it is working but throws errors:

PHP Code:

L 12/31/2021 - 13:05:35: [SM] Call stack trace:
L 12/31/2021 - 13:05:35: [SM]   [0] IsClientInGame
L 12/31/2021 - 13:05:35: [SM]   [1] Line 466, l4d_river01_docks_pimp2.sp::OnTouch
L 12/31/2021 - 13:05:35: [SM] Exception reported: Client index 670 is invalid
L 12/31/2021 - 13:05:35: [SM] Blaming: l4d_river01_docks_pimp2.smx
L 12/31/2021 - 13:05:35: [SM] Call stack trace:
L 12/31/2021 - 13:05:35: [SM]   [0] IsClientInGame
L 12/31/2021 - 13:05:35: [SM]   [1] Line 466, l4d_river01_docks_pimp2.sp::OnTouch
L 12/31/2021 - 13:05:35: [SM] Exception reported: Client index 670 is invalid
L 12/31/2021 - 13:05:35: [SM] Blaming: l4d_river01_docks_pimp2.smx
L 12/31/2021 - 13:05:35: [SM] Call stack trace:
L 12/31/2021 - 13:05:35: [SM]   [0] IsClientInGame
L 12/31/2021 - 13:05:35: [SM]   [1] Line 466, l4d_river01_docks_pimp2.sp::OnTouch
L 12/31/2021 - 13:05:35: [SM] Exception reported: Client index 670 is invalid
L 12/31/2021 - 13:05:35: [SM] Blaming: l4d_river01_docks_pimp2.smx
L 12/31/2021 - 13:05:35: [SM] Call stack trace:
L 12/31/2021 - 13:05:35: [SM]   [0] IsClientInGame
L 12/31/2021 - 13:05:35: [SM]   [1] Line 466, l4d_river01_docks_pimp2.sp::OnTouch 


It seem like the

PHP Code:

    SDKHook(ent_dynamic_block1, SDKHook_Touch, OnTouch); 


that is supposed to register it, also tried to check for common infected.

PHP Code:

public void OnTouch(int client, int other)
{
//PrintToChatAll("%i", other);

if(other>0){
if(IsClientInGame(other) && IsFakeClient(other) && GetClientTeam(other) == 2)
{
SetConVarInt(FindConVar("sb_unstick"), 0);
//PrintToChatAll ("touched");
SDKUnhook(ent_dynamic_block1, SDKHook_Touch, OnTouch);
}

}
} 


Is there a way to filter common infected in this check?

[Silvers]

If you use TIMER_FLAG_NO_MAPCHANGE you need to set the timer handle to null in OnMapEnd, dont delete otherwise you'll probably get errors about invalid handle again since the timer is killing itself on map end. Without the flag, deleting the timer in map end should work fine. I see no reason for it to continue running, unless you're creating multiple timers and overwriting the handle without killing it before.

[Marttt]

OnTouch return for entities that aren't clients as well, like common infected and witch, you should check if is a valid client index before checking IsClientInGame

[finishlast]

Strange, when I change
g_timer = CreateTimer(0.1, gate, _, TIMER_REPEAT | TIMER_FLAG_NO_MAPCHANGE);
to
g_timer = CreateTimer(0.1, gate, _, TIMER_REPEAT);

it would still run after changing map to same map.

*****
Just to not get confused, when I have another plugin that uses a g_timer, that wouldn't interfear bc of the same name or?
*****


Is there a function for checking valid client indexes?!

My wife would yell now RTFM, I guess she is right

[Marttt]

PHP Code:

bool IsValidClientIndex(int client)
{
    return (1 <= client <= MaxClients);
}

bool IsValidClient(int client)
{
    return (IsValidClientIndex(client) && IsClientInGame(client));
} 


[finishlast]

Oh, thank you Marttt, silly me.

so

if(other > 0 && other <= MaxClients){

would work too