[HassePech]

Just replace line 208 in the antipingmask.sp script with this one and compile:

new nMatches = SimpleRegexMatch( CmdRate, "[^a-z A-Z \\_ \\d ]+" );

Works for me with "+" and "-" values.

Tested on DoD:Source.

[Mister_Magotchi]

I'm still using my fix from about 2.5 years ago to solve that problem. It forces the cl_cmdrate to only consist of digits and periods and to be greater than or equal to 30.

HassePech's regex, "[^a-z A-Z \\_ \\d ]+", if I'm reading the double-escaping right, allows only the following characters:
a lowercase letter
a space
an uppercase letter
a space (redundant)
an underscore (unnecessarily escaped as it's not a regex special character)
a space (redundant again)
a digit
a space (redundant yet again)

It also doesn't check the value of the number, and a low cl_cmdrate allows ping-masking.

The original regex, "[^\\d\\s\\.]+", allows only the following characters:
a digit
a space, tab, or line break
a period (unnecessarily escaped as a period is treated as a literal when used in a character class)

Whitespace is bad, as it still allows ping-masking.

My regex, for comparison, "[^0-9.]", allows only the following characters:
a digit
a period

The + (non-empty repetition) at the end was also unnecessary.

The value is then checked to make sure it's at least 30.

[eric0279]

Thanks, work's !

[St00ne]

Hi,

Thanks for this plugin, it's working fine. I'm using Mister_Magotchi little edit.

I would still need an answer to that question:
Why do you use CloseHandle (t_TimerHandle) instead of KillTimer (t_TimerHandle) ?

It works without error but I'd like to know the difference.

Regards,

St00ne

[minimoney1]

Originally Posted by St00ne Hi, Thanks for this plugin, it's working fine. I'm using Mister_Magotchi little edit. I would still need an answer to that question: Why do you use CloseHandle (t_TimerHandle) instead of KillTimer (t_TimerHandle) ? It works without error but I'd like to know the difference. Regards, St00ne

The only benefit to KillTimer() is the 2nd boolean parameter which lets you close any handles passed on to the timer through the info parameter if TIMER_DATA_HNDL_CLOSE was not specified. In this case, he doesn't even pass any variables through the info parameter when making the timer, so he doesn't really need to use KillTimer().

[eric0279]

but I can confirm that once in the game, if the player changes the variable cl_cmdrate +/-30, it is not kicked on L4D2

[St00ne]

Originally Posted by minimoney1 The only benefit to KillTimer() is the 2nd boolean parameter which lets you close any handles passed on to the timer through the info parameter if TIMER_DATA_HNDL_CLOSE was not specified. In this case, he doesn't even pass any variables through the info parameter when making the timer, so he doesn't really need to use KillTimer().

Hi,

Thx a lot for your answer. It's not perfectly clear for me but it still helped me, I also found this to get info: http://wiki.alliedmods.net/Timers_%2...d_Scripting%29

++

[Kalle4000]

Does the apm_timeinterval work? Because when testing this on my server, I changed the value to 35, or 19, or 55, but I get kicked almost 4 seconds after joining each time? (not because it's a problem, the plugin is quiet good/useful, but just pointing out)

[Andre Gomes]

I just translated it to portuguese and added to antipingmask.phares.txt

[IceCucumber]

Would love to see logging added to this (which cl_cmdrate value triggered the anti-ping mask).