[aron9forever]

I have a simple ace & semi-ace display in a mix plugin.
Relevant code

PHP Code:

RegisterHam(Ham_Killed, "player", "player_killed", 1);

public player_killed(victim, attacker, shouldgib)
{
        if(is_user_connected(victim) && is_user_connected(attacker) && attacker!=victim)
        {
            if((cs_get_user_team(attacker)==CS_TEAM_CT && cs_get_user_team(victim)==CS_TEAM_T) || (cs_get_user_team(attacker)==CS_TEAM_T && cs_get_user_team(victim)==CS_TEAM_CT))
            {
                g_frags[attacker]++;
            }
            
        }
}

public round_ended()//called from eT_win() and eCT_win()
{
    new iPlayers[32], iNum, player, name[32];
    get_players(iPlayers,iNum);
    for(new i=0;i<iNum;i++)
    {
        player = iPlayers[i];
        if(cs_get_user_team(player)==CS_TEAM_T || cs_get_user_team(player)==CS_TEAM_CT)
        {
            if(g_frags[player]==4)
            {
                get_user_name(player, name, 31);
                chat_color(0,".v%s .gJucatorul .e%s .ga realizat un .eSEMI-ACE.g!",PREFIX,name);
            }
            else if(g_frags[player]==5)
            {
                get_user_name(player, name, 31);
                chat_color(0,".v%s .gJucatorul .e%s .ga realizat un .eACE.g!",PREFIX,name);
            }
            g_frags[player] = 0;
        }
    }
} 


g_frags[] is also set to 0 on Ham_Spawn post as well as on round_start

PHP Code:

RegisterHam(Ham_Spawn, "player", "fwHamPlayerSpawnPost", 1);
register_logevent("round_start", 2, "0=World triggered", "1=Round_Start"); 


TL;DR:
frag counter increments on Ham_Killed
frag counter is reset at round_end (at sendaudio terwin&ctwin)
frag counter is reset at ham spawn post
frag counter is reset at round_start, when freezetime ends

on round end (at sendaudio terwin&ctwin), a player with 5 kills has "semi-ace" displayed in picture below



Am I missing something? Haven't found a way to reproduce the bug. Do nade kills count in ham_killed ?
EDIT:: This happened on 1st round after team switch, aka the 16th round of the game. I know there used to be some weird bug with players showing up in the wrong team until a respawn, not sure which functions were affected though or whether this might be the case, could be it when checking if a frag is valid.

[aron9forever]

Poop, I just noticed something, might be that the win sounds are triggered before the kill post, therefore if the player's 4th frag kills the last enemy, round end will be called before the 4th frag gets added so nothing will be displayed; would also explain why ace shows as semi-ace.

Should I switch to pre kill? With the existing code, would that work fine?
Should I use some other hook to count the frags?

[edon1337]

No Ham_Killed doesn't get called on grenades. Use DeathMsg ?

[EFFx]

I don't know if the Ham_Killed doesn't get called on grenades, you can search for learn more about it, if your current code doesn't work, just change him, use DeathMsg as edon said.

And

PHP Code:

if((cs_get_user_team(attacker)==CS_TEAM_CT && cs_get_user_team(victim)==CS_TEAM_T) || (cs_get_user_team(attacker)==CS_TEAM_T && cs_get_user_team(victim)==CS_TEAM_CT)) 


LOL, you just need this:

PHP Code:

if(cs_get_user_team(attacker) != cs_get_user_team(victim)) 


Here

PHP Code:

if(cs_get_user_team(player)==CS_TEAM_T || cs_get_user_team(player)==CS_TEAM_CT) 


Just add the flag 'e' on get_players()

Like this

PHP Code:

get_players(iPlayers,iNum,"e") 


Here's the API - https://www.amxmodx.org/api/amxmodx/get_players

[fysiks]

Originally Posted by edon1337 No Ham_Killed doesn't get called on grenades. Use DeathMsg ?

That seems unlikely. Being killed by a grenade means that the entity needs to die which is done with Ham_Killed.

[Bugsy]

Originally Posted by edon1337 No Ham_Killed doesn't get called on grenades. Use DeathMsg ?

PHP Code:

#include <amxmodx>
#include <hamsandwich>

public plugin_init() 
{
    RegisterHam( Ham_Killed , "player" , "HamKilled" );
}

public HamKilled( iPlayer , iKiller , iShouldGib )
{
    client_print( 0 , print_chat , "you were killed" );
} 


[EFFx]

PHP Code:

client_print( 0 , print_chat , "you were killed" ); 


->

PHP Code:

client_print( iKiller , print_chat , "you were killed" ); 


:*

[Bugsy]

Originally Posted by EFFx PHP Code: client_print( 0 , print_chat , "you were killed" );  -> PHP Code: client_print( iKiller , print_chat , "you were killed" );  :*

I used 0 on purpose. What does it matter? I was proving a point. I should have printed "grenade kill" instead of "you were killed" but I wrote this quickly. Either way, the goal was to show that the event fires on grenade kills, which it does.

[EFFx]

Dude, I'm kidding with you, sorry if you don't got it. Obviously I knew it was a purpose.

[edon1337]

Originally Posted by fysiks That seems unlikely. Being killed by a grenade means that the entity needs to die which is done with Ham_Killed.

Weird, I've read that Ham_Killed doesn't get called on grenades.