[CSTRIKE] Invalid player 1 - Page 2

wickedd · *Last edited by wickedd; 09-14-2016 at 13:07.*

PHP Code:


			
if( cs_get_user_team( Client ) == CS_TEAM_CT ) // problem come from here

You need to check is_user_alive and before you say you did look closer.

**HamletEagle** · 09-14-2016 , 12:40 Re: [CSTRIKE] Invalid player 1

Quote:

thank all for info, but why should i use give_item, fm_give_item better no?

No, it's worse. fm_give_item has the same code as give_item, but later is implemented in a module and should be faster. Even if the difference is trivial, using such conversions of already existing modules is stupid(that's why you should not use most of functions provided by fm util).

Snitch · *Last edited by Snitch; 09-14-2016 at 13:15.*

Quote:

Originally Posted by wickedd

PHP Code:


			
if( cs_get_user_team( Client ) == CS_TEAM_CT ) // problem come from here

You need to check is_user_alive and before you say you did look closer.

look here again:
https://forums.alliedmods.net/showpo...4&postcount=10

i already check if user alive, but maybe i check wrong should help?

maybe i will add:

Quote:

if( is_user_alive( Client ) && ( cs_get_user_team( Client ) == CS_TEAM_CT ) )

Quote:

Originally Posted by HamletEagle

No, it's worse. fm_give_item has the same code as give_item, but later is implemented in a module and should be faster. Even if the difference is trivial, using such conversions of already existing modules is stupid(that's why you should not use most of functions provided by fm util).

ok, sometimes modules show error and can't find it. i will try use fun include.

remove static iPlayer?

wickedd · 09-14-2016 , 13:26 Re: [CSTRIKE] Invalid player 1

Like I said...look closer because you didn't. The second cs_get_user_team is outside of the is_user_alive check.

PHP Code:


			
 if( is_user_alive( Client ) )
    {
        Player[ Client ][ PLAYER_DOUBLEDMG ] = 0
        
        if( g_PlayerKnives[ Client ][ playerUsingknife[ Client ] ] )
        {
            set_user_health( Client, ( get_user_health( Client ) + Knife_Info[ playerUsingknife[ Client ] ][ INFOKNIFE_EXTRA_HEALTH ] ) )
        }
        
        if( cs_get_user_team( Client ) == CS_TEAM_T )
        {
            if( g_PlayerSkins[ Client ][ playerUsingSkin[ Client ] ] )
            {
                cs_set_user_model( Client, Skin_Names[ playerUsingSkin[ Client ] ][ DETILS_DOWN ] )
                
                new intRandom = random_num( 1 , 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_GRANDE ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_GRANDE ) >= intRandom )
                    {
                        give_grenade( Client, CSW_HEGRENADE );
                    }
                }
                
                intRandom = random_num( 1, 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_STAMINA ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_STAMINA ) >= intRandom )
                    {
                        give_grenade( Client, CSW_FLASHBANG );
                    }
                }
            }
        }
        else cs_reset_user_model( Client );
        }
    
    if( cs_get_user_team( Client ) == CS_TEAM_CT ) // problem come from here
    {
        fm_give_item( iPlayer, "weapon_m4a1" );
        
        fm_give_item( iPlayer, "weapon_deagle" );
        
        cs_set_user_bpammo( iPlayer, CSW_M4A1, 120 );
        
        cs_set_user_bpammo( iPlayer, CSW_DEAGLE, 70 );
        
        cs_reset_user_model( Client );
    }
}

Snitch · 09-14-2016 , 13:30 Re: [CSTRIKE] Invalid player 1

Quote:

Originally Posted by wickedd

Like I said...look closer because you didn't. The second cs_get_user_team is outside of the is_user_alive check.

PHP Code:


			
 if( is_user_alive( Client ) )
    {
        Player[ Client ][ PLAYER_DOUBLEDMG ] = 0
        
        if( g_PlayerKnives[ Client ][ playerUsingknife[ Client ] ] )
        {
            set_user_health( Client, ( get_user_health( Client ) + Knife_Info[ playerUsingknife[ Client ] ][ INFOKNIFE_EXTRA_HEALTH ] ) )
        }
        
        if( cs_get_user_team( Client ) == CS_TEAM_T )
        {
            if( g_PlayerSkins[ Client ][ playerUsingSkin[ Client ] ] )
            {
                cs_set_user_model( Client, Skin_Names[ playerUsingSkin[ Client ] ][ DETILS_DOWN ] )
                
                new intRandom = random_num( 1 , 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_GRANDE ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_GRANDE ) >= intRandom )
                    {
                        give_grenade( Client, CSW_HEGRENADE );
                    }
                }
                
                intRandom = random_num( 1, 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_STAMINA ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_STAMINA ) >= intRandom )
                    {
                        give_grenade( Client, CSW_FLASHBANG );
                    }
                }
            }
        }
        else cs_reset_user_model( Client );
        }
    
    if( cs_get_user_team( Client ) == CS_TEAM_CT ) // problem come from here
    {
        fm_give_item( iPlayer, "weapon_m4a1" );
        
        fm_give_item( iPlayer, "weapon_deagle" );
        
        cs_set_user_bpammo( iPlayer, CSW_M4A1, 120 );
        
        cs_set_user_bpammo( iPlayer, CSW_DEAGLE, 70 );
        
        cs_reset_user_model( Client );
    }
}

thank, is fixed
just show example, to be sure:

Code:

public Ham_PlayerSpawn( Client )
{
    //static iPlayer;
    
    if( is_user_alive( Client ) )
    {
        Player[ Client ][ PLAYER_DOUBLEDMG ] = 0
        
        if( g_PlayerKnives[ Client ][ playerUsingknife[ Client ] ] )
        {
            set_user_health( Client, ( get_user_health( Client ) + Knife_Info[ playerUsingknife[ Client ] ][ INFOKNIFE_EXTRA_HEALTH ] ) )
        }
        
        if( cs_get_user_team( Client ) == CS_TEAM_T )
        {
            if( g_PlayerSkins[ Client ][ playerUsingSkin[ Client ] ] )
            {
                cs_set_user_model( Client, Skin_Names[ playerUsingSkin[ Client ] ][ DETILS_DOWN ] )
                
                new intRandom = random_num( 1 , 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_GRANDE ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_GRANDE ) >= intRandom )
                    {
                        give_grenade( Client, CSW_HEGRENADE );
                    }
                }
                
                intRandom = random_num( 1, 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_STAMINA ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_STAMINA ) >= intRandom )
                    {
                        give_grenade( Client, CSW_FLASHBANG );
                    }
                }
            }
        }
        else cs_reset_user_model( Client );
        }
    
    if( is_user_alive( Client ) && ( cs_get_user_team( Client ) == CS_TEAM_CT ) )
    {
        give_item( Client, "weapon_m4a1" );
        
        give_item( Client, "weapon_deagle" );
        
        cs_set_user_bpammo( Client, CSW_M4A1, 120 );
        
        cs_set_user_bpammo( Client, CSW_DEAGLE, 70 );
        
        cs_reset_user_model( Client );
    }
}

wickedd · 09-14-2016 , 13:48 Re: [CSTRIKE] Invalid player 1

PHP Code:


			
public Ham_PlayerSpawn( Client )
{  
    if( is_user_alive( Client ) )
    {
        Player[ Client ][ PLAYER_DOUBLEDMG ] = 0
        
        if( g_PlayerKnives[ Client ][ playerUsingknife[ Client ] ] )
        {
            set_user_health( Client, ( get_user_health( Client ) + Knife_Info[ playerUsingknife[ Client ] ][ INFOKNIFE_EXTRA_HEALTH ] ) )
        }
        
        if( cs_get_user_team( Client ) == CS_TEAM_T )
        {
            if( g_PlayerSkins[ Client ][ playerUsingSkin[ Client ] ] )
            {
                cs_set_user_model( Client, Skin_Names[ playerUsingSkin[ Client ] ][ DETILS_DOWN ] )
                
                new intRandom = random_num( 1 , 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_GRANDE ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_GRANDE ) >= intRandom )
                    {
                        give_grenade( Client, CSW_HEGRENADE );
                    }
                }
                
                intRandom = random_num( 1, 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_STAMINA ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_STAMINA ) >= intRandom )
                    {
                        give_grenade( Client, CSW_FLASHBANG );
                    }
                }
            }
       }    
       if( cs_get_user_team( Client ) == CS_TEAM_CT ) // problem come from here
       {
           fm_give_item( Client, "weapon_m4a1" );
        
           fm_give_item( Client, "weapon_deagle" );
        
           cs_set_user_bpammo( Client, CSW_M4A1, 120 );
        
           cs_set_user_bpammo( Client, CSW_DEAGLE, 70 );       
       }
       cs_reset_user_model( Client );
    }
}

You can do this. Also, I deleted the static iPlayer because it's useless.

Snitch · 09-14-2016 , 14:26 Re: [CSTRIKE] Invalid player 1

Quote:

Originally Posted by wickedd

PHP Code:


			
public Ham_PlayerSpawn( Client )
{  
    if( is_user_alive( Client ) )
    {
        Player[ Client ][ PLAYER_DOUBLEDMG ] = 0
        
        if( g_PlayerKnives[ Client ][ playerUsingknife[ Client ] ] )
        {
            set_user_health( Client, ( get_user_health( Client ) + Knife_Info[ playerUsingknife[ Client ] ][ INFOKNIFE_EXTRA_HEALTH ] ) )
        }
        
        if( cs_get_user_team( Client ) == CS_TEAM_T )
        {
            if( g_PlayerSkins[ Client ][ playerUsingSkin[ Client ] ] )
            {
                cs_set_user_model( Client, Skin_Names[ playerUsingSkin[ Client ] ][ DETILS_DOWN ] )
                
                new intRandom = random_num( 1 , 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_GRANDE ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_GRANDE ) >= intRandom )
                    {
                        give_grenade( Client, CSW_HEGRENADE );
                    }
                }
                
                intRandom = random_num( 1, 100 );
                
                if( g_PlayerUpgrade[ Client ][ playerUsingSkin[ Client ] ][ SKIN_STAMINA ] > 0 )
                {
                    if( GetUserStat( Client, playerUsingSkin[ Client ], SKIN_STAMINA ) >= intRandom )
                    {
                        give_grenade( Client, CSW_FLASHBANG );
                    }
                }
            }
       }    
       if( cs_get_user_team( Client ) == CS_TEAM_CT ) // problem come from here
       {
           fm_give_item( Client, "weapon_m4a1" );
        
           fm_give_item( Client, "weapon_deagle" );
        
           cs_set_user_bpammo( Client, CSW_M4A1, 120 );
        
           cs_set_user_bpammo( Client, CSW_DEAGLE, 70 );       
       }
       cs_reset_user_model( Client );
    }
}

You can do this. Also, I deleted the static iPlayer because it's useless.

so i dont need check if user is alive?

Code:

 if( is_user_alive( Client ) && ( cs_get_user_team( Client ) == CS_TEAM_CT ) )

and fm_give_item to give_item?

**HamletEagle** · 09-14-2016 , 14:34 Re: [CSTRIKE] Invalid player 1

You already check at the top of the function if user is alive, so no.
Yes for the second question.

wickedd · *Last edited by wickedd; 09-14-2016 at 14:40.*

Quote:

Originally Posted by Snitch

so i dont need check if user is alive?

Quote:

Originally Posted by HamletEagle

You already check at the top of the function if user is alive, so no.

You don't need to if you use code I posted.