[EFFx]

Don't use get_maxplayers() at a loop. As I said, it will loop 32 ids even if the server has only 10. The get_playersnum() basically is the same as get_players() does. Both will return player's id when you use it as loop. But get_players() has more parameters: flag, team... while the get_playersnum() hasn't. If you'll loop player's ID with get_playersnum(), will be like this:

PHP Code:

for(new i;i < get_playersnum();i++)
{
     if(!is_user_connected(i) && !is_user_alive(i) && !is_user_bot(i) && !is_user_hltv(i) && get_user_team(i) != 2)
       return
} 


While when you'll loop with get_players, you only need this:

PHP Code:

new iPlayers[32], iNum, iPlayer
get_players(iPlayers, iNum, "acehi", "CT")
for(new i;i < iNum;i++)
{
      iPlayer = iPlayers[i]
} 


iPlayer is all player's ID.

https://www.amxmodx.org/api/amxmodx/get_players

Edit: get_playersnum() is not the same as get_players(). I guessed it was, but isn't https://forums.alliedmods.net/showpo...0&postcount=23

[HamletEagle]

or proving that fakemeta_util it is bad

Let's make this one clear: fakemeta_util is not bad just because it's bad. There are few reasons:
1.Some stocks are simple conversions(NOTHING MORE ADDED, JUST A CONVERSION) from module natives. This is slower and useless.
2.Some stocks are just wrappers around already-existing functions(for example #define fm_precache_generic(%1) engfunc(EngFunc_PrecacheGeneric, %1). While this is not wrong, it's just stupid and will create confusions.
3.Some stocks are poor ways of doing something, probably because at the point when fm_util was written there were no better alternatives(as an example see fm_get_weaponbox_type).

Some stocks may be usefull depending on what you are doing(like fm_transfer_user_gun). All comes down to what function is being used from that include.

[PRoSToTeM@]

Originally Posted by EFFx If you'll loop player's ID with get_playersnum(), will be like this: PHP Code: for(new i;i < get_playersnum();i++) {      if(!is_user_connected(i) && !is_user_alive(i) && !is_user_bot(i) && !is_user_hltv(i) && get_user_team(i) != 2)        return }

This code is fully incorrect. You can't use get_playersnum for player loop. Imagine that there is only 1 player and it has index 32.

[EFFx]

Yes, that's so incorrect. But my point was to explain that get_players() is better anyway. And I didn't knew that was possible a player get 32 index while he's alone. I guessed it went be 1. I've so much time without play the game. I forgot somethings.

[HamletEagle]

If the others disconnect and he is the 32rd player, then playersnum is 1 and his index is 32.

[EFFx]

There's.

[CrazY.]

HamletEagle/EFFx, now I understand, thanks for the explanation, but, why exists since it's incorrectly to use? I don't understand nothing about the logic of amxx dev team. Well, without further ado, the issue has already been solved.

More one thing, then if I need to check if is a valid alive player, or something. This is completly incorrectly?

PHP Code:

#define is_user_valid_alive (1 <= %1 <= get_maxplayers && is_user_alive(%1))

#define is_user_valid_alive (1 <= %1 <= get_playersnum() && is_user_alive(%1)) 


[EFFx]

Everythings on amxx have one purpose. Nothing is there just for decoration. But about your question:

get_maxplayers() is the correct one. As I said, it returns how much players the server can support. So 1 <= id <= get_maxplayers. It means that the player's id should be between 1 and X, where X is the max players that the server can support. An example: The server's slot is 16, only is possible 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 and 16 IDS. get_maxplayers() will return 16. Then

1 <= ID <= get_maxplayers()
more than or equal to 1 or less than or equal to get_maxplayers() ( 16 ). Only can be possible ids less than 1 or more than get_maxplayers() weapon's ID, entities, etc... Everything that's not player. 'Cuz that some people call that macro as IsPlayer(%1).

[CrazY.]

Mmm, well, thanks for the explanation.

[PRoSToTeM@]

Originally Posted by CrazY. why exists since it's incorrectly to use?

It is done for other purposes. For example, for current player count printing:

server_print("There are %d players on the server", get_playersnum());

Originally Posted by CrazY. PHP Code: #define is_user_valid_alive (1 <= %1 <= get_maxplayers && is_user_alive(%1)) #define is_user_valid_alive (1 <= %1 <= get_playersnum() && is_user_alive(%1))

The first one is the same as is_user_alive. The second is incorrect.

Originally Posted by EFFx weapon's ID

Maybe weapon entities?