[Craxor]

What opinion you have about this one:

/*
    This stock return all the players Id's based on 'flags' and 'team' you've set it up.

    Note: team's string:
        "CT" or "TERRORISTS"

    Note2: for using second parameter you would need to add the flag "e".
    Like this: GetPlayersId( "ae", "CT" );

*/

GetPlayersId( flags[]="" , team[]="" )
{
    new gPlayers[32], gPlayersCount, PlayerIndexes;
 
    if( contain( flags, "e" ) > -1 )
        get_players( gPlayers, gPlayersCount, flags, team)

    else
        get_players( gPlayers, gPlayersCount , flags );

    for( new i = 0 ; i < sizeof( gPlayersCount ) ; i++ )
        PlayerIndexes = gPlayers[i];

    return PlayerIndexes;         
}

Example:

Click

PHP Code:

#include <amxmodx>

public plugin_init( )
{
    register_clcmd( "say /test" , "test" );
}

public test( id )
{
    new szName[33];

    new Player = GetPlayersId( "a" );

    get_user_name( Player , szName, charsmax( szName ) );

    client_print( id, print_chat, "%s", szName );
}




GetPlayersId( flags[]="" , team[]="" )
{
    new gPlayers[32], gPlayersCount, PlayerIndexes;
 
    if( contain( flags, "e" ) > -1 )
        get_players( gPlayers, gPlayersCount, flags, team)

    else
        get_players( gPlayers, gPlayersCount , flags );

    for( new i = 0 ; i < sizeof( gPlayersCount ) ; i++ )
        PlayerIndexes = gPlayers[i];

    return PlayerIndexes;            
} 


It should be added something similiar to the next version of amxx, because i'm realy lazy to write by myself the whole fucking loop all the time when i make a new plugin....
( Nothing to say also about the people who still using the old method to loop all the players from server ... ( id <= Maxplayer bla bla bla ... ).

[EFFx]

I'll try it, but its not the same of a Macro? You're using just one array and a variable for pickup all players on the server.

[EFFx]

I've founded a new thing, how can i pickup the last player alive? Example

PHP Code:

get_user_name(LastPlayer[0],szName,charsmax(szName)) 


I cant do it.

[Craxor]

Originally Posted by EFFx I've founded a new thing, how can i pickup the last player alive? Example PHP Code: get_user_name(LastPlayer[0],szName,charsmax(szName))  I cant do it.

Search for all players, use flag 'a' to take only alive players, if is just one player alive just use as normal the variable, because will found just one player)

But to CHECK if is just one you would need to check the player count i believe ( the second param you use inside of get_players ) .

But i also think to add something similiar to my stock.

[wickedd]

Originally Posted by EFFx I've founded a new thing, how can i pickup the last player alive? Example PHP Code: get_user_name(LastPlayer[0],szName,charsmax(szName))  I cant do it.

Here you go

[Craxor]

An example with my stock modified, here's the code:

very good!

#include <amxmodx>

public plugin_init( )
{
	register_clcmd( "say /test", "test" );
}

public test( id )
{

	// Here we get the number of the players, wee need to check if only one!
	new Number = GetPlayers( 0, "a" );


	// Here we get the id of the last player
	new PlayersId = GetPlayers( 1, "a" );

	
	client_print( id, print_chat, "Number of alive players found: %i", Number );
	
	if( Number == 1 )
	{
		new szName[ 33 ];
		get_user_name( PlayersId , szName, charsmax( szName ) );

		client_print( 0, print_chat, " Last user alive: %s ", szName );
	}

}

GetPlayers( RETURN_TYPE = 1 , flags[] = "" , team[]= "" )
{
	new gPlayers[32], gPlayersCount, PlayerIndexes;
 
	if( contain( flags, "e" ) > -1 )
		get_players( gPlayers, gPlayersCount, flags, team)

	else
		get_players( gPlayers, gPlayersCount , flags );

	for( new i = 0 ; i < sizeof( gPlayersCount ) ; i++ )
	{
		if( RETURN_TYPE >= 1 )
			PlayerIndexes = gPlayers[i];
		else
			PlayerIndexes = gPlayersCount;
	}
        
	return PlayerIndexes;            
}

[fysiks]

Originally Posted by Craxor What opinion you have about this one: /*     This stock return all the players Id's based on 'flags' and 'team' you've set it up.     Note: team's string:         "CT" or "TERRORISTS"     Note2: for using second parameter you would need to add the flag "e".     Like this: GetPlayersId( "ae", "CT" ); */ GetPlayersId( flags[]="" , team[]="" ) {     new gPlayers[32], gPlayersCount, PlayerIndexes;       if( contain( flags, "e" ) > -1 )         get_players( gPlayers, gPlayersCount, flags, team)     else         get_players( gPlayers, gPlayersCount , flags );     for( new i = 0 ; i < sizeof( gPlayersCount ) ; i++ )         PlayerIndexes = gPlayers[i];     return PlayerIndexes;          }

That function is nonsensical i.e. it doesn't make sense and doesn't do what the documentation says it does.

Originally Posted by EFFx stuff

If the function is based on a command (chat, console, or server) then always use get_players() in that function every time. No global variables.

[Craxor]

It does what the documentation says, check one poste above yours i leave there an example of how it works.

[fysiks]

Originally Posted by Craxor It does what the documentation says, check one poste above yours i leave there an example of how it works.

Your edited version also doesn't make sense. The fact that the function's name is plural means it would be expected to return multiple player IDs which it doesn't and never will. It returns a scalar value which is a single number, always.

[Craxor]

Originally Posted by fysiks Your edited version also doesn't make sense. The fact that the function's name is plural means it would be expected to return multiple player IDs which it doesn't and never will. It returns a scalar value which is a single number, always.

I'm realy confused of what you talking about, maybe my stupid english i dunno ...

anyway, let me explain

if you set the first parameter as a pozitive value "1" or bigger, it should return you the gPlayers[i] ( which is the all players Id based on flags or team you take them ) if you put '0' or anyway, less than 1 , it returns you gPlayersCount ( which is the total number of players founded ).

I've just tested the code above and works well.


Edit:

I suppose you're talking about these descriptions:

// Here we get the number of the players, wee need to check if only one!
new Number = GetPlayers( 0, "a" );


// Here we get the id of the last player
new PlayersId = GetPlayers( 1, "a" );

Yes, they are wrong, they should be like that:

->


// Here we get the total numbers of alive players, we need to check if Number == 1, then check for last player
new Number = GetPlayers( 0, "a" );


// Here we take the whole id's of alive players from the server, then we check if Number == 1, if yes, PlayersId will be the Id of the last player alive (because his the only one alive.. ).
new PlayersId = GetPlayers( 1, "a" );