[devicenull]

This (mostly) replaces my downloader plugin. It uses the sockets module to download a file via HTTP.

This works right now, I wouldn't exactly call it well tested. I'm posting it here rather then in the plugins area as it needs some cleanup before it goes there.

You can get it from http://devicenull.org/files/downloader.0.0.0.1.zip

It only adds one function:

functag DownloadFile_Sucess public(any:arg);
functag DownloadFile_Error public(type,num,any:arg);

native DownloadFile(const String:destname[],const String:host[],const String:path[],DownloadFile_Sucess:suc,DownloadFile_Error:err,any:arg);

Example:

#include <sourcemod>
#include <downloader>

public DownloadFile_Sucess:sucess(arg)
{
	PrintToServer("sucess %i",arg);
}

public DownloadFile_Error:error(type,num,arg)
{
	PrintToServer("error %i %i %i",type,num,arg);
}

public OnPluginStart()
{
DownloadFile("devicenull.org.txt","www.devicenull.org","",DownloadFile_Sucess:sucess,DownloadFile_Error:error,1337);
}

[SirLamer]

There are a couple issues with the code, one of which is critical.

1. The library name of the downloader.sp plugin is not defined. This needs to occur in OnPluginStart() of downloader.sp. The library name doesn't have to match the file name but it DOES have to match the "name" field as defined in the include file.

In downloader.sp:

public OnPluginStart()
{
	RegPluginLibrary("downloader");
	...
}

Reference: http://wiki.alliedmods.net/Optional_...Mod_Scripting)

2. An array looks for "MAX_URL_LEN" for the string length when being created. I put #define MAX_URL_LEN 298 in to make it work.


3. Spelling of the word "success" is consistently mispelt as "sucess". The code compiles and works, but since users of this plug-in have to insert "DownloadFile_Sucess" in their code, I can imagine people missing the spelling error, spelling it correctly in their own code and causing errors.


I have not yet tested this plug-in to see if it works beyond running and hooking with my own plug-in, but I have spent a couple of days trying to figure out why my plug-in wasn't able to hook with Downloader when it was successfully running. I'll report if I find more issues and how I was able to resolve them.

[MulleDK19]

Originally Posted by SirLamer There are a couple issues with the code, one of which is critical. 1. The library name of the downloader.sp plugin is not defined. This needs to occur in OnPluginStart() of downloader.sp. The library name doesn't have to match the file name but it DOES have to match the "name" field as defined in the include file. In downloader.sp: public OnPluginStart() { RegPluginLibrary("downloader"); ... } Reference: http://wiki.alliedmods.net/Optional_...Mod_Scripting) 2. An array looks for "MAX_URL_LEN" for the string length when being created. I put #define MAX_URL_LEN 298 in to make it work. 3. Spelling of the word "success" is consistently mispelt as "sucess". The code compiles and works, but since users of this plug-in have to insert "DownloadFile_Sucess" in their code, I can imagine people missing the spelling error, spelling it correctly in their own code and causing errors. I have not yet tested this plug-in to see if it works beyond running and hooking with my own plug-in, but I have spent a couple of days trying to figure out why my plug-in wasn't able to hook with Downloader when it was successfully running. I'll report if I find more issues and how I was able to resolve them.

That, and it downloads 1 byte too little!!!
If I upload a 300 byte file, the downloaded is only 299 bytes.

Other than that, awesome plugin, thx

Edit: I just found out that it completely corrupts the files it downloads. The first part of the downloaded file is fine. But like 10% into the file, it misses a character, starts putting the rest where that char should have been, resulting in all bytes being placed one position less than they should.

[SirLamer]

Yeah, I was going to use this script for a large plug-in I am developing but gave up on it and found another way to do what I need.

[exvel]

Originally Posted by SirLamer Yeah, I was going to use this script for a large plug-in I am developing but gave up on it and found another way to do what I need.

Just use Sockets Extension.

[SirLamer]

Nah it's not like that, I'm making a large database-driven script that loads in MOTD. I was having a PHP script do a database search then upload the results to the server, just to keep the load off of the game server machine, but I just bit the bullet and SourcePawn is handling the database search instead... though it also forced me to rearrange the relationships between my game server and remote server.