[zmd94]

I appreciate it. Feel free to use it. If there are any problems, just let me know.

[happy_2012]

Why don't you make a print_color.inc file instead of writing the function of print_color in each of your plugins?

[zmd94]

It is because I don't think it is really necessary. Yet, what is your opinion about this plugin? Any comments or suggestions?

[happy_2012]

I must say that your plugin(s) are quite impressive ;)

I recommend you add errors on these API functions and return -1 instead of 0 ;)

PHP Code:

public native_is_terrorist(iPlugin, iParams)
{
    new id = get_param(1)
    
    if (!is_user_connected(id))
        return 0
    
    return flag_get_boolean(g_isTerrorist, id);
}

public native_is_last_terrorist(iPlugin, iParams)
{
    new id = get_param(1)
    
    if (!is_user_connected(id))
        return 0
    
    return flag_get_boolean(g_iLastTerrorist, id);
}

public native_is_last_counter(iPlugin, iParams)
{
    new id = get_param(1)
    
    if (!is_user_connected(id))
        return 0
    
    return flag_get_boolean(g_iLastCounter, id);
} 


to ->

PHP Code:

public native_is_terrorist(iPlugin, iParams)
{
    new id = get_param(1)
    
    if (!is_user_connected(id))
    {
        log_error(AMX_ERR_NATIVE, "[CS] Player is not connected (%d)", id)
        return -1
    }
    
    return flag_get_boolean(g_isTerrorist, id);
}

public native_is_last_terrorist(iPlugin, iParams)
{
    new id = get_param(1)
    
    if (!is_user_connected(id))
    {
        log_error(AMX_ERR_NATIVE, "[CS] Player is not connected (%d)", id)
        return -1
    }
    
    return flag_get_boolean(g_iLastTerrorist, id);
}

public native_is_last_counter(iPlugin, iParams)
{
    new id = get_param(1)
    
    if (!is_user_connected(id))
    {
        log_error(AMX_ERR_NATIVE, "[CS] Player is not connected (%d)", id)
        return -1
    }
    
    return flag_get_boolean(g_iLastCounter, id);
} 


some people might want to know what and why is the error being thrown.

[zmd94]

I appreciate your suggestion. ;)

[Kz1.0]

How do you get these stats ? https://forums.alliedmods.net/showpo...&postcount=112
Seem insteresting.

[zmd94]

Just visit below thread:

https://forums.alliedmods.net/showthread.php?t=67752

[zmd94]

So, any suggestions or comments for improvement?

[zmd94]

Codes now is at GitHub:

[HamletEagle]

Even if your code would be perfect this does not change the fact that's an API for something like that is silly.
Why ? What you do here is just to make some wrappers for default functions and to copy/paste some plugins together. API should provide some better handling or a better control on some context, it could also facilitate access to something that would be hard to accomplish without, but this does not mean it should be a lazy error checker.

For example:
1.cs_health_reward -> set_user_health
2.cs_armor_reward -> set_user_armor
3.cs_money_reward -> cs_set_user_money(just a matter to change m_iAccount offset).
4.cs_invisible_reward -> set_user_rendering
5.cs_noclip_reward -> set_user_noclip.
6.cs_grenade_reward -> give_item
7.cs_weapon_reward -> give_item + cs_set_user_bpammo.
8.cs_godmode_reward -> set_user_godmode.
9.cs_glow_reward -> set_user_rendering
10.cs_gravity_reward -> set_user_gravity.
11.cs_speed_reward -> set_user_maxspeed + ItemPreFrame().

The other natives are just random copy/paste from other plugins. Some of them may make sense, like cs_istrap.

1.cs_fw_spawn_post -> Ham_Spawn
2.cs_fw_first_blood -> few checks + Ham_Killed.
3.cs_is_terrorist -> get_user_team
4.cs_get_terrorist_count -> get_players + e flag
5.cs_get_counter_count -> get_players + e flag

I don't want to be rude, but I don't see the point of such API. So, if you want this to have any chances of being considered usefull think to add stuffs that make sense from the POV of an API.