[Pavelas]

Hello guys,

I have a few problems with Client_RemoveAllWeapons() function.

Requirement: I would like to reset player weapons and money on spawn.

1st Problem: Why do we need to create a timer with small delay to remove all player weapons and give default weapons? (Otherwise it does not work)

Solution:

PHP Code:

mp_backup_round_file ""
mp_backup_round_file_last ""
mp_backup_round_file_pattern ""
mp_backup_round_auto "0" 


2nd Problem: If player drop weapon on round end a few ms before respawn, he will get this weapon next round. (It is hard to abuse, but sometimes it happens)

Maybe you have any idea how to solve this problem?
What is the best approach how I can implement this functionality?


Code:

PHP Code:


public void OnPluginStart() {
    HookEvent("player_spawn", Event_PlayerSpawn);
}

public Action Event_PlayerSpawn(Event event, const char[] name, bool dontBroadcast) {
    int client = GetClientOfUserId(event.GetInt("userid"));
    ResetPlayer(client);
}

public void ResetPlayer(int client) {
    if (!IsClientConnected(client) || !IsClientInGame(client))
        return;

    Client_RemoveAllWeapons(client, "weapon_c4");

    SetEntProp(client, Prop_Send, "m_bHasHelmet", 0);
    SetEntProp(client, Prop_Send, "m_ArmorValue", 0);
    SetEntProp(client, Prop_Send, "m_iAccount", 800);

    if (GetClientTeam(client) == CS_TEAM_T) {
        GivePlayerItem(client, "weapon_knife_t");
        GivePlayerItem(client, "weapon_glock");
    }

    if (GetClientTeam(client) == CS_TEAM_CT) {
        GivePlayerItem(client, "weapon_knife");
        GivePlayerItem(client, "weapon_hkp2000");
    }
} 


Thank you!

[Neuro Toxin]

Try using the round_start event. This fires after player_spawn.

[Pavelas]

But in this case we will need to loop all players, is it good approach to use loops?
Sorry for stupid question, in ECMAScript people are trying to avoid loops.

[PinHeaDi]

How about something like that:

PHP Code:

public void OnPluginStart() {
    HookEvent("player_spawn", Event_PlayerSpawn);
}

public Action Event_PlayerSpawn(Event event, const char[] name, bool dontBroadcast) {
    int client = GetClientOfUserId(event.GetInt("userid"));
    
    if (!IsClientConnected(client) || !IsClientInGame(client))
        return;
    
    CreateTimer(0.01, ResetPlayer, client, TIMER_FLAG_NO_MAPCHANGE);
    
    SetEntProp(client, Prop_Send, "m_bHasHelmet", 0);
    SetEntProp(client, Prop_Send, "m_ArmorValue", 0);
    SetEntProp(client, Prop_Send, "m_iAccount", 800);

    if (GetClientTeam(client) == CS_TEAM_T) {
        GivePlayerItem(client, "weapon_knife_t");
        GivePlayerItem(client, "weapon_glock");
    }
    else if (GetClientTeam(client) == CS_TEAM_CT) {
        GivePlayerItem(client, "weapon_knife");
        GivePlayerItem(client, "weapon_hkp2000");
    }
    
}

public Action ResetPlayer(Handle timer, int client) {
    Client_RemoveAllWeapons(client, "weapon_c4");
} 


P.S: I'm not sure if 0.01 is possible.

[Pavelas]

Thank you very much for quick response! I will try this solution, but maybe it is possible to implement this feature without timer?

P.S. This function does not work without timer with this event.

PHP Code:

SetEntProp(client, Prop_Send, "m_iAccount", 800); 


[PinHeaDi]

Try this without a timer:

PHP Code:

public void OnPluginStart() {
    HookEvent("player_spawn", Event_PlayerSpawn);
}

public Action Event_PlayerSpawn(Event event, const char[] name, bool dontBroadcast) {
    int client = GetClientOfUserId(event.GetInt("userid"));
    
    if (!IsClientConnected(client) || !IsClientInGame(client))
        return;
    
    Client_RemoveAllWeapons(client, "weapon_c4");
    
    if (GetClientTeam(client) == CS_TEAM_T) {
        GivePlayerItem(client, "weapon_knife_t");
        GivePlayerItem(client, "weapon_glock");
    }
    else if (GetClientTeam(client) == CS_TEAM_CT) {
        GivePlayerItem(client, "weapon_knife");
        GivePlayerItem(client, "weapon_hkp2000");
    }
    
    SetEntProp(client, Prop_Send, "m_iAccount", 800);
    SetEntProp(client, Prop_Send, "m_bHasHelmet", 0);
    SetEntProp(client, Prop_Send, "m_ArmorValue", 0);
} 


or

PHP Code:

public void OnPluginStart() {
    HookEvent("player_spawn", Event_PlayerSpawn);
}

public Action Event_PlayerSpawn(Event event, const char[] name, bool dontBroadcast) {
    int client = GetClientOfUserId(event.GetInt("userid"));
    
    if (!IsClientConnected(client) || !IsClientInGame(client))
        return;
    
    SetEntProp(client);
    RemoveWeapons(client);
}


public void RemoveWeapons(int client)
{
    Client_RemoveAllWeapons(client, "weapon_c4");
    if (GetClientTeam(client) == CS_TEAM_T) {
        GivePlayerItem(client, "weapon_knife_t");
        GivePlayerItem(client, "weapon_glock");
    }
    else if (GetClientTeam(client) == CS_TEAM_CT) {
        GivePlayerItem(client, "weapon_knife");
        GivePlayerItem(client, "weapon_hkp2000");
    }
}

public void SetEntProp(int client)
{
    SetEntProp(client, Prop_Send, "m_iAccount", 800);
    SetEntProp(client, Prop_Send, "m_bHasHelmet", 0);
    SetEntProp(client, Prop_Send, "m_ArmorValue", 0);
} 


[Pavelas]

Thank you for your response, however money did not change next round on spawn.

[PinHeaDi]

Originally Posted by Pavelas Thank you for your response, however money did not change next round on spawn.

How about that:

PHP Code:

public void OnPluginStart() {
    HookEvent("player_spawn", Event_PlayerSpawn);
}

public Action Event_PlayerSpawn(Event event, const char[] name, bool dontBroadcast) {
    int client = GetClientOfUserId(event.GetInt("userid"));
    
    if (!IsValidClient(client))
        return;
    
    SetEntProp(client);
    RemoveWeapons(client);
}


public void RemoveWeapons(int client)
{
    Client_RemoveAllWeapons(client, "weapon_c4");
    if (GetClientTeam(client) == CS_TEAM_T) {
        GivePlayerItem(client, "weapon_knife_t");
        GivePlayerItem(client, "weapon_glock");
    }
    else if (GetClientTeam(client) == CS_TEAM_CT) {
        GivePlayerItem(client, "weapon_knife");
        GivePlayerItem(client, "weapon_hkp2000");
    }
}

public void SetEntProp(int client)
{
    CreateTimer(0.01, ResetPlayer, client, TIMER_FLAG_NO_MAPCHANGE);
    
    SetEntProp(client, Prop_Send, "m_bHasHelmet", 0);
    SetEntProp(client, Prop_Send, "m_ArmorValue", 0);
}

public Action ResetPlayer(Handle timer, int client) {
    SetEntProp(client, Prop_Send, "m_iAccount", 800); 
}  

stock bool IsValidClient(int client) { 
    return (1 <= client <= MaxClients && IsClientInGame(client)); 
} 


It has a time though.

[Pavelas]

Thank you very much for your help, however the solution was very stupid.

You need to have these CVAR's:

PHP Code:

mp_backup_round_file ""
mp_backup_round_file_last ""
mp_backup_round_file_pattern ""
mp_backup_round_auto "0" 


In this case we can reset player money and weapons directly on player_spawn hook.

However I think that that 2nd Problem still exists and somehow we need to write extra code to solve this problem.

[Neuro Toxin]

Originally Posted by Pavelas But in this case we will need to loop all players, is it good approach to use loops? Sorry for stupid question, in ECMAScript people are trying to avoid loops.

Yes. Looping players is fine. You need to move away from the player_spawn approach to resolve your issues.