[Alexunder]

Hello guys
I wrote this code , and i'll have 2-4 output record but when i call it server make a lag for 1 sec to all the plugins connect on mehthod remote database and other plugins like rankme dont have performance problem.
I think my codes are not optimal pls help

public Action:CommandNameFamily(client, args)
{
	new String:query[255];
	new String:name[32];
	new String:family[32];
	Format(query, sizeof(query), "select name,family from users");
	new Handle:queryH = SQL_Query(db, query);
	while (SQL_FetchRow(queryH)) {
	SQL_FetchString(queryH, 0, name, sizeof(name))
	SQL_FetchString(queryH, 1, family, sizeof(family))
	PrintToChat(client, "\x01 \x04[Test]\x01 %s %s", name, family);
	}
	CloseHandle(queryH);
}

[timtam95]

you're executing a synchronous query, that's why.

[CliptonHeist]

https://wiki.alliedmods.net/SQL_(Sou...ing)#Threading

[Drixevel]

For clarification, SQL_Query essentially pauses the server until the query is complete and sends the results back in a handle where using SQL_TQuery queries the database in the background with a thread so you should only use threaded queries wherever you can. (I've heard they're deprecating synchronous queries anyways)

[Alexunder]

Originally Posted by Drixevel For clarification, SQL_Query essentially pauses the server until the query is complete and sends the results back in a handle where using SQL_TQuery queries the database in the background with a thread so you should only use threaded queries wherever you can. (I've heard they're deprecating synchronous queries anyways)

hanks for informations , can you edit my code ?

[brunoronning]

Originally Posted by Alexunder hanks for informations , can you edit my code ?

Enjoy:

Spoiler

PHP Code:

public Action CommandNameFamily(int client, int args)
{
    char query[255];
    Format(query, sizeof(query), "select name,family from users");
    SQL_TQuery(db, SQLCallback_NameFamily, query, GetClientUserId(client));
}

public void SQLCallback_NameFamily(Handle owner, Handle hndl, const char[] error, any data)
{
    if (hndl == null || strlen(error) > 0) {
        LogError("(SQLCallback_NameFamily) Fail at Query: %s", error);
    }
    else
    {
        int client = GetClientOfUserId(data);

        while (SQL_FetchRow(hndl))
        {
            char name[32];
            char family[32];

            SQL_FetchString(hndl, 0, name, sizeof(name))
            SQL_FetchString(hndl, 1, family, sizeof(family))

            PrintToChat(client, "\x01 \x04[Test]\x01 %s %s", name, family);
        }
    }
}