[Peoples Army]

Ok well I have no idea what the problem here is

PHP Code:






/////////////////////////////////////////////////////////
/// 
///     This plugin will block shots from bots every 3rd shot and every headshot
///
///
/////////////////////////////////////////////////////////

#include <sourcemod>
#include <sdktools>



public Plugin:myinfo = 
{
    name = "Shot Block",
    author = "Peopels Army",
    description = "Blocks 3rd shot from bot & makes palyer nto die from headshot",
    version = "1.0",
    url = "www.sourcemod.net"
}

////////////////////////////////////////////////////////
///
///
///     Register convars & events 
///
///////////////////////////////////////////////////////


public OnPluginStart()
{
    CreateConVar("shot_block_on","1", "Turns the plugin on and off");
    CreateConVar("shot_block_count","3", "Sets how many shtos are needed by bots before there blocked");
    HookEvent("player_hurt",BlockHurt, EventHookMode_Pre);
}


//////////////////////////////////////////////////////////////
///
///     hook player hurt event and check if attacker is a bot 
///        then count hits and then give god mode if more then 2
///
//////////////////////////////////////////////////////////////////

public Action:BlockHurt(Handle: event, const String: name[], bool:dontBroadcast)
{
    new clientID = GetEventInt(event,"userid");
    new client = GetClientOfUserId(clientID);
    new attackerID = GetEventInt(event, "attacker");
    new attacker = GetClientOfUserId(attackerID);
    new hitGroup = GetEventInt(event, "hitgroup");
    new botShot;
    
    // if player is alive , plugin is on and was attacked by a bot
    if(GetConVarInt("shot_block_on") && IsFakeClient(attacker))
    {
        ++botShot;
        // if the shot count is larger then the amount convar or the hitgruop is headshot 
        if(botShot > GetConVarInt("shot_block_count") || hitGroup == 1)
        {
            SetEntProp(client, Prop_Data, "m_takedamage", 0 , 1);
            return 0;
        }
    }
} 


PHP Code:



SourcePawn Compiler 1.3.3
Copyright (c) 1997-2006, ITB CompuPhase, (C)2004-2008 AlliedModders, LLC

\sourcemod\sps\shot_block.sp(55) : error 035: argument type mismatch (argument 1)
\sourcemod\sps\shot_block.sp(59) : error 035: argument type mismatch (argument 1)
\sourcemod\sps\shot_block.sp(62) : warning 213: tag mismatch
\sourcemod\sps\shot_block.sp(65) : warning 209: function "BlockHurt" should return a value

2 Errors.

Compilation Time: 0.77 sec 


[Lboongon123]

Hey I get this kind of problems too... Have you solved them already?








Type of Service Agreements

[Scone]

GetConVarInt doesn't take a string, it takes the handle to a cvar. You need to save the handles of the two cvars you create, then use them in the calls to GetConVarInt.

You can also remove "return 0;" from the BlockHurt function, and replace it with a "return Plugin_Continue;" at the end.

[Peoples Army]

lol return 0 and return plugin continue are the same thing , return 0 is the enum number associated with return plugin continue

return 1 is return handled

theres no way to get a convar with out a handle?

[Scone]

I wasn't saying changing the return value would fix the warning - putting the return statement at the end of the function means that something is returned in all cases. I only suggested the change to "Plugin_Continue" for readability.

You can get a cvar's handle using a string (FindConVar), but seeing as you already have the handles (from CreateConVar), you should just save them in a pair of global variables.

[dirka_dirka]

instead of GetConVarInt("shot_block_count")
useGetConVarInt(FindConVar("shot_block_count"))

but that would only be worthwhile for a game convar that you need to access once.
this is one you created.. all you have to do is add a handle to it as scone says.

[Peoples Army]

and alocate memory for a handle that only gets used once kinda stupid

[Dr. Greg House]

You have to return a value in every case, so there has to be a return below the ifs at the end of your function.

[Scone]

Originally Posted by Peoples Army and alocate memory for a handle that only gets used once kinda stupid

A pair of handles consume 8 bytes of memory. The two strings "shot_block_count" and "shot_block_on" consume 31 bytes of memory together. In trying to save a lofty 8 bytes of RAM, you end up using nearly four times that much.

[Greyscale]

Not to mention these handles are already in memory. You're just looking it up based off a string.

The best method is to look up these handles in OnPluginStart and cache them. Then you can use them anytime in your plugin without doing work every time.