[meTaLiCroSS]

I think that I've searched many times and i haven't found it yet. So that's why I created my own way to execute a traceline with multiple hits until it hits a solid/wall.

Sometimes the process it just gets freezed, and I had to restart the process. While trying to check the code that caused this, I've suddenly saw that it was this.

My current code:

PHP Code:

#define SetBitsum(%1,%2)             %1 |= (1<<(%2 & 31))
#define IsBitsumSet(%1,%2)             (%1 & (1<<(%2 & 31)))

static Float:vecStart[3], Float:vecEnd[3]
// vecStart = eye position or entity center origin
// vecEnd = angle direction scaled to 9999

static iPlayers[32], iCount, iStartEnt, iTraceHit, bitsPlayerMask
arrayset(iPlayers, 0, 32)
iCount = 0
iStartEnt = iId // me, or any other entity
bitsPlayerMask = 0

while(engfunc(EngFunc_TraceLine, vecStart, vecEnd, DONT_IGNORE_MONSTERS, iStartEnt, 0) > 0) // will always return 1, see engfunc.cpp
{
    get_global_vector(GL_trace_endpos, vecStart)
    
    if(get_global_float(GL_trace_fraction) == 1.0)
        break;
        
    iTraceHit = get_global_edict(GL_trace_ent)
    
    if(!is_user_alive(iTraceHit)) // it supposes to stop here...
        break;
        
    iStartEnt = iTraceHit

    if(/* custom conditions, like checking team, is admin, etc etc etc */)
    {
        if(IsBitsumSet(bitsPlayerMask, iTraceHit))
        {
            log_to_file("tracebug.log", "bitsPlayerMask contains repeated player (HIT ID: %d - ENT ID: %d)", iTraceHit, iEnt)
        }
        else
        {
            iPlayers[iCount++] = iTraceHit
            SetBitsum(bitsPlayerMask, iTraceHit)
        }
    }
} 


One day a 1gb size file was created on the logs folder called tracebug.log, it had the same phrase repeated million of times, an user get stucked on the trace line execution, and I don't know why that happened.

Before calling IsBitsumSet to check if there're repeated players on the array, the iStartEnt var is set to iTraceHit value, and IT SUPPOSES to ignore that entity on the traceline execution.

I'm just defeated, wanted to ask if there's an efficient method to get multiple hits with a traceline, like how CS does with a bullet but until it hits a solid.

Thanks in advance

[Arkshine]

If you see it freezes, it means you got an infinite loop for some reason.

You should add a more concrete check, like after x count, it stops.

If you want to see what CS does, check FireBullets3() in combat.cpp ( from here )

[meTaLiCroSS]

Originally Posted by Arkshine If you see it freezes, it means you got an infinite loop for some reason.

I know that i've got an infinite loop, and that is what I was asking for, don't know why it continues looping

Originally Posted by Arkshine You should add a more concrete check, like after x count, it stops.

I thought on that before, but beside that, I wanted to know why it fails

Originally Posted by Arkshine If you want to see what CS does, check FireBullets3() in combat.cpp ( from here )

FireBullets3 does certain checks with distance, penetration power and range modifyiers, well, the unique condition that I applyed to this was to hit a wall. Don't know if anyone haves a code, or knows to fix it

[Arkshine]

The point is your conditions don't follow, it could happen since you got a freeze but I don't see the need to waste your time to to try to figure out the very specific situation ; just add an "obvious" check for safety, like allowing only x tracelines.
If you want still to understand the issue, just debug your code...

[meTaLiCroSS]

Originally Posted by Arkshine If you want still to understand the issue, just debug your code...

That's another problem, I don't know how to reproduce it haha it's something very specific, and it always happens when i'm not viewing it

[joropito]

If the map is not surrounded by walls you may hit the bug. Well is not a bug, your way to do that is buggy.

Try to add another check with PointContents to exit (SKY).

[meTaLiCroSS]

Originally Posted by joropito If the map is not surrounded by walls you may hit the bug. Well is not a bug, your way to do that is buggy. Try to add another check with PointContents to exit (SKY).

Will add a > 32 trace execution check, and the endposition pointcontent check that you said, hope that work anyway.

PD: I'm still having the doubt of why it hits the entity that i'm actually passing in the ignoreEnt param.

[a7811311622]

Sorry for my bad English...

You mean that you want to trace a line, if TR_pHit > 0, get it and penetrate it until hitting a wall?

[meTaLiCroSS]

Originally Posted by joropito Try to add another check with PointContents to exit (SKY).

Oh, also, i've noticed:

PHP Code:

    if(!is_user_alive(iTraceHit)) // it supposes to stop here... 
        break; 


So...?

Originally Posted by a7811311622 Sorry for my bad English... You mean that you want to trace a line, if TR_pHit > 0, get it and penetrate it until hitting a wall?

Not really pHit > 0, any solid entity, func_breakable entities are solid too.

[a7811311622]

Originally Posted by meTaLiCroSS Oh, also, i've noticed: PHP Code:     if(!is_user_alive(iTraceHit)) // it supposes to stop here...          break;  So...? Not really pHit > 0, any solid entity, func_breakable entities are solid too.

Another way to say it that trace a line if TR_pHit is the player, get it and penetrate it until hitting a solid entity which isn't the player?