[Help] point system - Page 2

hannes · 10-20-2014 , 03:09 Re: [Help] point system

Quote:

Originally Posted by zmd94

Please close your nVault.

PHP Code:


			
public plugin_end()
{
    nvault_close(g_vault)
}

Had to edit

Code:

public client_authorized( id )
{
    get_user_authid(id, g_iAuthID[ id ] , charsmax( g_iAuthID[] ) );
    LoadData(id)
}

Edit:
Now the code looks like this :

PHP Code:


			
/* Plugin generated by AMXX-Studio */

new const PLUGIN[] =    "Point"
new const VERSION[] =     "0.0.1"
new const AUTHOR[] =    "hannes"

#include <amxmodx>
#include <amxmisc>
#include <nvault>
#include <chatcolor>

new g_iAuthID[33][36]
new Points[33]
new XP_Kill
new XP_Knife
new XP_Hs
new g_vault


public plugin_init()
{
    register_plugin(PLUGIN, VERSION, AUTHOR);
 
    register_event("DeathMsg", "eDeath", "a") ;
    
    XP_Kill = register_cvar("XP_per_kill", "2");
    XP_Hs = register_cvar("XP_hs_bonus","2");
    XP_Knife = register_cvar("XP_knife_bonus","2");
    g_vault = nvault_open("point");
    
    register_clcmd("say /points", "SayPoints");
    register_clcmd("say_team /points", "SayPoints");
}

public eDeath(  ) 
{
    new attacker = read_data( 1 )
    new headshot = read_data( 3 )
    new clip, ammo, weapon = get_user_weapon(attacker,clip,ammo);
 
    Points[attacker] += get_pcvar_num(XP_Kill)
 
    if(headshot)
    Points[attacker] += get_pcvar_num(XP_Hs)
 
    if(weapon == CSW_KNIFE)
    Points[attacker] += get_pcvar_num(XP_Knife)
 
    SaveData(attacker)
}

public plugin_end()
{
    nvault_close(g_vault)
}

public SayPoints(id)
{
    ColorChat(id, GREY, "^4*^3 You have ^4%d^3 Points -^3 [^4v%s^3]" , Points[id] , VERSION );
}

public client_authorized( id )
{
    get_user_authid(id, g_iAuthID[ id ] , charsmax( g_iAuthID[] ) );
    LoadData(id)
}

public client_disconnect(id)
{
    SaveData(id)
}

public SaveData(id)
{
    new AuthID[35]
    get_user_authid(id,AuthID,34)

    new vaultkey[64]
    new vaultdata[256]

    format(vaultkey,63,"%s-Mod",AuthID)
    format(vaultdata,255,"%i#",Points[id])

    nvault_set( g_vault , vaultkey , vaultdata );
    return PLUGIN_CONTINUE
}

public LoadData(id)
{
    new AuthID[35]
    get_user_authid(id,AuthID,34)
 
    new vaultkey[64],vaultdata[256]
    format(vaultkey,63,"%s-Mod",AuthID)
    format(vaultdata,255,"%i#",Points[id])
    nvault_get(g_vault,vaultkey,vaultdata,255)
 
    replace_all(vaultdata, 255, "#", " ")
 
    new points[32]
 
    parse(vaultdata, points, 31)
 
    Points[id] = str_to_num(points)
 
    return PLUGIN_CONTINUE
}

Should i change anything? or isit good like this?
thanks!

zmd94 · 10-20-2014 , 03:53 Re: [Help] point system

You can add this code in the plugin_init():

PHP Code:


			
    if(g_vault == INVALID_HANDLE)
        set_fail_state("Error opening nVault")

So that, it will throw a plugin error if INVALID_HANDLE is returned.

Lastly, please get used to use charsmax or sizeof - 1 instead of writing the number.

hannes · 10-20-2014 , 04:13 Re: [Help] point system

Quote:

Originally Posted by zmd94

You can add this code in the plugin_init():

PHP Code:


			
    if(g_vault == INVALID_HANDLE)
        set_fail_state("Error opening nVault")

So that, it will throw a plugin error if INVALID_HANDLE is returned.

Lastly, please get used to use charsmax or sizeof - 1 instead of writing the number.

Thanks, one more thing... how can i save & load users kills?

As you see im kinda new to amxx.
If you don't wanna help me more im fine, thanks for your help

zmd94 · 10-20-2014 , 04:37 Re: [Help] point system

Sorry, what do you mean by users kills?

By the way, you have already saved the data with this code:

PHP Code:


			
public client_disconnect(id)
{
    SaveData(id)
}

Next, I don't think this code is necessary:

PHP Code:


			
SaveData(attacker)

hannes · 10-20-2014 , 05:01 Re: [Help] point system

Quote:

Originally Posted by zmd94

Sorry, what do you mean by users kills?

By the way, you have already saved the data with this code:

PHP Code:


			
public client_disconnect(id)
{
    SaveData(id)
}

Next, I don't think this code is necessary:

PHP Code:


			
SaveData(attacker)

Okay thanks again ^^,
By users kill i mean that i save his total kills so i can print it like "* You have 34 Points and 23 Total kills"

zmd94 · 10-20-2014 , 05:25 Re: [Help] point system

For total kills, you can just use "get_user_frag(id)".

hannes · 10-20-2014 , 06:30 Re: [Help] point system

Quote:

Originally Posted by zmd94

For total kills, you can just use "get_user_frag(id)". By the way, just add this to your plugin_end():

PHP Code:


			
public plugin_end()
{
    new iPlayers[32], iNum
    get_players(iPlayers, iNum)
    
    new iPlayer
    for(new i = 0; i < iNum; i++)
    {
        iPlayer = iPlayers[i]
        
        SaveData(iPlayer)
    }
    
    nvault_close(g_vault)
}

How could i do this better?

Warning: Loose indentation on line 62
1 Warning.

PHP Code:


			
/* Plugin generated by AMXX-Studio */

new const PLUGIN[] =    "Point"
new const VERSION[] =     "0.0.1"
new const AUTHOR[] =    "hannes"

#include <amxmodx>
#include <amxmisc>
#include <nvault>
#include <cstrike>
#include <fun>
#include <chatcolor>

new g_iAuthID[33][36]
new Points[33]

new XP_Kill
new XP_Knife
new XP_Hs
new g_vault

new iFrags[33]
new iDeaths[33]

public plugin_init()
{
    register_plugin(PLUGIN, VERSION, AUTHOR);
 
    register_event("DeathMsg", "eDeath", "a") ;
    
    XP_Kill = register_cvar("XP_per_kill", "1");
    XP_Hs = register_cvar("XP_hs_bonus","1");
    XP_Knife = register_cvar("XP_knife_bonus","1");
    
    register_clcmd("say /points", "SayPoints");
    register_clcmd("say_team /points", "SayPoints");
    register_clcmd("say /d" ,"Sayd");
    
    g_vault = nvault_open("point");
    
    if(g_vault == INVALID_HANDLE)
        set_fail_state("Error opening nVault");
}

public eDeath(  ) 
{
    new attacker = read_data( 1 )
    new victim = read_data( 2 )
    new headshot = read_data( 3 )
    new clip, ammo, weapon = get_user_weapon(attacker,clip,ammo);
 
    
 
    Points[attacker] += get_pcvar_num(XP_Kill)
 
    if(headshot)
    Points[attacker] += get_pcvar_num(XP_Hs)
 
    if(weapon == CSW_KNIFE)
    Points[attacker] += get_pcvar_num(XP_Knife) 
    
    if(cs_get_user_team(attacker) != cs_get_user_team(victim)) {
        iFrags[attacker]++
        iDeaths[victim]++
    }
}

public plugin_end()
{
    new iPlayers[32], iNum
    get_players(iPlayers, iNum)
    
    new iPlayer
    for(new i = 0; i < iNum; i++)
    {
        iPlayer = iPlayers[i]
        
        SaveData(iPlayer)
    }
    
    nvault_close(g_vault)
}  

public SayPoints(id)
{
    ColorChat(id, GREY, "^4*^3 You have ^4%d^3 Points -^3 [^4v%s^3]" , Points[id] , VERSION );
}

public client_authorized( id )
{
    get_user_authid(id, g_iAuthID[ id ] , charsmax( g_iAuthID[] ) );
    LoadData(id);
}

public client_disconnect(id)
{
    SaveData(id);
}

public SaveData(id)
{
    new AuthID[35]; get_user_authid(id, AuthID, charsmax(AuthID))

    new vaultkey[64]
    new vaultdata[256]

    format(vaultkey, charsmax(vaultkey),"%s-Mod",AuthID)
    format(vaultdata, charsmax(vaultdata),"%i#%i#",Points[id], iFrags[id])
    
    nvault_set( g_vault , vaultkey , vaultdata );
    return PLUGIN_CONTINUE
}

public LoadData(id)
{
    new AuthID[35]; get_user_authid(id, AuthID, charsmax(AuthID))
    new vaultkey[64],vaultdata[256]
    
    format(vaultkey,charsmax(vaultkey),"%s-Mod",AuthID)
    format(vaultdata,charsmax(vaultdata),"%i#%i#",Points[id], iFrags[id])
    nvault_get(g_vault,vaultkey,vaultdata,charsmax(vaultdata))
    replace_all(vaultdata, charsmax(vaultdata), "#", " ")
    new points[32],Frags[33], Deaths[33]
    parse(vaultdata, points, charsmax(points), Frags, charsmax(Frags), Deaths, charsmax(Deaths))
    Points[id] = str_to_num(points)
    iFrags[id] = str_to_num(Frags)
    iDeaths[id] = str_to_num(Deaths)
    return PLUGIN_CONTINUE
}


public Sayd(id)
{
    ColorChat(id, GREY, "^4*^3 You have ^4%d^3 Points & %d Kills & %d Deaths -^3 [^4v%s^3]" , Points[id] , iFrags[id] , iDeaths[id] , VERSION );
}

**HamletEagle** · 10-21-2014 , 10:03 Re: [Help] point system

@hannes, lear how to search. Loose indentation warning is harmless, it just tells you that your code is not properly "arranged".
@zmd94 , why saving points on plugin_end ? It's enough to save when a player disconnect.

zmd94 · 10-21-2014 , 10:17 Re: [Help] point system

If it is just enough to save when a player disconnect, then it is my mistake. ;)

Chihuahuax · 10-21-2014 , 10:23 Re: [Help] point system

Quote:

Originally Posted by HamletEagle

@hannes, lear how to search. Loose indentation warning is harmless, it just tells you that your code is not properly "arranged".
@zmd94 , why saving points on plugin_end ? It's enough to save when a player disconnect.

At least there's no error xP