Quote:
Originally Posted by Jhob94
The defines are making no sense.
|
We've kept the (#define joiner) and the (#define quitter) because we are currently making a research to use them soon in the next plugin update.
Quote:
Originally Posted by Jhob94
Making a define to get cvar value is just senseless, harder to read and will confuse inexperienced programmers.
|
We are not creating the
num #define to get a cvar value, it is just a string replacement for making the code narrow and faster to read.
It is simply a shortened way of writing
get_pcvar_num, which is a code styling case.
The definition of
num is already there, the programmer will see it in the beginning of the code.
We've not added a comment about this in front of the #define because this will cause a error.
Quote:
Originally Posted by Jhob94
The operation could be much cheaper if you defined on ham_spawn what the players can see.
|
The
StatusText event/message is the right place for this purpose: it is called in the moment the print occurs.
With
ham_spawn, a cvar change will take effect only in a new spawn, which will be horrible to make a test.
As an additional note, using a
pdata to remove the print in the spawn moment is a low call frequency case.
We prefer something being applied faster.
What we could do is to make the two versions of the plugin.
--
__________________