[joshknifer]

Hey all,

Trying to help somebody in the request and got a 209 return error. I have a return plugin_handled in there but is it in the incorrect place? I am still pretty new to scripting.

PHP Code:

 #include < amxmodx > 
#include < amxmisc > 
#include < cstrike > 

public plugin_init( ) { 
    register_plugin( "All to Spec", "1.0", "joshknifer" ); 
     
    register_concmd( "amx_allspec", "CmdAllSpec", ADMIN_KICK ); 
} 

public CmdAllSpec( id, iLevel, iCid ) { 
    if( !cmd_access( id, iLevel, iCid, 1 ) ) 
        return PLUGIN_HANDLED; 
     
    new iPlayers[ 32 ], iNum; 
    get_players( iPlayers, iNum ); 
     
    for( new i; i < iNum; i++ ) { 
        id = iPlayers[ i ]; 
        cs_set_user_team(id, CS_TEAM_SPECTATOR);    //Set team
        user_kill(id, 1); // Kill user
        cs_set_user_deaths(id, get_user_deaths(id) - 1)    // user_kill adds 1 to deaths, recalc it if you want.  
        
}  
return PLUGIN_HANDLED;
} 


[fysiks]

I thought you were not able to change player teams in a for loop. I think there is a thread in the Code Snippets/Tutorials about changing teams for everybody.

Also, if you are going to post about an error, post the error output (all of it).

[joshknifer]

Originally Posted by fysiks I thought you were not able to change player teams in a for loop. I think there is a thread in the Code Snippets/Tutorials about changing teams for everybody. Also, if you are going to post about an error, post the error output (all of it).

Not sure about that first part but I will search for that thread. If there is a more efficient method let me know for sure.
Edit: Found this where Claud uses a switch, but there are not multiple teams and it is still with in a for loop. Let me know if you find the one you were talking about. All the examples I found are within a for loop.

Here are the details:

Welcome to the AMX Mod X 1.8.1-300 Compiler.
Copyright (c) 1997-2006 ITB CompuPhase, AMX Mod X Team

/tmp/textTJPBWN.sma(26) : warning 209: function "CmdAllSpec" should return a value
Header size:            424 bytes
Code size:             1648 bytes
Data size:              336 bytes
Stack/heap size:      16384 bytes; estimated max. usage=781 cells (3124 bytes)
Total requirements:   18792 bytes

1 Warning.
Done.

[fysiks]

. . . a "warning" is not an error. The warning is saying that if you return a value explicitly in any part of the function, you must then make sure to return a value explicitly for every possible execution of the code. This usually requires returning at the end of the function but it can also be an indication of a bad formulation for the function.

Also, I just noticed that you are returning inside the loop so it will stop the function after the first execution of the loop.

[joshknifer]

Originally Posted by fysiks . . . a "warning" is not an error. The warning is saying that if you return a value explicitly in any part of the function, you must then make sure to return a value explicitly for every possible execution of the code. This usually requires returning at the end of the function but it can also be an indication of a bad formulation for the function. Also, I just noticed that you are returning inside the loop so it will stop the function after the first execution of the loop.

Ahh that was it! Moving the return fixed the warning. (edited above) Good catch.