#define results in undefined symbol

xerox8521 · **Author**

Hi,

for some reason a #define results in a undefined symbol "CHANGE_FLAGS" error. Which is weird as is its based upon this code: https://github.com/ValveSoftware/sou...hared.cpp#L175

PHP Code:


			
#define CHANGE_FLAGS(flags,newFlags) (flags = (newFlags))

Used in a function like this.

PHP Code:


			
stock void AddTankImmunityFlag(int tank, int flags)
{
    CHANGE_FLAGS( TankInfo[tank][tImmunity], TankInfo[tank][tImmunity] | flags );
}

SM Compiler Version: 1.8.0.6041

asherkin · 06-13-2018 , 10:39 Re: #define results in undefined symbol

SourcePawn is not C++, the syntax is completely wrong, and function macros are deprecated.

The correct SourcePawn syntax is something like this:

Code:

#define CHANGE_FLAGS(%1,%2) (%1 = (%2))

The correct way to do helper functions is to write real functions:

Code:

stock void CHANGE_FLAGS(int &flags, int newFlags) {
    flags = newFlags;
}

But... why not just write that one line of code rather than obfuscating it behind a "helper"?

xerox8521 · 06-13-2018 , 10:50 Re: #define results in undefined symbol

Right in pawn its (%1,%2) completly forgot that. Thanks.

Took the sdk code as is without much more looking or thinking about it.