[Neuro Toxin]

I just created a new branch and implemented a patch based on KyleS's advice along with asherkin's confirmation.

The branch is not yet tested and might have a bug or two.

The changes are here.

[KyleS]

Originally Posted by Neuro Toxin I just created a new branch and implemented a patch based on KyleS's advice along with asherkin's confirmation. The branch is not yet tested and might have a bug or two. The changes are here.

If you really want to go that route, the __Public_Func() has to be in your include, and will force a recompilation.

[Neuro Toxin]

I dont exactly follow what you saying.

[WildCard65]

Originally Posted by Neuro Toxin I dont exactly follow what you saying.

Add to forward requires a public function from the plugin's who handle you supplied, what your doing will result in undefined behavior or a native error.

[Neuro Toxin]

Ok. Understood.

So just move the function I use to dynamic include.

I dont need to typedef do I?

[WildCard65]

Originally Posted by Neuro Toxin Ok. Understood. So just move the function I use to dynamic include. I dont need to typedef do I?

No, you don't need a typedef, you just need a public function definition (try using a name that you believe NO ONE will use).

How public functions work:
Any function with the "public" key (pre-1. get an entry into a section called ".publics" in the ".smx", this entry exposes 2 things):
1) The offset into the plugin's runtime memory where SP can find it's name.
2) The offset into the plugin's runtime memory where the function execution begins.

spcomp handles the "Function" tag by taking the function given and returning it's index in the publics section (an array index).

SourcePawn retrieves the function through the index of it's entry in the publics section.

[Neuro Toxin]

That's good knowledge. Thanking you.

So the main include now has:

public void _Dynamic_Plugins_PrivateFowardCallback()
{
	return;
}

And I use this to register the forward.

	// Create forward and add plugin handle
	Handle pluginforward = CreateForward(ET_Ignore);
	AddToForward(pluginforward, plugin, _Dynamic_Plugins_PrivateFowardCallback);

A compile version is in the branch - changes

[Neuro Toxin]

Originally Posted by KyleS If you really want to go that route, the __Public_Func() has to be in your include, and will force a recompilation.

Probably wont merge this fix due to plugins using Dynamic needing a recompile.

[WildCard65]

Originally Posted by Neuro Toxin That's good knowledge. Thanking you. So the main include now has: public void _Dynamic_Plugins_PrivateFowardCallback() { return; } And I use this to register the forward. // Create forward and add plugin handle Handle pluginforward = CreateForward(ET_Ignore); AddToForward(pluginforward, plugin, _Dynamic_Plugins_PrivateFowardCallback); A compile version is in the branch - changes

You need to pass the return value of "FindFunctionByName" as you need the function id (array index of entry into ".publics") of the function from the plugin your working with.

[asherkin]

Theoretically you could just always pass 0 as the function id to add whatever the plugin's first public is, avoiding the need to recompile plugins - the forward will never be called anyway.