[live4net]

Hi
I'm trying to write a plugin that turns off the damage from drowning. That code does not work. Does anyone have an idea how to fix it?

public OnClientPutInServer(client)
{
   SDKHook(client, SDKHook_WeaponCanUse, OnWeaponCanUse);
   SDKHook(client, SDKHook_TraceAttack, TraceAttack);
}

public Action:TraceAttack(victim, &attacker, &inflictor, &Float:damage, &damagetype, &ammotype, hitbox, hitgroup)
{
if (damagetype == DMG_DROWN || damagetype == DMG_DROWNRECOVER)
   {
       damage = 0.0;
   }
   return Plugin_Continue;
}

[maningrey]

Heres a thread that answers your question

https://forums.alliedmods.net/showthread.php?t=70545

[maningrey]

Oh sorry thats amx, always gets me.

#include <sourcemod>
#include <sdkhooks>

public OnClientPutInServer(client)
{
    SDKHook(client, SDKHook_OnTakeDamage, OnTakeDamage);
}

public Action:OnTakeDamage(victim, &attacker, &inflictor, &Float:damage, &damagetype)
{
	if (damagetype == DMG_DROWN || damagetype == DMG_DROWNRECOVER)
	{
		damage = 0.0;
	}
	
	return Plugin_Changed;
}

[Darkness_]

You need to return Plugin_Changed if you modify the damage.

[Powerlord]

damagetype is a bitfield...

PHP Code:

if (damagetype & (DMG_DROWN | DMG_DROWNRECOVER) > 0)
{
    damage = 0.0
    return Plugin_Changed;
} 


Edit: Added parentheses to make sure order of execution is correct.

[Miu]

I can't imagine how it'd have DMG_DROWN and something else at the same time

[Powerlord]

Originally Posted by Miu I can't imagine how it'd have DMG_DROWN and something else at the same time

*eyes DMG_ACID*

...and that's not even considering DMG_PREVENT_PHYSICS_FORCE, DMG_NEVERGIB, or DMG_REMOVENORAGDOLL.

Incidentally, if you don't like the > 0, you could also put it as != DMG_GENERIC instead.

[Miu]

Originally Posted by Powerlord *eyes DMG_ACID* ...and that's not even considering DMG_PREVENT_PHYSICS_FORCE, DMG_NEVERGIB, or DMG_REMOVENORAGDOLL.

okay, point taken, didn't notice those XD

Incidentally, if you don't like the > 0, you could also put it as != DMG_GENERIC instead.

or you could remove it altogether and it'd be shorter and make more sense edit: and work on the highest flag!