[jamalsheref2]

This plugin still broken I put spawn timers at 30 - 25 sec and they still sometimes spawn early

[Mi.Cura]

Originally Posted by jamalsheref2 This plugin still broken I put spawn timers at 30 - 25 sec and they still sometimes spawn early

I think this only starts when you have 5 players or more on the server.
In the same way to add + special Infected, zombies... starts from 5 players
But I'm not sure.

[jamalsheref2]

Originally Posted by Mi.Cura I think this only starts when you have 5 players or more on the server. In the same way to add + special Infected, zombies... starts from 5 players But I'm not sure.

its not a 5 players or more match its just a 4v4 l4d1 versus pub game an I'm using this plugin for that and its still unbalance because of the bugs it still has

[Mi.Cura]

Well I don't use versus mode on my servers.
I also don't understand why this plugin was adapted for versus as well.

[jamalsheref2]

Originally Posted by Mi.Cura Well I don't use versus mode on my servers. I also don't understand why this plugin was adapted for versus as well.

Because there are people that still plays vs?

[Mi.Cura]

Originally Posted by jamalsheref2 Because there are people that still plays vs?

That's not what I meant, I know there are people who play versus.
I just said that this plugin has problems in versus mode, as reported here.

But I don't see reports of Coop mode...

Simple...

[ZBzibing]

l4d_infectedbots_tank_spawn_probability "5","When each time spawn S.I., how much percent of chance to spawn tank"

I've always thought it was inaccurate here and here.

GetRandomInt(1, 100) <= g_iSpawnTankProbability) 
modify
GetRandomInt(1, 100) >= g_iSpawnTankProbability)

I think it's more accurate to correct for less than

[HarryPotter]

Originally Posted by ZBzibing l4d_infectedbots_tank_spawn_probability "5","When each time spawn S.I., how much percent of chance to spawn tank" GetRandomInt(1, 100) <= g_iSpawnTankProbability) modify GetRandomInt(1, 100) >= g_iSpawnTankProbability)

Logic dead...

[Psyk0tik]

Originally Posted by ZBzibing l4d_infectedbots_tank_spawn_probability "5","When each time spawn S.I., how much percent of chance to spawn tank" I've always thought it was inaccurate here and here. GetRandomInt(1, 100) <= g_iSpawnTankProbability) modify GetRandomInt(1, 100) >= g_iSpawnTankProbability) I think it's more accurate to correct for less than

It does not make sense to check if the RNG is greater than the set probability because you will increase its chances. The 5% chance will become 95% if you use ">=" instead of "<=" here. The goal is to get a number that is less than or equal to 5. We want the Tank to have a low chance of spawning.

@HarryPotter I noticed some redundancy in this code block:

PHP Code:

if  (g_bL4D2Version)
{
    if ( ( (g_bFinaleStarted && g_bTankSpawnFinal == true) || !g_bFinaleStarted ) &&
        g_iSpawnCounts[SI_TANK] < g_iTankLimit &&
        GetRandomInt(1, 100) <= g_iSpawnTankProbability) 
    {
        return 7;
    }
    else //spawn other S.I.
    {
        int generate;
        for(int i = 1; i <= 3; i++)
        {
            generate = GenerateIndex()+1;
            if(generate > 0) break;
        }

        return generate;
    }
}
else
{
    if ( ( (g_bFinaleStarted && g_bTankSpawnFinal == true) || !g_bFinaleStarted ) &&
        g_iSpawnCounts[SI_TANK] < g_iTankLimit &&
        GetRandomInt(1, 100) <= g_iSpawnTankProbability) 
    {
        return 7;
    }
    else
    {
        int generate;
        for(int i = 1; i <= 3; i++)
        {
            generate = GenerateIndex()+1;
            if(generate > 0) break;
        }

        return generate;
    }
} 


In both versions of the game, the same logic is being executed. If this is intentional, I suggest removing the game check for this code block. Lines 3696-3735 on Github.

[HarryPotter]

Originally Posted by Psyk0tik @HarryPotter I noticed some redundancy in this code block: In both versions of the game, the same logic is being executed. If this is intentional, I suggest removing the game check for this code block. Lines 3696-3735 on Github.

Thank you