[shanapu]

hi,
i'm not familar with sourcepawn, i couldnd write a plugin from scratch. but i know how to read & edit sourcecodes. i read many sources recently and found 3 different ways to trigger/read a chat command.
What are the pros and contras of these ways to handle a chat command?

thanks in advance

shanapu

public OnPluginStart()
{
	
	RegConsoleCmd("sm_test1", TestOn);
	
}

public Action:TestOn(client, args)
{
	PrintToChatAll("Hello world")
}

public OnPluginStart()
{
	
	HookEvent("player_say", PlayerSay);
	
}


public PlayerSay(Handle:event, String:name[], bool:dontBroadcast)
{
	
	decl String:text[256];
	GetEventString(event, "text", text, sizeof(text));
	if (StrEqual(text, "!test2"))
	{
		PrintToChatAll("Hello world")
	}
}

public OnPluginStart()
{
	
	AddCommandListener(Event_Say, "say");
	AddCommandListener(Event_Say, "say_team");
	
}

public Action:Event_Say(clientIndex, const String:command[], arg)
{
	static String:menuTriggers[][] = { "!test3" };
	
	decl String:text[24];
	GetCmdArgString(text, sizeof(text));
	StripQuotes(text);
	TrimString(text);
	
	for(new i = 0; i < sizeof(menuTriggers); i++)
		{
			if (StrEqual(text, menuTriggers[i], false))
			{
				PrintToChatAll("Hello world")
			}
		}
}

[ddhoward]

Unless you have a special reason not to (like the command already exists, and you're trying to block it with another plugin), you pretty much always want to use the Reg*Cmd natives to create commands. In addition to being simple and pretty much handled by Sourcemod itself, it also allows use of simple overrides.

Another advantage is that it supports the changing of the triggers without needing to edit the plugin. For example, some servers might set their silent trigger, which is / on most servers, to be something weird like \ or even $. Similarly, the non-silent trigger can also be changed.

[shanapu]

Originally Posted by ddhoward Unless you have a special reason not to (like the command already exists, and you're trying to block it with another plugin), ...

What are other special reasons? and what the advantage of using Method 2 & 3?

I understand the advantage of RegConsoleCmd but why i see "so many" plugins doesnt use regconsolecmd? cant explain it with cmd exist.

[ddhoward]

There is pretty much no reason to use method 2, ever.

Method 3 is only useful if the command already exists and you're trying to hook it, or you, for some reason, don't want to "register" an actual command.

Method 1 is the only sane option.

[blaacky]

I'd say only ever use method 2 or 3 if you ever have a reason to unregister a command. Because you can't remove commands that have been registered via RegConsoleCmd

[shanapu]

Originally Posted by ddhoward ... or you, for some reason, don't want to "register" an actual command...

Originally Posted by blaacky ... if you ever have a reason to unregister a command. Because you can't remove commands that have been registered via RegConsoleCmd

What could be a reasons you want a unregistered cmd? im not fully through it.

[blaacky]

I've had to unregister commands before because in a large plugin I made some commands are created through a config file. If the server owner changes the words in the config file then it needs different commands then before, so I use something like method 3

[Neuro Toxin]

Ive hit this deregistering issue for similar reasons.

I worked around this by registering all my commands to one callback for processing.

When a command is no longer used i just ignore it.

[ddhoward]

http://ddhoward.bitbucket.org/script...alidClient.inc
http://ddhoward.bitbucket.org/script...rd_updater.inc

In these includes, which I made, exist "commands" which must be shared between all plugins that utilize the include. AddCommandListener seems more appropriate in this case. Further, the use of AddCommandListener causes the "command" to not appear in sm_searchcmd or sm_help, preventing cluttering up these lists.

[shanapu]

thanks for your feedback guys!