Raised This Month: $248 Target: $400
 62% 

Entity Resources Replacement[ V 1.4 ]


Post New Thread Reply   
 
Thread Tools Display Modes
Jhob94
AMX Mod X Donor
Join Date: Jul 2012
Location: Portugal
Old 10-22-2014 , 13:09   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #21

nice, really nice. Btw you could tell us wich sprites it can replace. For example i heard that radar sprite is impossible to replace so you should make a list. But very nice, i start liking and considering to use this plugin
__________________
Jhob94 is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 10-22-2014 , 13:50   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #22

Attachement removed, just spotted some dumb mistakes into the source, I will upload it when they are fixed.

Edit: fixed.
__________________

Last edited by HamletEagle; 10-22-2014 at 13:52.
HamletEagle is offline
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 10-22-2014 , 13:58   Re: Weapons Resources Replacement[ OKAPI ]
Reply With Quote #23

Quote:
Originally Posted by HamletEagle View Post
I'm sure you still have a lot of suggestions.
Of course, like:
  • You did not care to test properly your code before releasing it. Like the first okapi_mod_replace_string which is out of loop... (EDIT: looking at your previous post, you probably fixed that)
  • You use 2 copy... but why not using directly arrayData in parse?
  • I'm not sure why you check for .mdl / .spr ; this doesn't seem useful.
  • Well, about sound/, I told you have 2 ways, but honestly this makes more sense and is more consistent that user has to add sound/ in config file, like he has to add models/ and /sprites. This also simplify your code.
  • You should rewrite your description in first post. This is kind of incomplete, not really clear, with some pointless sentences. You should also clearly list the pros and cons of your plugin (for example pros: you have probably work for all mods, the most efficient method, can replace any entity resources ; and cons: probably the limit about length which could be a pain, global (can't be done per-player, etc.), possible incompatibility with plugins which check the original model name, etc.). This is important to an admin to understand at first glance whether this plugin is suitable for their needs. So please take time to properly elaborate your plugin description.
__________________

Last edited by Arkshine; 10-22-2014 at 14:00.
Arkshine is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 10-22-2014 , 14:34   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #24

Done. I've added a second array with only the string that were replaced for unpathMemory function, to avoid making the same checks as in pathMemory. The topic will be rewrited tomorow.
__________________

Last edited by HamletEagle; 10-22-2014 at 14:35.
HamletEagle is offline
ANTICHRISTUS
kingdom of weird stuff
Join Date: Jun 2010
Location: My kingdom is not in thi
Old 10-22-2014 , 15:32   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #25

you edited your plugin's name ? so basically it's no longer a replacement of the Weapon Model Replacement but a replacement of the Content Replacer one. right ?

my advice is to make separate plugins, and to use easy topic names (to search for/remember them easily).
__________________
ANTICHRISTUS is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 10-22-2014 , 15:39   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #26

Quote:
Originally Posted by ANTICHRISTUS View Post
you edited your plugin's name ? so basically it's no longer a replacement of the Weapon Model Replacement but a replacement of the Content Replacer one. right ?

my advice is to make separate plugins, and to use easy topic names (to search for/remember them easily).
It's a replacement for both of them There is no point in having different plugins, this one can to the same job
__________________

Last edited by HamletEagle; 10-22-2014 at 15:39.
HamletEagle is offline
yokomo
Surprise Ascot!
Join Date: May 2010
Old 10-23-2014 , 01:58   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #27

Actually just put "String Replacement" in your thread tittle, it just change string.

This replacement is for global. The plugin from GHW is better because you can replace string > original. I believe every community has it own sound/models/sprites folder, and of course they want use their own path (sound/picollo/mysound.wav). Your plugin is limited and i don't think this is useful. You can do with Opheu too, see http://forums.alliedmods.net/showthread.php?t=117930

Very simple right.
__________________
Hi, 7 years ago i run nosteam servers and i support nosteam community. So please ban me. Thank you legitmodders.

Last edited by yokomo; 10-23-2014 at 01:59.
yokomo is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 10-23-2014 , 09:23   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #28

Quote:
Originally Posted by yokomo View Post
Actually just put "String Replacement" in your thread tittle, it just change string.

This replacement is for global. The plugin from GHW is better because you can replace string > original. I believe every community has it own sound/models/sprites folder, and of course they want use their own path (sound/picollo/mysound.wav). Your plugin is limited and i don't think this is useful. You can do with Opheu too, see http://forums.alliedmods.net/showthread.php?t=117930

Very simple right.
Some users may not know what a string is, the current name is just fine. How could you say what GHW's is better ? Speacking about restrictions, yes, his one doesn't has many restriction, but considering his code it's very inneficient, using old file natives, using currentweapon and so on. I know it can be done with orpheu, but why creating a signature when with okapi I need just one line ? If the sound has not a plugin that's using it you can short it's name, this is no problem, and if it has already one what's the point in using my plugin ? So, this is not a problem. Of course, you can consider it's useless, but this won't stop me from updating this.
__________________
HamletEagle is offline
Old 10-23-2014, 09:57
Jhob94
This message has been deleted by Jhob94. Reason: Off-Topic
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 10-23-2014 , 10:26   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #29

Same for you, is there a specific reason you're ranting and raving about this?
But I agree that this plugin should not be considerated as a total replacement of existing plugins.
Both plugins have its pros and cons. That's why description should be more clear about it. It's fine to have both way.
__________________

Last edited by Arkshine; 10-23-2014 at 10:39.
Arkshine is offline
Old 10-23-2014, 10:47
Jhob94
This message has been deleted by Jhob94. Reason: Off-Topic
Old 10-23-2014, 11:17
HamletEagle
This message has been deleted by HamletEagle.
Old 10-23-2014, 12:12
Jhob94
This message has been deleted by Jhob94. Reason: Off-Topic
Old 10-23-2014, 12:14
HamletEagle
This message has been deleted by HamletEagle.
Old 10-23-2014, 13:07
Jhob94
This message has been deleted by Jhob94. Reason: Off-Topic
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 10-23-2014 , 13:25   Re: Entity Resources Replacement[ OKAPI ]
Reply With Quote #30

Updated to 0.5, this brings some code improvements and some mistakes fixed.
__________________

Last edited by HamletEagle; 10-23-2014 at 14:37.
HamletEagle is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 16:32.


Powered by vBulletin®
Copyright ©2000 - 2020, vBulletin Solutions, Inc.
Theme made by Freecode