mysql / php thing - Page 2

shauli · 08-14-2018 , 17:14 Re: mysql / php thing

Quote:

Originally Posted by JocAnis

i think i understood what you said, but as i said, with that code, chrome is showing me everything with no problems, but in-game it wont show the same...what code should i post?

is this enough:

Code:

<?php
$con=mysqli_connect("localhost","root","","statistic");
$map_name = $_GET['map'];
$sql="SELECT name, time, date FROM rezultati JOIN players ON players .id=rezultati.id WHERE map=$map_name AND time ORDER BY time ASC LIMIT 15 ";
$records=mysqli_query($con,$sql);
?>
<html>
...style, table code...

<?php
while($st=mysqli_fetch_assoc($records))
{
$i=1;
echo "<tr align=center >";
echo "<td>".$i."</td>";
echo "<td>".$st['name']."</td>";
 echo "<td >".$st['time']."</td>";
  echo "<td>".substr($dr['date'], 0, -8)."</td>";
echo "</tr>";
$i=$i++;
}
?>
</table>
</head>
</body>
</html>

the site is like from above: blablabla.com/recs.php?map=dd2

Are you sure you're on the right address in the in-game MOTD? Right click the MOTD and select "Copy Link Address" and then past it on Chrome to make sure it's the right address. Maybe you forgot to add "?map=mapname" in your plugin.

klippy · 08-14-2018 , 17:18 Re: mysql / php thing

In your previous posts the error contained mysql_fetch_array yet there isn't a single call of that function in the provided code. Stop omitting important parts.
If you are passing $records to that function call as well it may be happen that $records is FALSE because the query failed. Read the documentation and check for possible errors.
Also don't just plainly assign user-provided data to a query, your code is an easy target for SQL Injection as is. Use prepared statements.

JocAnis · 08-14-2018 , 19:21 Re: mysql / php thing

@shauli, thanks for trying to help. i figuried out what was the problem and you reminded me to look at that part...its in the sma...
was:

Code:

http://localhost/recs.php?map==%s

now its working (so anyone if has the same prob lul)

Code:

http://localhost/recs.php?map=%s

and im very happy it is working...and its interesting, i drunk fixed it, but sober couldnt lol

@klipica, sry, i couldnt copy ingame error so maybe i wrote it bad...instead of mysql_fetch_array it was: mysqli_fetch_assoc...nije bila namera da skrivam nista, ne zezaj

thanks for that sql injection alert, gonna see what is and try to fix it somehow

Airkish · 08-14-2018 , 19:30 Re: mysql / php thing

Try this:

PHP Code:


			
<?php

define('DBHOST', 'localhost');

define('DBUSER', '');

define('DBPASS', '');

define('DBNAME', '');



$dbcon = new mysqli(DBHOST, DBUSER, DBPASS, DBNAME); 

if($dbcon->connect_errno) {

    echo "Error connecting to db ". $dbcon->connect_errno.""; 

}



if (!$dbcon->set_charset("utf8")) {

    printf("Error loading character set utf8: %s\n", $dbcon->error);

    exit();

}



$map_name = $_GET['map'];

$query = $dbcon->prepare("SELECT `name`, `time`, `date` FROM rezultati JOIN players ON `players.id` = `rezultati.id` WHERE map = ? AND `time` ORDER BY `time` ASC LIMIT 15"); //AND `time` = ????? something's missing here

$query->bind_param("s", $map_name);

$query->execute();





?>

<html>

<body>

    <table>

    <?php

    while($result = $query->fetch_assoc())

    {

        $i++;

        echo 

        "

        <tr style='text-align: center'>

            <td>".$i."</td>

            <td>".$result['name']."</td>

            <td>".$result['time']."</td>

            <td>".substr($result['date'], 0, -8)."</td>

        </tr>

        ";

    }

    ?>

    </table>

</head>

</body>

</html>

Not Tested.

JocAnis · 08-14-2018 , 19:42 Re: mysql / php thing

@Airkish, i apreciate your help, but i said in my previously post, it was my bad in .sma for linking the url...its all ok now