[notMe2]

When on game and i try to use SQL_FastQuery its "freezes" the server while the query isnt finished. Its a rlly short query (just a update), and when i remove it, the server comes back to normal. There is a way to thread it? i saw on rankme, SQL_FastQuery is used all the time and there is no problem

thanks in advance

[Impact123]

I can't think of a single instance where i wouldn't use threading. It's explained on this wiki page.

[notMe2]

Originally Posted by Impact123 I can't think of a single instance where i wouldn't use threading. It's explained on this wiki page.

hm, there is just a a theoretical explanation, can you show me a code or something?

[KissLick]

Originally Posted by notMe2 hm, there is just a a theoretical explanation, can you show me a code or something?

How to connect to db -> https://wiki.alliedmods.net/SQL_%28S...9#Connecting_2 (SQL_TConnect)

How to send a query -> https://wiki.alliedmods.net/SQL_%28S...ng%29#Querying (SQL_TQuery)

[notMe2]

Originally Posted by KissLick How to connect to db -> https://wiki.alliedmods.net/SQL_%28S...9#Connecting_2 (SQL_TConnect) How to send a query -> https://wiki.alliedmods.net/SQL_%28S...ng%29#Querying (SQL_TQuery)

i'm already using it, and its freezing the server.

example:

the original code from rankMe is (on function SalvarPlayer):

SQL_TQuery(g_hStatsDb,SQL_SaveCallback,query,client,DBPrio_High); //the call

public SQL_SaveCallback(Handle:owner, Handle:hndl, const String:error[], any:client)
{
    new String:query2[150];
    if(hndl == INVALID_HANDLE)
    {
        LogError("[RankMe] Save Player Fail: %s", error);
        return;
    }
    
    /**
        Start the forward OnPlayerSaved
    */
    new Action:fResult;
    Call_StartForward(g_fwdOnPlayerSaved);
    Call_PushCell(client);
    new fError = Call_Finish(fResult);
    
    if (fError != SP_ERROR_NONE)
    {
        ThrowNativeError(fError, "Forward failed");
    }
        
}

my code:

SQL_TQuery(g_hStatsDb,SQL_SaveCallback,query,client,DBPrio_High); //the call

public SQL_SaveCallback(Handle:owner, Handle:hndl, const String:error[], any:client)
{
    new String:query2[150];
    if(hndl == INVALID_HANDLE)
    {
        LogError("[RankMe] Save Player Fail: %s", error);
        return;
    }
    
    Format(query2,sizeof(query2),"UPDATE `player_inventory` SET `iPoints` = %i WHERE `player_inventory`.`steamID` = '%s' AND `iPoints` is NULL;",g_aStats[client][SCORE],g_aClientSteam[client]);
    SQL_FastQuery(g_hStatsDb,query2);
    
    Format(query2,sizeof(query2),"UPDATE `player_inventory` SET `iPoints` = `iPoints` + %i WHERE `player_inventory`.`steamID` = '%s';",(g_aStats[client][SCORE] - g_aStartedScore[client]),g_aClientSteam[client]);
    SQL_FastQuery(g_hStatsDb,query2);

    /**
        Start the forward OnPlayerSaved
    */
    new Action:fResult;
    Call_StartForward(g_fwdOnPlayerSaved);
    Call_PushCell(client);
    new fError = Call_Finish(fResult);
    
    if (fError != SP_ERROR_NONE)
    {
        ThrowNativeError(fError, "Forward failed");
    }
        
}

freezes everytime the function is called

[Dr. Greg House]

Originally Posted by Impact123 I can't think of a single instance where i wouldn't use threading. [...]

Think harder.

[KissLick]

Is your database on localhost? I got these problems with SQLite on localhost, I switched to mysql on different server and everythings works fine.

EDIT: i see not every your SQL query is threaded.. (SQL_FastQuery(g_hStatsDb,query2);) - make it threaded too, just use empty callback.

[notMe2]

OnClientPutInServer

Originally Posted by KissLick Is your database on localhost? I got these problems with SQLite on localhost, I switched to mysql on different server and everythings works fine. EDIT: i see not every your SQL query is threaded.. (SQL_FastQuery(g_hStatsDb,query2);) - make it threaded too, just use empty callback.

just thread them too, its not freezing, but now i'm with other problem:

I'm with a big array, smt like array[maxplayers][72], and its set when the players connect to server (OnClientPutInServer), some people are getting crashed and the game simple closes. any ideas why this happens?

and call some querys on thread (not every time) is crashing the client too

--

Maybe this crash is related to call two threaded querys at the same time?

SQL_TQuery(g_hStatsDb,SQL_LoadPlayerCallback2,sQuery,client,DBPrio_High);
SQL_TQuery(g_hStatsDb,SQL_LoadPlayerCallback,query,client);

[neatek]

I dont know how TQuery can crash your server... but i dont recommend using OnClientPutInServer instead of OnClientPostAdminCheck.

Originally Posted by notMe2 SQL_TQuery(g_hStatsDb,SQL_LoadPlayerCallback2 ,sQuery,client,DBPrio_High); SQL_TQuery(g_hStatsDb,SQL_LoadPlayerCallback, query,client);

happens... omfg. You can put second query in first callback of query!

PHP Code:

public SomeThing()
{ 
    // first our query
    SQL_TQuery(g_hStatsDb,FIRST_SQL_QUERY_CALLBACK,sQuery,client,DBPrio_High);
}

// callback for first query
public FIRST_SQL_QUERY_CALLBACK(Handle:owner, Handle:hndl, const String:error[], any:client)
{
    SQL_TQuery(g_hStatsDb,SECOND_SQL_QUERY_CALLBACK,query,client); // second query
}

// callback for second query
public SECOND_SQL_QUERY_CALLBACK(Handle:owner, Handle:hndl, const String:error[], any:client)
{
    // o_o
} 


Looks like a PHP scripter...

[notMe2]

Originally Posted by neatek I dont know how TQuery can crash your server... but i dont recommend using OnClientPutInServer instead of OnClientPostAdminCheck. happens... omfg. You can put second query in first callback of query! PHP Code: public SomeThing() {      // first our query     SQL_TQuery(g_hStatsDb,FIRST_SQL_QUERY_CALLBACK,sQuery,client,DBPrio_High); } // callback for first query public FIRST_SQL_QUERY_CALLBACK(Handle:owner, Handle:hndl, const String:error[], any:client) {     SQL_TQuery(g_hStatsDb,SECOND_SQL_QUERY_CALLBACK,query,client); // second query } // callback for second query public SECOND_SQL_QUERY_CALLBACK(Handle:owner, Handle:hndl, const String:error[], any:client) {     // o_o }  Looks like a PHP scripter...

yeah haha, i done that right before you post it, and it seems to not crash anymore... well, i'll update in case of new events

---

Well, when the server has 5+ players the client still crashes, even with this method