[Watermelonnable]

Hello guys. I'm trying to understand where's the problem with my code here.

If I try to call my function "MessageEveryone" and pass it a string as argument, the compiler returns me "argument type mismatch"

This is how I'm trying to test it:

PHP Code:

MessageEveryone("helo"); 


And this is my MessageEveryone function:

PHP Code:

public MessageEveryone(message)
{
    for (new i = 0; i < g_MaxPlayers; i++) {
        if (!is_user_connected(i)) {
            continue;
        }
            
        doMagic(i, message, GREEN, 5.0);
    }
} 


If I remove the "message" parameter and insert the string directly in the "MessageEveryone" function it works perfectly:

PHP Code:

public MessageEveryone()
{
    for (new i = 0; i < g_MaxPlayers; i++) {
        if (!is_user_connected(i)) {
            continue;
        }
            
        doMagic(i, "this is a test", GREEN, 5.0);
    }
} 


What am I doing wrong?

[fysiks]

You need to understand how strings are stored in Pawn. You can take a look at one of the introductions to Pawn programming (e.g. here and here).

Long story short, strings are arrays of characters, your argument in your definition of MessageEveryone() needs to be an array:

MessageEveryone(message[])

P.S. That is a very inefficient method to loop through all players. The generally accepted "best" method is as follows:

new iPlayers[32], iNumPlayers, id
get_players(iPlayers, iNumPlayers)
for( new i = 0; i < iNumPlayers; i++)
{
    id = iPlayers[i]
    // Execute your code with "id"
}

[ddhoward]

PHP Code:

public MessageEveryone(message)
{ 


The compiler assumes that message is a single integer.

https://wiki.alliedmods.net/Pawn

PHP Code:

public MessageEveryone(message[])
{ 


Also, depending on what doMagic() is doing, you may want to also pass the length of the character array.

PHP Code:

public MessageEveryone(message[], len)
{
    for (new i = 0; i < g_MaxPlayers; i++) {
        if (!is_user_connected(i)) {
            continue;
        }
            
        doMagic(i, message, len, GREEN, 5.0);
    }
} 


EDIT: also yeah loop through players how fysiks suggested. Your method would be correct in Sourcemod, but I guess it's a different story in AMX Mod X.

[Watermelonnable]

Thank you so much guys. It worked like a charm now. And thank you fysiks, will have that in mind for the future