[Baws]

Originally Posted by Arkshine It does affect readability, there is no meaning and will confuse people as it overlaps with Hungarian notation. I'm not sure why you have this aggressive and stubborn attitude ; since you don't want to understand, let's do that : remove all these b, it's a requirement if you want to get reviewed and approved.

You serious? Why are you being so negative about it. And why do you just create or invent your requirements?


I will make sure to talk to a higher staff before i edit the plugin.

[BLacking98]

Originally Posted by baws You serious? Why are you being so negative about it. And why do you just create or invent your requirements? I will make sure to talk to a higher staff before i edit the plugin.

If by "higher staff" you mean Bailopan..
Lolz.. If not, you're out of luck

[Baws]

I'm out of luck anyway...ArkShine is like the one who does the stuff for amxx. I just need to do what he asked for i guess.

[Arkshine]

O-Okay, this a very serious matter. Let's ask BAILOPAN or asherkin about you want to keep badly your fancy self-congratulatory or something.

Joke apart. I will try another time, baws.

Look, you're submitting a plugin. It means you have some pawn knowledge, but it doesn't mean you know what you're doing.
Plugin Approver are people having solid pawn knowledge/experience and can review plugins to point out what is right and what is wrong.

There are no specific requirements. You can find some general remarks on the stickies of this section here and there.
It's up to each Plugin Approver to decide if something must be a requirement or optional, because they can judge a code.
The only purpose we have is : if a plugin get approved, it should be a quality plugin.

What you're doing is just silly. Readability is important and if you had more experience you would understand right away. That's it. You don't have much experience, your plugin is not well coded. We can tell what you're doing is wrong. Keep in mind plugin will be read by other people than you.

So, I would like you remove this 'b', like in your others versions, and you will be fine. You can have a personal coding style but here this is too much.
Hope this time you will understand.

[Baws]

I did man/women ( Sorry i don't know what you are or who you is ).
I just want it to get approved and improve my coding.
Plugin Updated!

[Arkshine]

Look, I've asked you kindly and you're insisting to keep some 'b' here and there. You are not going far with this attitude.

Update properly the plugin. I won't ask again.

And by the way, here some fast reviews :

• Your motd is static, something you should format one time
• Don't use a native to check one character
• Be consistent and use charsmax everywhere
• There is no need to explicitly pass number in menu_additem, it's done automatically.
• Then, there is no need to use menu_item_getinfo, item (+1) param should be enough
• read_file is a poor way to read lines in a file. Use instead fopen, fgets, etc. (file.inc)
• You can replace file_exists + formatex + write_file with fopen + fprints
• There is no point to use strbreak to get szFirstMsg when you have already value in Said.
• Using size of 1536 for g_MusicPlayer when it will contain only a file path, it's way too much.
• Don't create static variable in a loop, especially when such function will be called rarely.
• You can replace strbreak + replace_all x2 with parse
• In your condition with "search", using x2 strbreak is useless, you have already the value in Said + you know size of "search".
• Your for loop with SongCount should start to 0.
• You may want to consider 1.8.3 which integrates client_print_color native to avoid people using inefficient third-party lib (ColorChat).
• You should consider using multilingual system.
• Using such max songs value is inappropriate, for such use, dynamic array should be considered (cellarray.inc, celltrie.inc)

In your firt post, the "requirements" part doesn't make sense. Plugin requires just ColorChat, and you should give a link where to find it.

I'm unapproved this until you get your sense back, you stop with this annoying attitude, and you fix the plugin.
Feel free to ask to be reviewed again once work is done.

[tfk94]

i cant understand if he has so many problems in the plugin why dont u help him fix them
just post a improved code or something ..

[YamiKaitou]

Originally Posted by tfk94 i cant understand if he has so many problems in the plugin why dont u help him fix them just post a improved code or something ..

Because that is not the responsibility of Plugin Approvers. Plus, if we just give him the code, how will he learn and be able to support the plugin?

[tfk94]

by giving him the code he will see what he does wrong and in the future he can avoid doing the same mistakes i guess.. lol
no more spam

i just want a group menu for god sake ..
1 HIP HOP
2 ROCK
3 OTHER

and the amx_addsong command to be different for the groups like
amx_addsong_hiphop - adds song in hip hop group
amx_addsong_rock - adds song in rock group
etc

please someone do it ..

[Baws]

No i'm fixing it right now i'm almost done but he didn't gave me time to like fix it he just stated those and unapprove it but i respect his point.

Actually it really helped me as i didn't know some stuff but i know them now. I will post the updated one when i'm done. Thanks for waiting!

Thanks Ark.