Raised This Month: $305 Target: $400
 76%   Almost there!

[CS:GO] Crash after giving weapon_healthshot


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
kadet.89
Veteran Member
Join Date: Nov 2012
Old 06-16-2021 , 04:41   [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #1

I have a plugin which sometimes gives a weapon_healthshot item to a random player :
PHP Code:
int item GivePlayerItem(client"weapon_healthshot"); 
A few seconds after using this item my server crashes in about 1 out of 5 cases.

To analyse the problem I added a PlayerRunCmd prehook, where I iterate through m_hMyWeapons[64] of the player and print all not item_* and weapon_* entities.

Here is the log:
PHP Code:
L 06/15/2021 20:34:16: [test.smxGive"weapon_healthshot" with index 138 to player Fin.
L 06/15/2021 20:39:16: [test.smxImproper item "trigger_teleport " with index 138 in the invenory of Fin
The second line is printed in the PlayerRunCmd hook a few seconds after the player uses weapon_healthshot, then the server crashes.
My question is how such random items get to the inventory and why they have the same index as the weapon_healthshot which the plugin gives to players.
Is it caused by GivePlayerItem?

Yesterday I got a lot of "Improper..." for a player before the server crashed. Strange thing was that somewhere in the middle of the messages there were ~2 seconds without these logs and then all the rest "Improper..." were printed with another entity name. So the player at the begining had a weapon_healthshot in the inventory, then it was replaced to trigger_teleport and then to prop_dynamic_glow. The crash happend when the player left the game.

Last edited by kadet.89; 06-16-2021 at 05:42.
kadet.89 is offline
Send a message via Skype™ to kadet.89
Maxximou5
AlliedModders Donor
Join Date: Feb 2013
Old 06-16-2021 , 12:06   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #2

You should get a crash log of what is happening in case it isn't directly that action, from Accelerator. However, from my experience, you need to use RequestFrame or a timer to give healthshots with the best results. Not sure if it remains the same, but it was either crashing or not giving the item. I setup my plugins to use the following -
PHP Code:
RequestFrame(Frame_GiveHealthshotGetClientSerial(client));

public 
void Frame_GiveHealthshot(any serial)
{
    
int client GetClientFromSerial(serial)
    if (
client && IsClientInGame(client) && IsPlayerAlive(client))
    {
        
GivePlayerItem(client"weapon_healthshot");
    }

__________________

Last edited by Maxximou5; 06-16-2021 at 12:09.
Maxximou5 is online now
kadet.89
Veteran Member
Join Date: Nov 2012
Old 06-16-2021 , 13:04   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #3

Here is the place where it crashes:
PHP Code:
void CBasePlayer::UpdateClientDatavoid )
{
    ....
    for ( 
int i 0WeaponCount(); i++ )
    {
        if ( 
GetWeapon(i) )
            
GetWeapon(i)->UpdateClientDatathis ); // SIGSEGV happens here as UpdateClientData is only avaliable for CBaseWeapon entities
    
}
    ...

It looks like pure entity index is saved to the CBaseHandle so that when the weapon is deleted the index is reused for another entity and thus it is valid again. What I don't understend is why it happens and why it happens only with weapon_healthshot entities. I only have outdated sources which don't give any clues.
In crashstack it looks like this server.so + 0xbaddea with sdkhooks.ext.2.csgo.so in the 4-th step as the call goes through PreThink->PlayerRunCmd. But it doesn't provide any information for the reason to be easily identified as the crash happens far away from the point when something goes wrong.

Last edited by kadet.89; 06-16-2021 at 13:23.
kadet.89 is offline
Send a message via Skype™ to kadet.89
micapat
Veteran Member
Join Date: Feb 2010
Location: Nyuu, nyuu (France).
Old 06-16-2021 , 13:14   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #4

When are you trying to give the healthshot?

Use "SDKHook_SpawnPost" if at spawn.
__________________

Last edited by micapat; 06-16-2021 at 13:14.
micapat is offline
kadet.89
Veteran Member
Join Date: Nov 2012
Old 06-16-2021 , 13:32   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #5

They are given in 5 seconds after spawn.
kadet.89 is offline
Send a message via Skype™ to kadet.89
Maxximou5
AlliedModders Donor
Join Date: Feb 2013
Old 06-16-2021 , 13:44   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #6

It would be helpful to provide your iteration code as well. Also, it would be good to know what game_type and game_mode you are using.
__________________
Maxximou5 is online now
kadet.89
Veteran Member
Join Date: Nov 2012
Old 06-16-2021 , 14:27   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #7

"game_type" = "0"
"game_mode" = "0"
Iteration code is written in c++:

PHP Code:
void CPlayer::OnPlayerRunCmd(CUserCmd/*cmd*/void/*moveHelper*/)
{
    for(
int i 0!= MAX_WEAPONS_CSGO; ++i)
    {
        
CBaseEntityweapon GetMyWeaponHandle(i);
        if(!
weapon)
            continue;

        
std::string name(weapon->GetClassName());
        if (
name.rfind("weapon_"0) == 0)
            continue;

        if (
name.rfind("item_"0) == 0)
            continue;

        const 
int index weapon->Index();

        
LogMsg("Improper item \"%s\" with index %i in the invenory of %s"name.c_str(), indexGetName());
    }

    
RETURN_META(MRES_IGNORED);


Here is what under the hood of the GetMyWeaponHandle function:
PHP Code:
CFakeHandleCBaseCombatCharacter::GetMyWeaponHandle(int index) const
{
    return 
m_hMyWeapons[index];

PHP Code:
class CFakeHandle : public CBaseHandle
{
public:
    
operator CBaseEntity* () const
    {
        if (!
IsValid())
            return 
nullptr;

        const 
int index GetEntryIndex();

        const 
cell_t ref gamehelpers->IndexToReference(index);
        if(
ref == -1)
            return 
nullptr;

        return 
gamehelpers->ReferenceToEntity(ref);
    }
}; 

Last edited by kadet.89; 06-16-2021 at 16:00.
kadet.89 is offline
Send a message via Skype™ to kadet.89
kadet.89
Veteran Member
Join Date: Nov 2012
Old 06-17-2021 , 06:13   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #8

I got new logs:
PHP Code:
L 06/17/2021 09:33:08: [TRIPMINESWeapon classnameflashbang_projectile handlindex (reference): 471007374 index142 serial number7187 entry index 142 playerDerby
L 06
/17/2021 09:33:20: [TRIPMINESWeapon classnameprop_dynamic handlindex (reference): 471007374 index142 serial number7187 entry index 142 playerDerby 
Looks like after weapon_healthshot is deleted, another entity is created with the same serial number (the same reference) and it happens again if that new entity is deleted.

Last edited by kadet.89; 06-17-2021 at 06:16.
kadet.89 is offline
Send a message via Skype™ to kadet.89
micapat
Veteran Member
Join Date: Feb 2010
Location: Nyuu, nyuu (France).
Old 06-17-2021 , 07:45   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #9

Post your plugin code.

"GivePlayerItem(client, "weapon_healthshot");" should work without any problem with game_type/mode 0.

What're u doing with the "item" returned by GivePlayerItem() ?
__________________

Last edited by micapat; 06-17-2021 at 07:48.
micapat is offline
kadet.89
Veteran Member
Join Date: Nov 2012
Old 06-17-2021 , 09:29   Re: [CS:GO] Crash after giving weapon_healthshot
Reply With Quote #10

I'm away now, can't share the code. But it's as simple as possible.
There is a player spawn hook with a 5sec timer. In the timer callback function the player (if still exists) is given 1 such item. I get the index, but don't do anything with it.
I doubt that it is possible to create such a serious bug with sourcepawn code. That must be something wrong on the engine level. Beside, I have other plugins wich use GivePlayerItem with other item types and it doesn't lead to this problem.

Last edited by kadet.89; 06-17-2021 at 09:35.
kadet.89 is offline
Send a message via Skype™ to kadet.89
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 19:50.


Powered by vBulletin®
Copyright ©2000 - 2021, vBulletin Solutions, Inc.
Theme made by Freecode